* [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem
@ 2019-05-23 19:53 Sven Van Asbroeck
2019-05-23 19:53 ` [PATCH 2/2] MAINTAINERS: Add entry for anybuss drivers Sven Van Asbroeck
2019-05-23 20:00 ` [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem Joe Perches
0 siblings, 2 replies; 5+ messages in thread
From: Sven Van Asbroeck @ 2019-05-23 19:53 UTC (permalink / raw)
To: Greg KH; +Cc: Dan Carpenter, devel, Linux Kernel Mailing List
Add myself as the maintainer of the fieldbus subsystem.
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
---
MAINTAINERS | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5cfbea4ce575..1cac53bced08 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14905,6 +14905,11 @@ L: linux-erofs@lists.ozlabs.org
S: Maintained
F: drivers/staging/erofs/
+STAGING - FIELDBUS SUBSYSTEM
+M: Sven Van Asbroeck <TheSven73@gmail.com>
+S: Maintained
+F: drivers/staging/fieldbus/*
+
STAGING - INDUSTRIAL IO
M: Jonathan Cameron <jic23@kernel.org>
L: linux-iio@vger.kernel.org
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] MAINTAINERS: Add entry for anybuss drivers
2019-05-23 19:53 [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem Sven Van Asbroeck
@ 2019-05-23 19:53 ` Sven Van Asbroeck
2019-05-23 20:00 ` [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem Joe Perches
1 sibling, 0 replies; 5+ messages in thread
From: Sven Van Asbroeck @ 2019-05-23 19:53 UTC (permalink / raw)
To: Greg KH; +Cc: Dan Carpenter, devel, Linux Kernel Mailing List
Add myself as the maintainer of the anybuss bus driver, and its client
drivers.
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
---
MAINTAINERS | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1cac53bced08..68d49623186f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14910,6 +14910,11 @@ M: Sven Van Asbroeck <TheSven73@gmail.com>
S: Maintained
F: drivers/staging/fieldbus/*
+STAGING - HMS ANYBUS-S BUS
+M: Sven Van Asbroeck <TheSven73@gmail.com>
+S: Maintained
+F: drivers/staging/fieldbus/anybuss/
+
STAGING - INDUSTRIAL IO
M: Jonathan Cameron <jic23@kernel.org>
L: linux-iio@vger.kernel.org
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem
2019-05-23 19:53 [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem Sven Van Asbroeck
2019-05-23 19:53 ` [PATCH 2/2] MAINTAINERS: Add entry for anybuss drivers Sven Van Asbroeck
@ 2019-05-23 20:00 ` Joe Perches
2019-05-23 20:23 ` Sven Van Asbroeck
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2019-05-23 20:00 UTC (permalink / raw)
To: Sven Van Asbroeck, Greg KH
Cc: Dan Carpenter, devel, Linux Kernel Mailing List
On Thu, 2019-05-23 at 15:53 -0400, Sven Van Asbroeck wrote:
> Add myself as the maintainer of the fieldbus subsystem.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -14905,6 +14905,11 @@ L: linux-erofs@lists.ozlabs.org
> S: Maintained
> F: drivers/staging/erofs/
>
> +STAGING - FIELDBUS SUBSYSTEM
> +M: Sven Van Asbroeck <TheSven73@gmail.com>
> +S: Maintained
> +F: drivers/staging/fieldbus/*
The F: pattern above excludes subdirectories.
What about the drivers/staging/fieldbus/Documentation directory?
patch 2/2 specifically covers the anybuss directory,
but the Documentation directory has no matching pattern.
trivia: anybuss looks like a misspelling.
It might be better as anybus-s.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem
2019-05-23 20:00 ` [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem Joe Perches
@ 2019-05-23 20:23 ` Sven Van Asbroeck
2019-05-23 21:02 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Sven Van Asbroeck @ 2019-05-23 20:23 UTC (permalink / raw)
To: Joe Perches; +Cc: Greg KH, Dan Carpenter, devel, Linux Kernel Mailing List
On Thu, May 23, 2019 at 4:00 PM Joe Perches <joe@perches.com> wrote:
> patch 2/2 specifically covers the anybuss directory,
> but the Documentation directory has no matching pattern.
Thank you for spotting that, I will re-spin the set.
>
> trivia: anybuss looks like a misspelling.
> It might be better as anybus-s.
>
This came up as well during the review process. When we insert a separator,
the include files start looking like anybus-s-controller.h, and the structs
become like struct anybus_s_ops. It then no longer looks like a misspelling,
but becomes harder to read?
An alternative solution is to get rid of the 's' suffix altogether. Anybus-S
is the only flavour we support right now. Although that may obviously
change in the future.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem
2019-05-23 20:23 ` Sven Van Asbroeck
@ 2019-05-23 21:02 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2019-05-23 21:02 UTC (permalink / raw)
To: Sven Van Asbroeck
Cc: Greg KH, Dan Carpenter, devel, Linux Kernel Mailing List
On Thu, 2019-05-23 at 16:23 -0400, Sven Van Asbroeck wrote:
> On Thu, May 23, 2019 at 4:00 PM Joe Perches <joe@perches.com> wrote:
> > trivia: anybuss looks like a misspelling.
> > It might be better as anybus-s.
> This came up as well during the review process. When we insert a separator,
> the include files start looking like anybus-s-controller.h, and the structs
> become like struct anybus_s_ops. It then no longer looks like a misspelling,
> but becomes harder to read?
>
> An alternative solution is to get rid of the 's' suffix altogether. Anybus-S
> is the only flavour we support right now. Although that may obviously
> change in the future.
anybuss just looked odd to me.
Whatever you choose is up to you and
no doubt you'll choose well.
cheers, Joe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-23 21:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 19:53 [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem Sven Van Asbroeck
2019-05-23 19:53 ` [PATCH 2/2] MAINTAINERS: Add entry for anybuss drivers Sven Van Asbroeck
2019-05-23 20:00 ` [PATCH 1/2] MAINTAINERS: Add entry for fieldbus subsystem Joe Perches
2019-05-23 20:23 ` Sven Van Asbroeck
2019-05-23 21:02 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.