All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rong Chen <rong.a.chen@intel.com>
To: Andi Kleen <ak@linux.intel.com>, kbuild test robot <lkp@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	kbuild-all@lists.01.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [kbuild-all] Re: [PATCH v3] x86: Add trace points to (nearly) all vectors
Date: Thu, 7 Nov 2019 09:51:18 +0800	[thread overview]
Message-ID: <1b7cd867-c465-40ec-6250-f92ebea2bb4f@intel.com> (raw)
In-Reply-To: <20191105014606.GC25308@tassilo.jf.intel.com>



On 11/5/19 9:46 AM, Andi Kleen wrote:
> On Sat, Nov 02, 2019 at 08:47:59AM +0800, kbuild test robot wrote:
>> Hi Andi,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on tip/auto-latest]
>> [also build test ERROR on v5.4-rc5 next-20191031]
>> [if your patch is applied to the wrong git tree, please drop us a note to help
>> improve the system. BTW, we also suggest to use '--base' option to specify the
>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>>
>> url:    https://github.com/0day-ci/linux/commits/Andi-Kleen/x86-Add-trace-points-to-nearly-all-vectors/20191102-063457
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a5b576bfb3ba85d3e356f9900dce1428d4760582
>> config: i386-tinyconfig (attached as .config)
>> compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
>> reproduce:
>>          # save the attached .config to linux build tree
>>          make ARCH=i386
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     arch/x86/kernel/traps.c: In function 'do_error_trap':
>>>> arch/x86/kernel/traps.c:264:2: error: implicit declaration of function 'trace_other_vector_entry'; did you mean 'frame_vector_destroy'? [-Werror=implicit-function-declaration]
>>       trace_other_vector_entry(trapnr);
>>       ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Also cannot reproduce and the config file seems to be not matching the kernel.
>
> The file has the correct include:
>
> vi +60 arch/x86/kernel/traps.c
>
> ...
>   60 #include <asm/trace/irq_vectors.h>
>

Hi Andi,

I think it's a kconfig issue, CONFIG_X86_LOCAL_APIC  is necessary 
according to your patch,
but i386-tinyconfig doesn't contain it.

arch/x86/include/asm/trace/irq_vectors.h:

  11 #ifdef CONFIG_X86_LOCAL_APIC

Best Regards,
Rong Chen

WARNING: multiple messages have this Message-ID (diff)
From: Rong Chen <rong.a.chen@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3] x86: Add trace points to (nearly) all vectors
Date: Thu, 07 Nov 2019 09:51:18 +0800	[thread overview]
Message-ID: <1b7cd867-c465-40ec-6250-f92ebea2bb4f@intel.com> (raw)
In-Reply-To: <20191105014606.GC25308@tassilo.jf.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]



On 11/5/19 9:46 AM, Andi Kleen wrote:
> On Sat, Nov 02, 2019 at 08:47:59AM +0800, kbuild test robot wrote:
>> Hi Andi,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on tip/auto-latest]
>> [also build test ERROR on v5.4-rc5 next-20191031]
>> [if your patch is applied to the wrong git tree, please drop us a note to help
>> improve the system. BTW, we also suggest to use '--base' option to specify the
>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>>
>> url:    https://github.com/0day-ci/linux/commits/Andi-Kleen/x86-Add-trace-points-to-nearly-all-vectors/20191102-063457
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a5b576bfb3ba85d3e356f9900dce1428d4760582
>> config: i386-tinyconfig (attached as .config)
>> compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
>> reproduce:
>>          # save the attached .config to linux build tree
>>          make ARCH=i386
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     arch/x86/kernel/traps.c: In function 'do_error_trap':
>>>> arch/x86/kernel/traps.c:264:2: error: implicit declaration of function 'trace_other_vector_entry'; did you mean 'frame_vector_destroy'? [-Werror=implicit-function-declaration]
>>       trace_other_vector_entry(trapnr);
>>       ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Also cannot reproduce and the config file seems to be not matching the kernel.
>
> The file has the correct include:
>
> vi +60 arch/x86/kernel/traps.c
>
> ...
>   60 #include <asm/trace/irq_vectors.h>
>

Hi Andi,

I think it's a kconfig issue, CONFIG_X86_LOCAL_APIC  is necessary 
according to your patch,
but i386-tinyconfig doesn't contain it.

arch/x86/include/asm/trace/irq_vectors.h:

  11 #ifdef CONFIG_X86_LOCAL_APIC

Best Regards,
Rong Chen

  reply	other threads:[~2019-11-07  1:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 19:56 [PATCH v3] x86: Add trace points to (nearly) all vectors Andi Kleen
2019-11-02  0:47 ` kbuild test robot
2019-11-02  0:47   ` kbuild test robot
2019-11-05  1:46   ` Andi Kleen
2019-11-05  1:46     ` Andi Kleen
2019-11-07  1:51     ` Rong Chen [this message]
2019-11-07  1:51       ` Rong Chen
2019-11-02  1:24 ` kbuild test robot
2019-11-02  1:24   ` kbuild test robot
2019-11-05  1:44   ` Andi Kleen
2019-11-05  1:44     ` Andi Kleen
2019-11-05 16:55     ` Andi Kleen
2019-11-05 16:55       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b7cd867-c465-40ec-6250-f92ebea2bb4f@intel.com \
    --to=rong.a.chen@intel.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.