All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Andreas Schwab' <schwab@linux-m68k.org>
Cc: "'Leizhen (ThunderTown)'" <thunder.leizhen@huawei.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
	Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	"Jiri Olsa" <jolsa@kernel.org>, Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: RE: [PATCH v9] kallsyms: Add self-test facility
Date: Fri, 16 Dec 2022 15:25:42 +0000	[thread overview]
Message-ID: <1ba1fadb39994a4d91edabdfd9d69fa6@AcuMS.aculab.com> (raw)
In-Reply-To: <87pmcjidfe.fsf@igel.home>

From: Andreas Schwab <schwab@linux-m68k.org>
> Sent: 16 December 2022 15:20
> 
> On Dez 16 2022, David Laight wrote:
> 
> > 'cs' and 'ct' should be input parameters.
> 
> They are (and output as well).

Right, but the 'output' values aren't needed and get
discarded because the asm block in inside a static inline.

It could be a recipe just waiting to go wrong.

But I bet the actual problem is the output register
aliasing one of the inputs and then reading from very
low user addresses - I bet they don't fault on m68k.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


  reply	other threads:[~2022-12-16 15:25 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15  8:33 [PATCH v9] kallsyms: Add self-test facility Zhen Lei
2022-11-15  8:42 ` Luis Chamberlain
2022-11-15  8:43 ` Leizhen (ThunderTown)
2022-11-22 12:29 ` kernel test robot
2022-11-22 13:24   ` Leizhen (ThunderTown)
2022-11-22 15:31 ` kernel test robot
2022-12-15  8:50 ` Geert Uytterhoeven
2022-12-15  9:16   ` Leizhen (ThunderTown)
2022-12-15  9:39     ` Geert Uytterhoeven
2022-12-15 12:33       ` Leizhen (ThunderTown)
2022-12-15 13:24         ` Geert Uytterhoeven
2022-12-15 13:58           ` Leizhen (ThunderTown)
2022-12-15 14:40             ` Leizhen (ThunderTown)
2022-12-15 14:51               ` Geert Uytterhoeven
2022-12-16  7:42                 ` Leizhen (ThunderTown)
2022-12-16  9:36                   ` Leizhen (ThunderTown)
2022-12-16 11:28                     ` Geert Uytterhoeven
2022-12-16 12:01                       ` Leizhen (ThunderTown)
2022-12-16 13:29                         ` David Laight
2022-12-16 14:44                           ` David Laight
2022-12-16 15:19                             ` Andreas Schwab
2022-12-16 15:25                               ` David Laight [this message]
2022-12-16 15:54                                 ` Andreas Schwab
2022-12-16 16:09                                   ` David Laight
2022-12-16 16:11                                     ` Andreas Schwab
2022-12-16 16:32                                       ` David Laight
2022-12-16 16:53                                         ` Steven Rostedt
2022-12-16 16:57                                           ` David Laight
2022-12-16 17:19                                             ` Steven Rostedt
2022-12-16 17:38                                               ` Steven Rostedt
2022-12-16 19:27                                                 ` David Laight
2022-12-17  7:31                                                   ` Leizhen (ThunderTown)
2022-12-17 13:37                                                     ` Geert Uytterhoeven
2022-12-17 17:37                                                       ` David Laight
2022-12-16 11:57                     ` Andreas Schwab
2022-12-16 13:31                       ` Leizhen (ThunderTown)
2022-12-16 13:47                         ` Andreas Schwab
2022-12-15 14:43             ` Geert Uytterhoeven
2022-12-15 14:51               ` Andreas Schwab
2022-12-16 10:40           ` David Laight
2022-12-16 11:40             ` Leizhen (ThunderTown)
2022-12-16 11:44           ` Andreas Schwab
2022-12-16 11:57             ` Leizhen (ThunderTown)
2022-12-16 12:39               ` Andreas Schwab
2022-12-16 13:31                 ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba1fadb39994a4d91edabdfd9d69fa6@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=Jason@zx2c4.com \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mcgrof@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=schwab@linux-m68k.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.