From: David Laight <David.Laight@ACULAB.COM>
To: 'Steven Rostedt' <rostedt@goodmis.org>
Cc: 'Andreas Schwab' <schwab@linux-m68k.org>,
"'Leizhen (ThunderTown)'" <thunder.leizhen@huawei.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
"Joe Lawrence" <joe.lawrence@redhat.com>,
"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: RE: [PATCH v9] kallsyms: Add self-test facility
Date: Fri, 16 Dec 2022 16:57:54 +0000 [thread overview]
Message-ID: <ecf4939dbff84709a1782a8e8851b29f@AcuMS.aculab.com> (raw)
In-Reply-To: <20221216115314.6120beb7@gandalf.local.home>
From: Steven Rostedt
> Sent: 16 December 2022 16:53
>
> On Fri, 16 Dec 2022 16:32:08 +0000
> David Laight <David.Laight@ACULAB.COM> wrote:
>
> > From: Andreas Schwab
> > > Sent: 16 December 2022 16:12
> > > On Dez 16 2022, David Laight wrote:
> > >
> > > > The other issue is a missing "memory" clobber.
> > >
> > > strcmp is a pure read-only operation.
> >
> > Still needs the memory clobber.
>
> What memory is being modified?
>
> I don't know m68k assembly, but I'm guessing the (%O)+ and the (%1)+ only
> modifies the register being used, and no memory is being touched.
Memory is being read so a clobber is needed to ensure that all pending
writes have been done.
Although, in this case, the memory being read is effectively
read only so nothing should be pending.
But it really does look like something is 'smelly' with the
constraints.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-12-16 16:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 8:33 [PATCH v9] kallsyms: Add self-test facility Zhen Lei
2022-11-15 8:42 ` Luis Chamberlain
2022-11-15 8:43 ` Leizhen (ThunderTown)
2022-11-22 12:29 ` kernel test robot
2022-11-22 13:24 ` Leizhen (ThunderTown)
2022-11-22 15:31 ` kernel test robot
2022-12-15 8:50 ` Geert Uytterhoeven
2022-12-15 9:16 ` Leizhen (ThunderTown)
2022-12-15 9:39 ` Geert Uytterhoeven
2022-12-15 12:33 ` Leizhen (ThunderTown)
2022-12-15 13:24 ` Geert Uytterhoeven
2022-12-15 13:58 ` Leizhen (ThunderTown)
2022-12-15 14:40 ` Leizhen (ThunderTown)
2022-12-15 14:51 ` Geert Uytterhoeven
2022-12-16 7:42 ` Leizhen (ThunderTown)
2022-12-16 9:36 ` Leizhen (ThunderTown)
2022-12-16 11:28 ` Geert Uytterhoeven
2022-12-16 12:01 ` Leizhen (ThunderTown)
2022-12-16 13:29 ` David Laight
2022-12-16 14:44 ` David Laight
2022-12-16 15:19 ` Andreas Schwab
2022-12-16 15:25 ` David Laight
2022-12-16 15:54 ` Andreas Schwab
2022-12-16 16:09 ` David Laight
2022-12-16 16:11 ` Andreas Schwab
2022-12-16 16:32 ` David Laight
2022-12-16 16:53 ` Steven Rostedt
2022-12-16 16:57 ` David Laight [this message]
2022-12-16 17:19 ` Steven Rostedt
2022-12-16 17:38 ` Steven Rostedt
2022-12-16 19:27 ` David Laight
2022-12-17 7:31 ` Leizhen (ThunderTown)
2022-12-17 13:37 ` Geert Uytterhoeven
2022-12-17 17:37 ` David Laight
2022-12-16 11:57 ` Andreas Schwab
2022-12-16 13:31 ` Leizhen (ThunderTown)
2022-12-16 13:47 ` Andreas Schwab
2022-12-15 14:43 ` Geert Uytterhoeven
2022-12-15 14:51 ` Andreas Schwab
2022-12-16 10:40 ` David Laight
2022-12-16 11:40 ` Leizhen (ThunderTown)
2022-12-16 11:44 ` Andreas Schwab
2022-12-16 11:57 ` Leizhen (ThunderTown)
2022-12-16 12:39 ` Andreas Schwab
2022-12-16 13:31 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecf4939dbff84709a1782a8e8851b29f@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=geert@linux-m68k.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=schwab@linux-m68k.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.