* [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
@ 2022-07-31 12:51 ` Ban Tao
0 siblings, 0 replies; 9+ messages in thread
From: Ban Tao @ 2022-07-31 12:51 UTC (permalink / raw)
To: fengzheng923, lgirdwood, broonie, robh+dt,
krzysztof.kozlowski+dt, wens, jernej.skrabec, samuel, alsa-devel
Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel
DT binding documentation for this new ASoC driver.
Signed-off-by: Ban Tao <fengzheng923@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
---
v1->v2:
1.Fix some build errors.
v2->v3:
1.Fix some build errors.
v3->v4:
1.None.
v4->v5:
1.Add interrupt.
2.Keep clock and reset index.
v5->v6:
1.None.
v6->v7:
1.None.
---
.../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 ++++++++++++++++++++++
1 file changed, 79 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
new file mode 100644
index 0000000..185d3e4
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner H6 DMIC Device Tree Bindings
+
+maintainers:
+ - Ban Tao <fengzheng923@gmail.com>
+
+properties:
+ "#sound-dai-cells":
+ const: 0
+
+ compatible:
+ const: allwinner,sun50i-h6-dmic
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Bus Clock
+ - description: Module Clock
+
+ clock-names:
+ items:
+ - const: bus
+ - const: mod
+
+ dmas:
+ items:
+ - description: RX DMA Channel
+
+ dma-names:
+ items:
+ - const: rx
+
+ resets:
+ maxItems: 1
+
+required:
+ - "#sound-dai-cells"
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - dmas
+ - dma-names
+ - resets
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ #include <dt-bindings/clock/sun50i-h6-ccu.h>
+ #include <dt-bindings/reset/sun50i-h6-ccu.h>
+
+ dmic: dmic@5095000 {
+ #sound-dai-cells = <0>;
+ compatible = "allwinner,sun50i-h6-dmic";
+ reg = <0x05095000 0x400>;
+ interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>;
+ clock-names = "bus", "mod";
+ dmas = <&dma 7>;
+ dma-names = "rx";
+ resets = <&ccu RST_BUS_DMIC>;
+ };
+
+...
\ No newline at end of file
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
@ 2022-07-31 12:51 ` Ban Tao
0 siblings, 0 replies; 9+ messages in thread
From: Ban Tao @ 2022-07-31 12:51 UTC (permalink / raw)
To: fengzheng923, lgirdwood, broonie, robh+dt,
krzysztof.kozlowski+dt, wens, jernej.skrabec, samuel, alsa-devel
Cc: devicetree, linux-sunxi, linux-arm-kernel, linux-kernel
DT binding documentation for this new ASoC driver.
Signed-off-by: Ban Tao <fengzheng923@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
---
v1->v2:
1.Fix some build errors.
v2->v3:
1.Fix some build errors.
v3->v4:
1.None.
v4->v5:
1.Add interrupt.
2.Keep clock and reset index.
v5->v6:
1.None.
v6->v7:
1.None.
---
.../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 ++++++++++++++++++++++
1 file changed, 79 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
new file mode 100644
index 0000000..185d3e4
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner H6 DMIC Device Tree Bindings
+
+maintainers:
+ - Ban Tao <fengzheng923@gmail.com>
+
+properties:
+ "#sound-dai-cells":
+ const: 0
+
+ compatible:
+ const: allwinner,sun50i-h6-dmic
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Bus Clock
+ - description: Module Clock
+
+ clock-names:
+ items:
+ - const: bus
+ - const: mod
+
+ dmas:
+ items:
+ - description: RX DMA Channel
+
+ dma-names:
+ items:
+ - const: rx
+
+ resets:
+ maxItems: 1
+
+required:
+ - "#sound-dai-cells"
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - dmas
+ - dma-names
+ - resets
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ #include <dt-bindings/clock/sun50i-h6-ccu.h>
+ #include <dt-bindings/reset/sun50i-h6-ccu.h>
+
+ dmic: dmic@5095000 {
+ #sound-dai-cells = <0>;
+ compatible = "allwinner,sun50i-h6-dmic";
+ reg = <0x05095000 0x400>;
+ interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>;
+ clock-names = "bus", "mod";
+ dmas = <&dma 7>;
+ dma-names = "rx";
+ resets = <&ccu RST_BUS_DMIC>;
+ };
+
+...
\ No newline at end of file
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
@ 2022-07-31 12:51 ` Ban Tao
0 siblings, 0 replies; 9+ messages in thread
From: Ban Tao @ 2022-07-31 12:51 UTC (permalink / raw)
To: fengzheng923, lgirdwood, broonie, robh+dt,
krzysztof.kozlowski+dt, wens, jernej.skrabec, samuel, alsa-devel
Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel
DT binding documentation for this new ASoC driver.
Signed-off-by: Ban Tao <fengzheng923@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
---
v1->v2:
1.Fix some build errors.
v2->v3:
1.Fix some build errors.
v3->v4:
1.None.
v4->v5:
1.Add interrupt.
2.Keep clock and reset index.
v5->v6:
1.None.
v6->v7:
1.None.
---
.../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 ++++++++++++++++++++++
1 file changed, 79 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
new file mode 100644
index 0000000..185d3e4
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Allwinner H6 DMIC Device Tree Bindings
+
+maintainers:
+ - Ban Tao <fengzheng923@gmail.com>
+
+properties:
+ "#sound-dai-cells":
+ const: 0
+
+ compatible:
+ const: allwinner,sun50i-h6-dmic
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Bus Clock
+ - description: Module Clock
+
+ clock-names:
+ items:
+ - const: bus
+ - const: mod
+
+ dmas:
+ items:
+ - description: RX DMA Channel
+
+ dma-names:
+ items:
+ - const: rx
+
+ resets:
+ maxItems: 1
+
+required:
+ - "#sound-dai-cells"
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - dmas
+ - dma-names
+ - resets
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ #include <dt-bindings/clock/sun50i-h6-ccu.h>
+ #include <dt-bindings/reset/sun50i-h6-ccu.h>
+
+ dmic: dmic@5095000 {
+ #sound-dai-cells = <0>;
+ compatible = "allwinner,sun50i-h6-dmic";
+ reg = <0x05095000 0x400>;
+ interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>;
+ clock-names = "bus", "mod";
+ dmas = <&dma 7>;
+ dma-names = "rx";
+ resets = <&ccu RST_BUS_DMIC>;
+ };
+
+...
\ No newline at end of file
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
2022-07-31 12:51 ` Ban Tao
(?)
@ 2022-07-31 16:02 ` Rob Herring
-1 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-07-31 16:02 UTC (permalink / raw)
To: Ban Tao
Cc: jernej.skrabec, samuel, krzysztof.kozlowski+dt, devicetree,
lgirdwood, linux-sunxi, robh+dt, linux-kernel, linux-arm-kernel,
alsa-devel, broonie, wens
On Sun, 31 Jul 2022 05:51:01 -0700, Ban Tao wrote:
> DT binding documentation for this new ASoC driver.
>
> Signed-off-by: Ban Tao <fengzheng923@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Maxime Ripard <maxime@cerno.tech>
> ---
> v1->v2:
> 1.Fix some build errors.
>
> v2->v3:
> 1.Fix some build errors.
>
> v3->v4:
> 1.None.
>
> v4->v5:
> 1.Add interrupt.
> 2.Keep clock and reset index.
>
> v5->v6:
> 1.None.
>
> v6->v7:
> 1.None.
> ---
> .../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 ++++++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml:79:4: [error] no new line character at the end of file (new-line-at-end-of-file)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
@ 2022-07-31 16:02 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-07-31 16:02 UTC (permalink / raw)
To: Ban Tao
Cc: devicetree, alsa-devel, samuel, broonie, lgirdwood,
jernej.skrabec, linux-kernel, wens, robh+dt,
krzysztof.kozlowski+dt, linux-sunxi, linux-arm-kernel
On Sun, 31 Jul 2022 05:51:01 -0700, Ban Tao wrote:
> DT binding documentation for this new ASoC driver.
>
> Signed-off-by: Ban Tao <fengzheng923@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Maxime Ripard <maxime@cerno.tech>
> ---
> v1->v2:
> 1.Fix some build errors.
>
> v2->v3:
> 1.Fix some build errors.
>
> v3->v4:
> 1.None.
>
> v4->v5:
> 1.Add interrupt.
> 2.Keep clock and reset index.
>
> v5->v6:
> 1.None.
>
> v6->v7:
> 1.None.
> ---
> .../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 ++++++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml:79:4: [error] no new line character at the end of file (new-line-at-end-of-file)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
@ 2022-07-31 16:02 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-07-31 16:02 UTC (permalink / raw)
To: Ban Tao
Cc: jernej.skrabec, samuel, krzysztof.kozlowski+dt, devicetree,
lgirdwood, linux-sunxi, robh+dt, linux-kernel, linux-arm-kernel,
alsa-devel, broonie, wens
On Sun, 31 Jul 2022 05:51:01 -0700, Ban Tao wrote:
> DT binding documentation for this new ASoC driver.
>
> Signed-off-by: Ban Tao <fengzheng923@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Maxime Ripard <maxime@cerno.tech>
> ---
> v1->v2:
> 1.Fix some build errors.
>
> v2->v3:
> 1.Fix some build errors.
>
> v3->v4:
> 1.None.
>
> v4->v5:
> 1.Add interrupt.
> 2.Keep clock and reset index.
>
> v5->v6:
> 1.None.
>
> v6->v7:
> 1.None.
> ---
> .../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 ++++++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml:79:4: [error] no new line character at the end of file (new-line-at-end-of-file)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
2022-07-31 12:51 ` Ban Tao
(?)
@ 2022-08-02 10:40 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-02 10:40 UTC (permalink / raw)
To: Ban Tao, lgirdwood, broonie, robh+dt, krzysztof.kozlowski+dt,
wens, jernej.skrabec, samuel, alsa-devel
Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel
On 31/07/2022 14:51, Ban Tao wrote:
> + dmic: dmic@5095000 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun50i-h6-dmic";
> + reg = <0x05095000 0x400>;
> + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>;
> + clock-names = "bus", "mod";
> + dmas = <&dma 7>;
> + dma-names = "rx";
> + resets = <&ccu RST_BUS_DMIC>;
> + };
> +
> +...
> \ No newline at end of file
This has to be fixed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
@ 2022-08-02 10:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-02 10:40 UTC (permalink / raw)
To: Ban Tao, lgirdwood, broonie, robh+dt, krzysztof.kozlowski+dt,
wens, jernej.skrabec, samuel, alsa-devel
Cc: devicetree, linux-sunxi, linux-arm-kernel, linux-kernel
On 31/07/2022 14:51, Ban Tao wrote:
> + dmic: dmic@5095000 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun50i-h6-dmic";
> + reg = <0x05095000 0x400>;
> + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>;
> + clock-names = "bus", "mod";
> + dmas = <&dma 7>;
> + dma-names = "rx";
> + resets = <&ccu RST_BUS_DMIC>;
> + };
> +
> +...
> \ No newline at end of file
This has to be fixed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
@ 2022-08-02 10:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-02 10:40 UTC (permalink / raw)
To: Ban Tao, lgirdwood, broonie, robh+dt, krzysztof.kozlowski+dt,
wens, jernej.skrabec, samuel, alsa-devel
Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel
On 31/07/2022 14:51, Ban Tao wrote:
> + dmic: dmic@5095000 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun50i-h6-dmic";
> + reg = <0x05095000 0x400>;
> + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>;
> + clock-names = "bus", "mod";
> + dmas = <&dma 7>;
> + dma-names = "rx";
> + resets = <&ccu RST_BUS_DMIC>;
> + };
> +
> +...
> \ No newline at end of file
This has to be fixed.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-08-02 10:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-31 12:51 [PATCH v7 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller Ban Tao
2022-07-31 12:51 ` Ban Tao
2022-07-31 12:51 ` Ban Tao
2022-07-31 16:02 ` Rob Herring
2022-07-31 16:02 ` Rob Herring
2022-07-31 16:02 ` Rob Herring
2022-08-02 10:40 ` Krzysztof Kozlowski
2022-08-02 10:40 ` Krzysztof Kozlowski
2022-08-02 10:40 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.