* [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set
@ 2021-12-06 12:45 Daniel Henrique Barboza
2021-12-06 12:59 ` Luis Fernando Fujita Pires
2021-12-06 13:03 ` Cédric Le Goater
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Henrique Barboza @ 2021-12-06 12:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Daniel Henrique Barboza, qemu-ppc, clg, david
Setting -uuid in the pnv machine does not work:
./qemu-system-ppc64 -machine powernv8,accel=tcg -uuid 7ff61ca1-a4a0-4bc1-944c-abd114a35e80
qemu-system-ppc64: error creating device tree: (fdt_property_string(fdt, "system-id", buf)): FDT_ERR_BADSTATE
This happens because we're using "fdt_property_string" to retrieve a
"system-id" attribute that does not exist, instead of using
fdt_setprop_string() to create a "system-id" attribute with the uuid
provided via command line.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
Cedric,
This isn't critical and probably not worth postponing 7.0 for one
more week, but since we're pushing MIPS fixes for 6.2 I believe this
one can also go in.
hw/ppc/pnv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 32ab8071a4..9e532caa9f 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -552,7 +552,7 @@ static void *pnv_dt_create(MachineState *machine)
buf = qemu_uuid_unparse_strdup(&qemu_uuid);
_FDT((fdt_setprop_string(fdt, 0, "vm,uuid", buf)));
if (qemu_uuid_set) {
- _FDT((fdt_property_string(fdt, "system-id", buf)));
+ _FDT((fdt_setprop_string(fdt, 0, "system-id", buf)));
}
g_free(buf);
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set
2021-12-06 12:45 [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set Daniel Henrique Barboza
@ 2021-12-06 12:59 ` Luis Fernando Fujita Pires
2021-12-06 13:01 ` Daniel Henrique Barboza
2021-12-06 13:03 ` Cédric Le Goater
1 sibling, 1 reply; 4+ messages in thread
From: Luis Fernando Fujita Pires @ 2021-12-06 12:59 UTC (permalink / raw)
To: Daniel Henrique Barboza, qemu-devel; +Cc: qemu-ppc, clg, david
From: Daniel Henrique Barboza <danielhb413@gmail.com>
> Subject: [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set
I don't know enough to review this, but there's a typo on the commit message (pvn.c -> pnv.c). :)
--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set
2021-12-06 12:59 ` Luis Fernando Fujita Pires
@ 2021-12-06 13:01 ` Daniel Henrique Barboza
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Henrique Barboza @ 2021-12-06 13:01 UTC (permalink / raw)
To: Luis Fernando Fujita Pires, qemu-devel; +Cc: qemu-ppc, clg, david
On 12/6/21 09:59, Luis Fernando Fujita Pires wrote:
> From: Daniel Henrique Barboza <danielhb413@gmail.com>
>> Subject: [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set
>
> I don't know enough to review this, but there's a typo on the commit message (pvn.c -> pnv.c). :)
ooops :D
>
> --
> Luis Pires
> Instituto de Pesquisas ELDORADO
> Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set
2021-12-06 12:45 [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set Daniel Henrique Barboza
2021-12-06 12:59 ` Luis Fernando Fujita Pires
@ 2021-12-06 13:03 ` Cédric Le Goater
1 sibling, 0 replies; 4+ messages in thread
From: Cédric Le Goater @ 2021-12-06 13:03 UTC (permalink / raw)
To: Daniel Henrique Barboza, qemu-devel; +Cc: qemu-ppc, david
On 12/6/21 13:45, Daniel Henrique Barboza wrote:
> Setting -uuid in the pnv machine does not work:
>
> ./qemu-system-ppc64 -machine powernv8,accel=tcg -uuid 7ff61ca1-a4a0-4bc1-944c-abd114a35e80
> qemu-system-ppc64: error creating device tree: (fdt_property_string(fdt, "system-id", buf)): FDT_ERR_BADSTATE
>
> This happens because we're using "fdt_property_string" to retrieve a
> "system-id" attribute that does not exist, instead of using
> fdt_setprop_string() to create a "system-id" attribute with the uuid
> provided via command line.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
> ---
>
> Cedric,
>
> This isn't critical and probably not worth postponing 7.0 for one
> more week, but since we're pushing MIPS fixes for 6.2 I believe this
> one can also go in.
As you said, it is not critical :) and 6.2 is due for tomorrow !
Let's take it for 7.0.
Thanks,
C.
>
> hw/ppc/pnv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 32ab8071a4..9e532caa9f 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -552,7 +552,7 @@ static void *pnv_dt_create(MachineState *machine)
> buf = qemu_uuid_unparse_strdup(&qemu_uuid);
> _FDT((fdt_setprop_string(fdt, 0, "vm,uuid", buf)));
> if (qemu_uuid_set) {
> - _FDT((fdt_property_string(fdt, "system-id", buf)));
> + _FDT((fdt_setprop_string(fdt, 0, "system-id", buf)));
> }
> g_free(buf);
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-06 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 12:45 [PATCH] ppc/pvn.c: fix "system-id" FDT when -uuid is set Daniel Henrique Barboza
2021-12-06 12:59 ` Luis Fernando Fujita Pires
2021-12-06 13:01 ` Daniel Henrique Barboza
2021-12-06 13:03 ` Cédric Le Goater
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.