* [PATCH -next] usb: musb: mpfs: add missing clk_disable_unprepare() in mpfs_remove()
@ 2022-06-28 14:05 ` Yang Yingliang
0 siblings, 0 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-06-28 14:05 UTC (permalink / raw)
To: linux-kernel, linux-usb, linux-riscv
Cc: conor.dooley, valentina.fernandezalanis, gregkh
clock source is prepared and enabled by clk_prepare_enable()
in probe function, but no disable or unprepare in remove.
Fixes: 7a96b6ea90a4 ("usb: musb: Add support for PolarFire SoC's musb controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/usb/musb/mpfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
index a69ca338eace..cea2e8108867 100644
--- a/drivers/usb/musb/mpfs.c
+++ b/drivers/usb/musb/mpfs.c
@@ -239,6 +239,7 @@ static int mpfs_remove(struct platform_device *pdev)
{
struct mpfs_glue *glue = platform_get_drvdata(pdev);
+ clk_disable_unprepare(glue->clk);
platform_device_unregister(glue->musb);
usb_phy_generic_unregister(pdev);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] usb: musb: mpfs: add missing clk_disable_unprepare() in mpfs_remove()
@ 2022-06-28 14:05 ` Yang Yingliang
0 siblings, 0 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-06-28 14:05 UTC (permalink / raw)
To: linux-kernel, linux-usb, linux-riscv
Cc: conor.dooley, valentina.fernandezalanis, gregkh
clock source is prepared and enabled by clk_prepare_enable()
in probe function, but no disable or unprepare in remove.
Fixes: 7a96b6ea90a4 ("usb: musb: Add support for PolarFire SoC's musb controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/usb/musb/mpfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
index a69ca338eace..cea2e8108867 100644
--- a/drivers/usb/musb/mpfs.c
+++ b/drivers/usb/musb/mpfs.c
@@ -239,6 +239,7 @@ static int mpfs_remove(struct platform_device *pdev)
{
struct mpfs_glue *glue = platform_get_drvdata(pdev);
+ clk_disable_unprepare(glue->clk);
platform_device_unregister(glue->musb);
usb_phy_generic_unregister(pdev);
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] usb: musb: mpfs: add missing clk_disable_unprepare() in mpfs_remove()
2022-06-28 14:05 ` Yang Yingliang
@ 2022-06-28 16:57 ` Conor.Dooley
-1 siblings, 0 replies; 4+ messages in thread
From: Conor.Dooley @ 2022-06-28 16:57 UTC (permalink / raw)
To: yangyingliang, linux-kernel, linux-usb, linux-riscv
Cc: Conor.Dooley, Valentina.FernandezAlanis, gregkh
On 28/06/2022 15:05, Yang Yingliang wrote:
> clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove.
>
> Fixes: 7a96b6ea90a4 ("usb: musb: Add support for PolarFire SoC's musb controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/usb/musb/mpfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
> index a69ca338eace..cea2e8108867 100644
> --- a/drivers/usb/musb/mpfs.c
> +++ b/drivers/usb/musb/mpfs.c
> @@ -239,6 +239,7 @@ static int mpfs_remove(struct platform_device *pdev)
> {
> struct mpfs_glue *glue = platform_get_drvdata(pdev);
>
> + clk_disable_unprepare(glue->clk);
> platform_device_unregister(glue->musb);
> usb_phy_generic_unregister(pdev);
>
I'll file this one under "obviously correct".
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] usb: musb: mpfs: add missing clk_disable_unprepare() in mpfs_remove()
@ 2022-06-28 16:57 ` Conor.Dooley
0 siblings, 0 replies; 4+ messages in thread
From: Conor.Dooley @ 2022-06-28 16:57 UTC (permalink / raw)
To: yangyingliang, linux-kernel, linux-usb, linux-riscv
Cc: Conor.Dooley, Valentina.FernandezAlanis, gregkh
On 28/06/2022 15:05, Yang Yingliang wrote:
> clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove.
>
> Fixes: 7a96b6ea90a4 ("usb: musb: Add support for PolarFire SoC's musb controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/usb/musb/mpfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
> index a69ca338eace..cea2e8108867 100644
> --- a/drivers/usb/musb/mpfs.c
> +++ b/drivers/usb/musb/mpfs.c
> @@ -239,6 +239,7 @@ static int mpfs_remove(struct platform_device *pdev)
> {
> struct mpfs_glue *glue = platform_get_drvdata(pdev);
>
> + clk_disable_unprepare(glue->clk);
> platform_device_unregister(glue->musb);
> usb_phy_generic_unregister(pdev);
>
I'll file this one under "obviously correct".
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-28 16:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 14:05 [PATCH -next] usb: musb: mpfs: add missing clk_disable_unprepare() in mpfs_remove() Yang Yingliang
2022-06-28 14:05 ` Yang Yingliang
2022-06-28 16:57 ` Conor.Dooley
2022-06-28 16:57 ` Conor.Dooley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.