* [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
@ 2017-05-18 10:36 Juan Quintela
2017-05-18 11:49 ` Dr. David Alan Gilbert
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Juan Quintela @ 2017-05-18 10:36 UTC (permalink / raw)
To: qemu-devel; +Cc: dgilbert, lvivier, peterx, qemu-trivial
All the file is surounded already by #ifndef CONFIG_USER_ONLY.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
include/exec/memory.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 99e0f54..6b5b953 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -17,9 +17,7 @@
#ifndef CONFIG_USER_ONLY
#include "exec/cpu-common.h"
-#ifndef CONFIG_USER_ONLY
#include "exec/hwaddr.h"
-#endif
#include "exec/memattrs.h"
#include "exec/ramlist.h"
#include "qemu/queue.h"
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
2017-05-18 10:36 [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h Juan Quintela
@ 2017-05-18 11:49 ` Dr. David Alan Gilbert
2017-05-18 14:57 ` Laurent Vivier
2017-05-23 14:45 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2017-05-18 11:49 UTC (permalink / raw)
To: Juan Quintela; +Cc: qemu-devel, lvivier, peterx, qemu-trivial
* Juan Quintela (quintela@redhat.com) wrote:
> All the file is surounded already by #ifndef CONFIG_USER_ONLY.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Ah yes, the patch that added the inner ifndef added it to
every use of exec/hwaddr.h.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> include/exec/memory.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 99e0f54..6b5b953 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -17,9 +17,7 @@
> #ifndef CONFIG_USER_ONLY
>
> #include "exec/cpu-common.h"
> -#ifndef CONFIG_USER_ONLY
> #include "exec/hwaddr.h"
> -#endif
> #include "exec/memattrs.h"
> #include "exec/ramlist.h"
> #include "qemu/queue.h"
> --
> 2.9.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
2017-05-18 10:36 [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h Juan Quintela
2017-05-18 11:49 ` Dr. David Alan Gilbert
@ 2017-05-18 14:57 ` Laurent Vivier
2017-05-23 14:45 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2017-05-18 14:57 UTC (permalink / raw)
To: Juan Quintela, qemu-devel; +Cc: dgilbert, peterx, qemu-trivial
On 18/05/2017 12:36, Juan Quintela wrote:
> All the file is surounded already by #ifndef CONFIG_USER_ONLY.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> include/exec/memory.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 99e0f54..6b5b953 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -17,9 +17,7 @@
> #ifndef CONFIG_USER_ONLY
>
> #include "exec/cpu-common.h"
> -#ifndef CONFIG_USER_ONLY
> #include "exec/hwaddr.h"
> -#endif
> #include "exec/memattrs.h"
> #include "exec/ramlist.h"
> #include "qemu/queue.h"
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
2017-05-18 10:36 [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h Juan Quintela
2017-05-18 11:49 ` Dr. David Alan Gilbert
2017-05-18 14:57 ` Laurent Vivier
@ 2017-05-23 14:45 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2017-05-23 14:45 UTC (permalink / raw)
To: Juan Quintela, qemu-devel; +Cc: lvivier, qemu-trivial, dgilbert, peterx
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-23 14:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 10:36 [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h Juan Quintela
2017-05-18 11:49 ` Dr. David Alan Gilbert
2017-05-18 14:57 ` Laurent Vivier
2017-05-23 14:45 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.