* [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static
@ 2022-04-25 13:00 ` Tom Rix
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rix @ 2022-04-25 13:00 UTC (permalink / raw)
To: bskeggs, kherbst, lyude, airlied, daniel
Cc: dri-devel, nouveau, linux-kernel, Tom Rix
Sparse reports this issue
wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should it be static?
This variable is only used in wimmgv100.c. Single file variables should be static.
So use static as its storage-class specifier.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
index 89d783368b4f..bb4db6351ddf 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
@@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en)
nvkm_mask(device, 0x611da8, mask, data);
}
-const struct nv50_disp_chan_func
+static const struct nv50_disp_chan_func
gv100_disp_wimm = {
.init = gv100_disp_dmac_init,
.fini = gv100_disp_dmac_fini,
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Nouveau] [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static
@ 2022-04-25 13:00 ` Tom Rix
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rix @ 2022-04-25 13:00 UTC (permalink / raw)
To: bskeggs, kherbst, lyude, airlied, daniel
Cc: nouveau, linux-kernel, dri-devel, Tom Rix
Sparse reports this issue
wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should it be static?
This variable is only used in wimmgv100.c. Single file variables should be static.
So use static as its storage-class specifier.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
index 89d783368b4f..bb4db6351ddf 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
@@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en)
nvkm_mask(device, 0x611da8, mask, data);
}
-const struct nv50_disp_chan_func
+static const struct nv50_disp_chan_func
gv100_disp_wimm = {
.init = gv100_disp_dmac_init,
.fini = gv100_disp_dmac_fini,
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static
@ 2022-04-25 13:00 ` Tom Rix
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rix @ 2022-04-25 13:00 UTC (permalink / raw)
To: bskeggs, kherbst, lyude, airlied, daniel
Cc: nouveau, linux-kernel, dri-devel, Tom Rix
Sparse reports this issue
wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should it be static?
This variable is only used in wimmgv100.c. Single file variables should be static.
So use static as its storage-class specifier.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
index 89d783368b4f..bb4db6351ddf 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
@@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en)
nvkm_mask(device, 0x611da8, mask, data);
}
-const struct nv50_disp_chan_func
+static const struct nv50_disp_chan_func
gv100_disp_wimm = {
.init = gv100_disp_dmac_init,
.fini = gv100_disp_dmac_fini,
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Nouveau] [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static
2022-04-25 13:00 ` Tom Rix
(?)
@ 2022-04-26 17:46 ` Lyude Paul
-1 siblings, 0 replies; 6+ messages in thread
From: Lyude Paul @ 2022-04-26 17:46 UTC (permalink / raw)
To: Tom Rix, bskeggs, kherbst, airlied, daniel
Cc: nouveau, linux-kernel, dri-devel
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push upstream in a moment
On Mon, 2022-04-25 at 09:00 -0400, Tom Rix wrote:
> Sparse reports this issue
> wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should
> it be static?
>
> This variable is only used in wimmgv100.c. Single file variables should be
> static.
> So use static as its storage-class specifier.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> index 89d783368b4f..bb4db6351ddf 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> @@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en)
> nvkm_mask(device, 0x611da8, mask, data);
> }
>
> -const struct nv50_disp_chan_func
> +static const struct nv50_disp_chan_func
> gv100_disp_wimm = {
> .init = gv100_disp_dmac_init,
> .fini = gv100_disp_dmac_fini,
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static
@ 2022-04-26 17:46 ` Lyude Paul
0 siblings, 0 replies; 6+ messages in thread
From: Lyude Paul @ 2022-04-26 17:46 UTC (permalink / raw)
To: Tom Rix, bskeggs, kherbst, airlied, daniel
Cc: dri-devel, nouveau, linux-kernel
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push upstream in a moment
On Mon, 2022-04-25 at 09:00 -0400, Tom Rix wrote:
> Sparse reports this issue
> wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should
> it be static?
>
> This variable is only used in wimmgv100.c. Single file variables should be
> static.
> So use static as its storage-class specifier.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> index 89d783368b4f..bb4db6351ddf 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> @@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en)
> nvkm_mask(device, 0x611da8, mask, data);
> }
>
> -const struct nv50_disp_chan_func
> +static const struct nv50_disp_chan_func
> gv100_disp_wimm = {
> .init = gv100_disp_dmac_init,
> .fini = gv100_disp_dmac_fini,
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static
@ 2022-04-26 17:46 ` Lyude Paul
0 siblings, 0 replies; 6+ messages in thread
From: Lyude Paul @ 2022-04-26 17:46 UTC (permalink / raw)
To: Tom Rix, bskeggs, kherbst, airlied, daniel
Cc: nouveau, linux-kernel, dri-devel
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push upstream in a moment
On Mon, 2022-04-25 at 09:00 -0400, Tom Rix wrote:
> Sparse reports this issue
> wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should
> it be static?
>
> This variable is only used in wimmgv100.c. Single file variables should be
> static.
> So use static as its storage-class specifier.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> index 89d783368b4f..bb4db6351ddf 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
> @@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en)
> nvkm_mask(device, 0x611da8, mask, data);
> }
>
> -const struct nv50_disp_chan_func
> +static const struct nv50_disp_chan_func
> gv100_disp_wimm = {
> .init = gv100_disp_dmac_init,
> .fini = gv100_disp_dmac_fini,
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-08 3:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 13:00 [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wimm static Tom Rix
2022-04-25 13:00 ` [Nouveau] " Tom Rix
2022-04-25 13:00 ` Tom Rix
2022-04-26 17:46 ` [Nouveau] " Lyude Paul
2022-04-26 17:46 ` Lyude Paul
2022-04-26 17:46 ` Lyude Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.