* [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable
@ 2017-02-03 17:07 Paolo Bonzini
2017-02-05 18:30 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paolo Bonzini @ 2017-02-03 17:07 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
The function is not needed anymore now that migration is built on
top of QIOChannel.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/test-vmstate.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 9d87faf..0c2af4d 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -33,17 +33,6 @@
static char temp_file[] = "/tmp/vmst.test.XXXXXX";
static int temp_fd;
-/* Fake yield_until_fd_readable() implementation so we don't have to pull the
- * coroutine code as dependency.
- */
-void yield_until_fd_readable(int fd)
-{
- fd_set fds;
- FD_ZERO(&fds);
- FD_SET(fd, &fds);
- select(fd + 1, &fds, NULL, NULL, NULL);
-}
-
/* Duplicate temp_fd and seek to the beginning of the file */
static QEMUFile *open_test_file(bool write)
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] test-vmstate: remove yield_until_fd_readable
2017-02-03 17:07 [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable Paolo Bonzini
@ 2017-02-05 18:30 ` Laurent Vivier
2017-02-13 14:00 ` [Qemu-devel] " Stefan Hajnoczi
2017-02-15 10:16 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2017-02-05 18:30 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
Le 03/02/2017 à 18:07, Paolo Bonzini a écrit :
> The function is not needed anymore now that migration is built on
> top of QIOChannel.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/test-vmstate.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index 9d87faf..0c2af4d 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -33,17 +33,6 @@
> static char temp_file[] = "/tmp/vmst.test.XXXXXX";
> static int temp_fd;
>
> -/* Fake yield_until_fd_readable() implementation so we don't have to pull the
> - * coroutine code as dependency.
> - */
> -void yield_until_fd_readable(int fd)
> -{
> - fd_set fds;
> - FD_ZERO(&fds);
> - FD_SET(fd, &fds);
> - select(fd + 1, &fds, NULL, NULL, NULL);
> -}
> -
>
> /* Duplicate temp_fd and seek to the beginning of the file */
> static QEMUFile *open_test_file(bool write)
>
Tested-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable
2017-02-03 17:07 [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable Paolo Bonzini
2017-02-05 18:30 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2017-02-13 14:00 ` Stefan Hajnoczi
2017-02-15 10:16 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2017-02-13 14:00 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
On Fri, Feb 03, 2017 at 09:07:29AM -0800, Paolo Bonzini wrote:
> The function is not needed anymore now that migration is built on
> top of QIOChannel.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/test-vmstate.c | 11 -----------
> 1 file changed, 11 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable
2017-02-03 17:07 [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable Paolo Bonzini
2017-02-05 18:30 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-02-13 14:00 ` [Qemu-devel] " Stefan Hajnoczi
@ 2017-02-15 10:16 ` Michael Tokarev
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2017-02-15 10:16 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
03.02.2017 20:07, Paolo Bonzini wrote:
> The function is not needed anymore now that migration is built on
> top of QIOChannel.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-15 10:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-03 17:07 [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable Paolo Bonzini
2017-02-05 18:30 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-02-13 14:00 ` [Qemu-devel] " Stefan Hajnoczi
2017-02-15 10:16 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.