From: Dan Murphy <dmurphy@ti.com> To: Pavel Machek <pavel@ucw.cz> Cc: robh+dt@kernel.org, mark.rutland@arm.com, jacek.anaszewski@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Date: Thu, 10 May 2018 07:04:00 -0500 [thread overview] Message-ID: <1c4dc2a1-2d3e-d282-7d94-8301d0e9dd83@ti.com> (raw) In-Reply-To: <20180510112807.GF6977@amd> Pavel Thanks for the review On 05/10/2018 06:28 AM, Pavel Machek wrote: > On Tue 2018-05-08 09:17:03, Dan Murphy wrote: >> Introduce the device tree bindings for the lm3601x >> family of LED torch, flash and IR drivers. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> >> v2 - No changes - https://patchwork.kernel.org/patch/10384587/ >> >> .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> new file mode 100644 >> index 000000000000..38cdabf6ca7e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> @@ -0,0 +1,51 @@ >> +* Texas Instruments - lm3601x Single-LED Flash Driver >> + >> +The LM3601X are ultra-small LED flash drivers that >> +provides a high level of adjustability. > > "provide". Data sheet says provides. It reads fine either way but I will change it. > >> +Required properties: >> + - compatible : Can be one of the following >> + "ti,lm3601x" >> + "ti,lm36010" >> + "ti,lm36011" >> + - reg : I2C slave address >> + - #address-cells : 1 >> + - #size-cells : 0 >> + >> +Required child properties: >> + - reg : 0 - Indicates to support and register a torch interface >> + 1 - Indicates to support and register a strobe interface >> + 2 - Indicates to support and register an ir interface > > I'd delete "to support and register" -- we are describing hardware here. OK > >> +Optional child properties: >> + - label : see Documentation/devicetree/bindings/leds/common.txt >> + >> +Example: >> +led-controller@64 { >> + compatible = "ti,lm3601x"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0x64>; >> + >> + led@0 { >> + reg = <0>; >> + label = "white:torch"; >> + led-max-microamp=<10000>; >> + }; >> + >> + led@1 { >> + reg = <1>; >> + label = "white:strobe"; >> + flash-max-microamp=<10000>; >> + flash-max-timeout-us=<800>; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + label = "invisible:ir"; >> + }; >> +} > > Title says this is single-LED driver chip, but it controls three chips > in this example? 3 chips? It technically controls 3 LED methods and only 2 LEDs. The torch can be used as the strobe and the IR is controlled independently. > > I'd put " " around "=" for consistency. OK > > We use "flash" elsewhere, I'd replace "strobe" with that. Userspace > would like consistency, too. Labels are meant to be examples only not absolutes. I will change it to say flash but the label can be anything the customer wants it to be. > > What is the IR led good for? Taking videos in the dark? Yes. That is one application. And hunting ghosts ;) > > I guess for consistency, it is "ir:torch" :-). OK > > Pavel > -- ------------------ Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Pavel Machek <pavel@ucw.cz> Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <jacek.anaszewski@gmail.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org> Subject: Re: [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Date: Thu, 10 May 2018 07:04:00 -0500 [thread overview] Message-ID: <1c4dc2a1-2d3e-d282-7d94-8301d0e9dd83@ti.com> (raw) In-Reply-To: <20180510112807.GF6977@amd> Pavel Thanks for the review On 05/10/2018 06:28 AM, Pavel Machek wrote: > On Tue 2018-05-08 09:17:03, Dan Murphy wrote: >> Introduce the device tree bindings for the lm3601x >> family of LED torch, flash and IR drivers. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> >> v2 - No changes - https://patchwork.kernel.org/patch/10384587/ >> >> .../devicetree/bindings/leds/leds-lm3601x.txt | 51 +++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> new file mode 100644 >> index 000000000000..38cdabf6ca7e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt >> @@ -0,0 +1,51 @@ >> +* Texas Instruments - lm3601x Single-LED Flash Driver >> + >> +The LM3601X are ultra-small LED flash drivers that >> +provides a high level of adjustability. > > "provide". Data sheet says provides. It reads fine either way but I will change it. > >> +Required properties: >> + - compatible : Can be one of the following >> + "ti,lm3601x" >> + "ti,lm36010" >> + "ti,lm36011" >> + - reg : I2C slave address >> + - #address-cells : 1 >> + - #size-cells : 0 >> + >> +Required child properties: >> + - reg : 0 - Indicates to support and register a torch interface >> + 1 - Indicates to support and register a strobe interface >> + 2 - Indicates to support and register an ir interface > > I'd delete "to support and register" -- we are describing hardware here. OK > >> +Optional child properties: >> + - label : see Documentation/devicetree/bindings/leds/common.txt >> + >> +Example: >> +led-controller@64 { >> + compatible = "ti,lm3601x"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0x64>; >> + >> + led@0 { >> + reg = <0>; >> + label = "white:torch"; >> + led-max-microamp=<10000>; >> + }; >> + >> + led@1 { >> + reg = <1>; >> + label = "white:strobe"; >> + flash-max-microamp=<10000>; >> + flash-max-timeout-us=<800>; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + label = "invisible:ir"; >> + }; >> +} > > Title says this is single-LED driver chip, but it controls three chips > in this example? 3 chips? It technically controls 3 LED methods and only 2 LEDs. The torch can be used as the strobe and the IR is controlled independently. > > I'd put " " around "=" for consistency. OK > > We use "flash" elsewhere, I'd replace "strobe" with that. Userspace > would like consistency, too. Labels are meant to be examples only not absolutes. I will change it to say flash but the label can be anything the customer wants it to be. > > What is the IR led good for? Taking videos in the dark? Yes. That is one application. And hunting ghosts ;) > > I guess for consistency, it is "ir:torch" :-). OK > > Pavel > -- ------------------ Dan Murphy
next prev parent reply other threads:[~2018-05-10 12:04 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-08 14:17 [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Dan Murphy 2018-05-08 14:17 ` Dan Murphy 2018-05-08 14:17 ` [PATCH v2 2/2] leds: lm3601x: Introduce the lm3601x LED driver Dan Murphy 2018-05-08 14:17 ` Dan Murphy 2018-05-08 15:49 ` Andrew F. Davis 2018-05-08 15:49 ` Andrew F. Davis 2018-05-08 16:09 ` Dan Murphy 2018-05-08 16:09 ` Dan Murphy 2018-05-08 15:32 ` [PATCH v2 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Andrew F. Davis 2018-05-08 15:32 ` Andrew F. Davis 2018-05-08 16:10 ` Dan Murphy 2018-05-08 16:10 ` Dan Murphy 2018-05-10 11:28 ` Pavel Machek 2018-05-10 12:04 ` Dan Murphy [this message] 2018-05-10 12:04 ` Dan Murphy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1c4dc2a1-2d3e-d282-7d94-8301d0e9dd83@ti.com \ --to=dmurphy@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=jacek.anaszewski@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.