All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Mikko Perttunen <cyndis@kapsi.fi>,
	linux-tegra <linux-tegra@vger.kernel.org>,
	nouveau <nouveau@lists.freedesktop.org>,
	ray.huang@amd.com, matthew.auld@intel.com,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Nouveau] Trouble with TTM patches w/nouveau in linux-next
Date: Wed, 9 Jun 2021 16:58:16 +0200	[thread overview]
Message-ID: <1c9bdd1b-abea-872c-e23a-8a0e1e777a02@amd.com> (raw)
In-Reply-To: <CAKb7UvjrxXyvr9qpLbkoDQ2eScj4YdayP6OnG8rZnmEn1hyKvw@mail.gmail.com>

Good point, but I think that is unrelated.

My suspicion is rather that nouveau is not initializing the underlying 
GEM object for internal allocations.

So what happens is the same as on VMWGFX that TTM doesn't know anything 
about the size to of the BO resulting in a kmalloc() with a random value 
and eventually -ENOMEM.

Good news is that I can reproduce it, so going to look into that later 
today.

Regards,
Christian.

Am 09.06.21 um 16:52 schrieb Ilia Mirkin:
> Christian - potentially relevant is that Tegra doesn't have VRAM at
> all -- all GTT (or GART or whatever it's called nowadays). No
> fake/stolen VRAM.
>
> Cheers,
>
>    -ilia
>
> On Wed, Jun 9, 2021 at 10:18 AM Christian König
> <christian.koenig@amd.com> wrote:
>> Hi Mikko,
>>
>> strange sounds like Nouveau was somehow also using the GEM workaround
>> for VMWGFX as well.
>>
>> But -12 means -ENOMEM which doesn't fits into the picture.
>>
>> I will try with a G710, but if that doesn't yields anything I need some
>> more input from you.
>>
>> Thanks for the report,
>> Christian.
>>
>>
>> Am 09.06.21 um 15:47 schrieb Mikko Perttunen:
>>> Hi,
>>>
>>> I'm observing nouveau not initializing recently on linux-next on my
>>> Tegra186 Jetson TX2 board. Specifically it looks like BO allocation is
>>> failing when initializing the sync subsystem:
>>>
>>> [   21.858149] nouveau 17000000.gpu: DRM: failed to initialise sync
>>> subsystem, -28
>>>
>>> I have been bisecting and I have found two patches that affect this.
>>> Firstly, things first break on
>>>
>>> d02117f8efaa drm/ttm: remove special handling for non GEM drivers
>>>
>>> starting to return error code -12. Then, at
>>>
>>> d79025c7f5e3 drm/ttm: always initialize the full ttm_resource v2
>>>
>>> the error code changes to the above -28.
>>>
>>> If I checkout one commit prior to d79025c7f5e3 and revert
>>> d02117f8efaa, things work again. There are a bunch of other TTM
>>> commits between this and HEAD, so reverting these on top of HEAD
>>> doesn't work. However, I checked that both yesterday's and today's
>>> nexts are also broken.
>>>
>>> Thank you,
>>> Mikko
>>>
>> _______________________________________________
>> Nouveau mailing list
>> Nouveau@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fnouveau&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7Caaf09cbea0b04d8dc01208d92b5637ba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637588472445308290%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=ePoWVtHPXeK5RThkRuQSykKrfWCgPOzG5CLTzfw9%2Fuw%3D&amp;reserved=0


WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: nouveau <nouveau@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	ray.huang@amd.com, matthew.auld@intel.com,
	linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [Nouveau] Trouble with TTM patches w/nouveau in linux-next
Date: Wed, 9 Jun 2021 16:58:16 +0200	[thread overview]
Message-ID: <1c9bdd1b-abea-872c-e23a-8a0e1e777a02@amd.com> (raw)
In-Reply-To: <CAKb7UvjrxXyvr9qpLbkoDQ2eScj4YdayP6OnG8rZnmEn1hyKvw@mail.gmail.com>

Good point, but I think that is unrelated.

My suspicion is rather that nouveau is not initializing the underlying 
GEM object for internal allocations.

So what happens is the same as on VMWGFX that TTM doesn't know anything 
about the size to of the BO resulting in a kmalloc() with a random value 
and eventually -ENOMEM.

Good news is that I can reproduce it, so going to look into that later 
today.

Regards,
Christian.

Am 09.06.21 um 16:52 schrieb Ilia Mirkin:
> Christian - potentially relevant is that Tegra doesn't have VRAM at
> all -- all GTT (or GART or whatever it's called nowadays). No
> fake/stolen VRAM.
>
> Cheers,
>
>    -ilia
>
> On Wed, Jun 9, 2021 at 10:18 AM Christian König
> <christian.koenig@amd.com> wrote:
>> Hi Mikko,
>>
>> strange sounds like Nouveau was somehow also using the GEM workaround
>> for VMWGFX as well.
>>
>> But -12 means -ENOMEM which doesn't fits into the picture.
>>
>> I will try with a G710, but if that doesn't yields anything I need some
>> more input from you.
>>
>> Thanks for the report,
>> Christian.
>>
>>
>> Am 09.06.21 um 15:47 schrieb Mikko Perttunen:
>>> Hi,
>>>
>>> I'm observing nouveau not initializing recently on linux-next on my
>>> Tegra186 Jetson TX2 board. Specifically it looks like BO allocation is
>>> failing when initializing the sync subsystem:
>>>
>>> [   21.858149] nouveau 17000000.gpu: DRM: failed to initialise sync
>>> subsystem, -28
>>>
>>> I have been bisecting and I have found two patches that affect this.
>>> Firstly, things first break on
>>>
>>> d02117f8efaa drm/ttm: remove special handling for non GEM drivers
>>>
>>> starting to return error code -12. Then, at
>>>
>>> d79025c7f5e3 drm/ttm: always initialize the full ttm_resource v2
>>>
>>> the error code changes to the above -28.
>>>
>>> If I checkout one commit prior to d79025c7f5e3 and revert
>>> d02117f8efaa, things work again. There are a bunch of other TTM
>>> commits between this and HEAD, so reverting these on top of HEAD
>>> doesn't work. However, I checked that both yesterday's and today's
>>> nexts are also broken.
>>>
>>> Thank you,
>>> Mikko
>>>
>> _______________________________________________
>> Nouveau mailing list
>> Nouveau@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fnouveau&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7Caaf09cbea0b04d8dc01208d92b5637ba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637588472445308290%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=ePoWVtHPXeK5RThkRuQSykKrfWCgPOzG5CLTzfw9%2Fuw%3D&amp;reserved=0

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Mikko Perttunen <cyndis@kapsi.fi>,
	nouveau <nouveau@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	ray.huang@amd.com, matthew.auld@intel.com,
	linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [Nouveau] Trouble with TTM patches w/nouveau in linux-next
Date: Wed, 9 Jun 2021 16:58:16 +0200	[thread overview]
Message-ID: <1c9bdd1b-abea-872c-e23a-8a0e1e777a02@amd.com> (raw)
In-Reply-To: <CAKb7UvjrxXyvr9qpLbkoDQ2eScj4YdayP6OnG8rZnmEn1hyKvw@mail.gmail.com>

Good point, but I think that is unrelated.

My suspicion is rather that nouveau is not initializing the underlying 
GEM object for internal allocations.

So what happens is the same as on VMWGFX that TTM doesn't know anything 
about the size to of the BO resulting in a kmalloc() with a random value 
and eventually -ENOMEM.

Good news is that I can reproduce it, so going to look into that later 
today.

Regards,
Christian.

Am 09.06.21 um 16:52 schrieb Ilia Mirkin:
> Christian - potentially relevant is that Tegra doesn't have VRAM at
> all -- all GTT (or GART or whatever it's called nowadays). No
> fake/stolen VRAM.
>
> Cheers,
>
>    -ilia
>
> On Wed, Jun 9, 2021 at 10:18 AM Christian König
> <christian.koenig@amd.com> wrote:
>> Hi Mikko,
>>
>> strange sounds like Nouveau was somehow also using the GEM workaround
>> for VMWGFX as well.
>>
>> But -12 means -ENOMEM which doesn't fits into the picture.
>>
>> I will try with a G710, but if that doesn't yields anything I need some
>> more input from you.
>>
>> Thanks for the report,
>> Christian.
>>
>>
>> Am 09.06.21 um 15:47 schrieb Mikko Perttunen:
>>> Hi,
>>>
>>> I'm observing nouveau not initializing recently on linux-next on my
>>> Tegra186 Jetson TX2 board. Specifically it looks like BO allocation is
>>> failing when initializing the sync subsystem:
>>>
>>> [   21.858149] nouveau 17000000.gpu: DRM: failed to initialise sync
>>> subsystem, -28
>>>
>>> I have been bisecting and I have found two patches that affect this.
>>> Firstly, things first break on
>>>
>>> d02117f8efaa drm/ttm: remove special handling for non GEM drivers
>>>
>>> starting to return error code -12. Then, at
>>>
>>> d79025c7f5e3 drm/ttm: always initialize the full ttm_resource v2
>>>
>>> the error code changes to the above -28.
>>>
>>> If I checkout one commit prior to d79025c7f5e3 and revert
>>> d02117f8efaa, things work again. There are a bunch of other TTM
>>> commits between this and HEAD, so reverting these on top of HEAD
>>> doesn't work. However, I checked that both yesterday's and today's
>>> nexts are also broken.
>>>
>>> Thank you,
>>> Mikko
>>>
>> _______________________________________________
>> Nouveau mailing list
>> Nouveau@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fnouveau&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7Caaf09cbea0b04d8dc01208d92b5637ba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637588472445308290%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=ePoWVtHPXeK5RThkRuQSykKrfWCgPOzG5CLTzfw9%2Fuw%3D&amp;reserved=0


  reply	other threads:[~2021-06-09 14:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 13:47 Trouble with TTM patches w/nouveau in linux-next Mikko Perttunen
2021-06-09 13:47 ` Mikko Perttunen
2021-06-09 13:47 ` [Nouveau] " Mikko Perttunen
2021-06-09 14:17 ` Christian König
2021-06-09 14:17   ` Christian König
2021-06-09 14:17   ` [Nouveau] " Christian König
2021-06-09 14:52   ` Ilia Mirkin
2021-06-09 14:52     ` Ilia Mirkin
2021-06-09 14:52     ` Ilia Mirkin
2021-06-09 14:58     ` Christian König [this message]
2021-06-09 14:58       ` Christian König
2021-06-09 14:58       ` Christian König
2021-06-09 15:13       ` Ilia Mirkin
2021-06-09 15:13         ` Ilia Mirkin
2021-06-09 15:13         ` Ilia Mirkin
2021-06-09 15:21         ` Christian König
2021-06-09 15:21           ` Christian König
2021-06-09 15:21           ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c9bdd1b-abea-872c-e23a-8a0e1e777a02@amd.com \
    --to=christian.koenig@amd.com \
    --cc=cyndis@kapsi.fi \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imirkin@alum.mit.edu \
    --cc=linux-tegra@vger.kernel.org \
    --cc=matthew.auld@intel.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.