All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hid: add info to Kconfig
@ 2022-11-20  3:34 Albert Zhou
  2022-11-20 18:48 ` Jeff LaBundy
  0 siblings, 1 reply; 3+ messages in thread
From: Albert Zhou @ 2022-11-20  3:34 UTC (permalink / raw)
  To: jikos, benjamin.tissoires; +Cc: linux-input

Nowadays many laptops use multitouch for their touchpads. This is now
indicated in the help message for HID_MULTITOUCH in the Kconfig.

Signed-off-by: Albert Zhou <albert.zhou.50@gmail.com>
---
 drivers/hid/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 185a077d59cd..86f65258a912 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -697,7 +697,8 @@ config HID_MONTEREY
 config HID_MULTITOUCH
 	tristate "HID Multitouch panels"
 	help
-	  Generic support for HID multitouch panels.
+	  Generic support for HID multitouch panels. Many newer laptops (like
+	  the Dell XPS 13 9360) use multitouch for their touchpads.
 
 	  Say Y here if you have one of the following devices:
 	  - 3M PCT touch screens

base-commit: fe24a97cf2543e8832e7a2124802e5c32aac05aa
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] hid: add info to Kconfig
  2022-11-20  3:34 [PATCH] hid: add info to Kconfig Albert Zhou
@ 2022-11-20 18:48 ` Jeff LaBundy
  2022-11-21  5:42   ` Albert Zhou
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff LaBundy @ 2022-11-20 18:48 UTC (permalink / raw)
  To: Albert Zhou; +Cc: jikos, benjamin.tissoires, linux-input

Hi Albert,

On Sun, Nov 20, 2022 at 02:34:56PM +1100, Albert Zhou wrote:
> Nowadays many laptops use multitouch for their touchpads. This is now
> indicated in the help message for HID_MULTITOUCH in the Kconfig.
> 
> Signed-off-by: Albert Zhou <albert.zhou.50@gmail.com>
> ---
>  drivers/hid/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 185a077d59cd..86f65258a912 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -697,7 +697,8 @@ config HID_MONTEREY
>  config HID_MULTITOUCH
>  	tristate "HID Multitouch panels"
>  	help
> -	  Generic support for HID multitouch panels.
> +	  Generic support for HID multitouch panels. Many newer laptops (like
> +	  the Dell XPS 13 9360) use multitouch for their touchpads.

This is just my opinion, but the intent is to describe what
the feature does, not make claims about what products might
happen to use it as of today.

Furthermore, "newer" is relative. This statement won't have
the same meaning years from now. I think the description is
fine as-is.

>  
>  	  Say Y here if you have one of the following devices:
>  	  - 3M PCT touch screens
> 
> base-commit: fe24a97cf2543e8832e7a2124802e5c32aac05aa
> -- 
> 2.34.1
> 

Kind regards,
Jeff LaBundy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hid: add info to Kconfig
  2022-11-20 18:48 ` Jeff LaBundy
@ 2022-11-21  5:42   ` Albert Zhou
  0 siblings, 0 replies; 3+ messages in thread
From: Albert Zhou @ 2022-11-21  5:42 UTC (permalink / raw)
  To: Jeff LaBundy; +Cc: jikos, benjamin.tissoires, linux-input


[-- Attachment #1.1.1: Type: text/plain, Size: 743 bytes --]

On 21/11/22 05:48, Jeff LaBundy wrote:
> This is just my opinion, but the intent is to describe what
> the feature does, not make claims about what products might
> happen to use it as of today.
> 
> Furthermore, "newer" is relative. This statement won't have
> the same meaning years from now. I think the description is
> fine as-is.

Hi Jeff,

Currently the long list of supported products consists almost
exclusively of touchscreen devices, giving the false impression it's not
relevant for laptop touchpads.

Actually I turned this off because I thought I wouldn't need it, but
later I discovered it's used for my touchpad, which is why I thought it
might be useful to add this to the help message.

 From Albert Zhou

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 653 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-21  5:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-20  3:34 [PATCH] hid: add info to Kconfig Albert Zhou
2022-11-20 18:48 ` Jeff LaBundy
2022-11-21  5:42   ` Albert Zhou

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.