All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround
Date: Sun, 1 Dec 2019 21:50:14 +0800	[thread overview]
Message-ID: <1cd7cd78-925e-af0c-be52-6acad68eb50e@rock-chips.com> (raw)
In-Reply-To: <20191128061433.1952869-2-anarsoul@gmail.com>


On 2019/11/28 下午2:14, Vasily Khoruzhick wrote:
> Rockpro64 doesn't boot reliably after soft reset, so let's force power on
> reset by asserting sysreset pin if we detected soft reset.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 8 ++++++++
>   configs/rockpro64-rk3399_defconfig        | 1 +
>   2 files changed, 9 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> index 4648513ea9..bb94bcf7be 100644
> --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -6,11 +6,19 @@
>   #include "rk3399-u-boot.dtsi"
>   #include "rk3399-sdram-lpddr4-100.dtsi"
>   / {
> +	config {
> +		sysreset-gpio = <&gpio1 RK_PA6 GPIO_ACTIVE_HIGH>;
> +	};
> +
>   	chosen {
>   		u-boot,spl-boot-order = "same-as-spl", &sdmmc, &sdhci;
>   	};
>   };
>   
> +&gpio1  {
> +	u-boot,dm-pre-reloc;
> +};
> +
>   &vdd_center {
>   	regulator-min-microvolt = <950000>;
>   	regulator-max-microvolt = <950000>;
> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> index 49e27c91cb..d153ac5485 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -1,6 +1,7 @@
>   CONFIG_ARM=y
>   CONFIG_ARCH_ROCKCHIP=y
>   CONFIG_SYS_TEXT_BASE=0x00200000
> +CONFIG_SPL_GPIO_SUPPORT=y
>   CONFIG_ROCKCHIP_RK3399=y
>   CONFIG_ENV_OFFSET=0x3F8000
>   CONFIG_TARGET_ROCKPRO64_RK3399=y

  parent reply	other threads:[~2019-12-01 13:50 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28  6:14 [U-Boot] [PATCH 1/2] rockchip: rk3399: fix force power on reset Vasily Khoruzhick
2019-11-28  6:14 ` [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround Vasily Khoruzhick
2019-11-28  9:22   ` Kever Yang
2019-11-28 15:51     ` Vasily Khoruzhick
2019-11-29  0:58       ` Kever Yang
2019-11-29  1:06         ` Vasily Khoruzhick
2019-12-01 14:12           ` Hugh Cole-Baker
2019-12-02  3:03             ` Kever Yang
2022-05-18 11:55             ` Lee Jones
2022-05-18 11:55               ` Lee Jones
2022-05-18 11:55               ` Lee Jones
2022-05-18 22:56               ` Peter Geis
2022-05-18 22:56                 ` Peter Geis
2022-05-18 22:56                 ` Peter Geis
2022-05-19  8:17                 ` Lee Jones
2022-05-19  8:17                   ` Lee Jones
2022-05-19  8:17                   ` Lee Jones
2022-05-19 11:16                   ` Peter Geis
2022-05-19 11:16                     ` Peter Geis
2022-05-19 11:16                     ` Peter Geis
2022-05-19 14:56                     ` Lee Jones
2022-05-19 14:56                       ` Lee Jones
2022-05-19 14:56                       ` Lee Jones
2022-05-19 15:31                       ` Peter Geis
2022-05-19 15:31                         ` Peter Geis
2022-05-19 15:31                         ` Peter Geis
2022-05-19 15:42                         ` Lee Jones
2022-05-19 15:42                           ` Lee Jones
2022-05-19 15:42                           ` Lee Jones
2022-05-19 15:47                           ` Lee Jones
2022-05-19 15:47                             ` Lee Jones
2022-05-19 15:47                             ` Lee Jones
2022-05-19 16:35                             ` Peter Geis
2022-05-19 16:35                               ` Peter Geis
2022-05-19 16:35                               ` Peter Geis
2022-05-19 17:03                               ` Lee Jones
2022-05-19 17:03                                 ` Lee Jones
2022-05-19 17:03                                 ` Lee Jones
2022-05-19 17:23                                 ` Lee Jones
2022-05-19 17:23                                   ` Lee Jones
2022-05-19 17:23                                   ` Lee Jones
2022-05-19 17:36                                   ` Peter Geis
2022-05-19 17:36                                     ` Peter Geis
2022-05-19 17:36                                     ` Peter Geis
2022-05-19 17:41                                     ` Peter Geis
2022-05-19 17:41                                       ` Peter Geis
2022-05-19 17:41                                       ` Peter Geis
2022-05-19 18:01                                       ` Lee Jones
2022-05-19 18:01                                         ` Lee Jones
2022-05-19 18:01                                         ` Lee Jones
2019-12-01 13:50   ` Kever Yang [this message]
2019-11-28  9:39 ` [U-Boot] [PATCH 1/2] rockchip: rk3399: fix force power on reset Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cd7cd78-925e-af0c-be52-6acad68eb50e@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.