All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] rockchip: rk3399: fix force power on reset
Date: Thu, 28 Nov 2019 17:39:25 +0800	[thread overview]
Message-ID: <a36dc08b-e64f-c563-1548-2052f9d95a67@rock-chips.com> (raw)
In-Reply-To: <20191128061433.1952869-1-anarsoul@gmail.com>


On 2019/11/28 下午2:14, Vasily Khoruzhick wrote:
> Currently code doesn't even compile since it uses wrong
> define for ifdef. Fix that and also add missing include
>
> Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init")
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/mach-rockchip/rk3399/rk3399.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c
> index 863024d071..eeb99dd11b 100644
> --- a/arch/arm/mach-rockchip/rk3399/rk3399.c
> +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c
> @@ -11,6 +11,7 @@
>   #include <asm/io.h>
>   #include <asm/arch-rockchip/bootrom.h>
>   #include <asm/arch-rockchip/clock.h>
> +#include <asm/arch-rockchip/cru_rk3399.h>
>   #include <asm/arch-rockchip/gpio.h>
>   #include <asm/arch-rockchip/grf_rk3399.h>
>   #include <asm/arch-rockchip/hardware.h>
> @@ -213,7 +214,7 @@ void spl_perform_fixups(struct spl_image_info *spl_image)
>   			   "u-boot,spl-boot-device", boot_ofpath);
>   }
>   
> -#if defined(SPL_GPIO_SUPPORT)
> +#if defined(CONFIG_SPL_GPIO_SUPPORT)
>   static void rk3399_force_power_on_reset(void)
>   {
>   	ofnode node;
> @@ -239,7 +240,7 @@ static void rk3399_force_power_on_reset(void)
>   
>   void spl_board_init(void)
>   {
> -#if defined(SPL_GPIO_SUPPORT)
> +#if defined(CONFIG_SPL_GPIO_SUPPORT)
>   	struct rk3399_cru *cru = rockchip_get_cru();
>   
>   	/*

      parent reply	other threads:[~2019-11-28  9:39 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28  6:14 [U-Boot] [PATCH 1/2] rockchip: rk3399: fix force power on reset Vasily Khoruzhick
2019-11-28  6:14 ` [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround Vasily Khoruzhick
2019-11-28  9:22   ` Kever Yang
2019-11-28 15:51     ` Vasily Khoruzhick
2019-11-29  0:58       ` Kever Yang
2019-11-29  1:06         ` Vasily Khoruzhick
2019-12-01 14:12           ` Hugh Cole-Baker
2019-12-02  3:03             ` Kever Yang
2022-05-18 11:55             ` Lee Jones
2022-05-18 11:55               ` Lee Jones
2022-05-18 11:55               ` Lee Jones
2022-05-18 22:56               ` Peter Geis
2022-05-18 22:56                 ` Peter Geis
2022-05-18 22:56                 ` Peter Geis
2022-05-19  8:17                 ` Lee Jones
2022-05-19  8:17                   ` Lee Jones
2022-05-19  8:17                   ` Lee Jones
2022-05-19 11:16                   ` Peter Geis
2022-05-19 11:16                     ` Peter Geis
2022-05-19 11:16                     ` Peter Geis
2022-05-19 14:56                     ` Lee Jones
2022-05-19 14:56                       ` Lee Jones
2022-05-19 14:56                       ` Lee Jones
2022-05-19 15:31                       ` Peter Geis
2022-05-19 15:31                         ` Peter Geis
2022-05-19 15:31                         ` Peter Geis
2022-05-19 15:42                         ` Lee Jones
2022-05-19 15:42                           ` Lee Jones
2022-05-19 15:42                           ` Lee Jones
2022-05-19 15:47                           ` Lee Jones
2022-05-19 15:47                             ` Lee Jones
2022-05-19 15:47                             ` Lee Jones
2022-05-19 16:35                             ` Peter Geis
2022-05-19 16:35                               ` Peter Geis
2022-05-19 16:35                               ` Peter Geis
2022-05-19 17:03                               ` Lee Jones
2022-05-19 17:03                                 ` Lee Jones
2022-05-19 17:03                                 ` Lee Jones
2022-05-19 17:23                                 ` Lee Jones
2022-05-19 17:23                                   ` Lee Jones
2022-05-19 17:23                                   ` Lee Jones
2022-05-19 17:36                                   ` Peter Geis
2022-05-19 17:36                                     ` Peter Geis
2022-05-19 17:36                                     ` Peter Geis
2022-05-19 17:41                                     ` Peter Geis
2022-05-19 17:41                                       ` Peter Geis
2022-05-19 17:41                                       ` Peter Geis
2022-05-19 18:01                                       ` Lee Jones
2022-05-19 18:01                                         ` Lee Jones
2022-05-19 18:01                                         ` Lee Jones
2019-12-01 13:50   ` Kever Yang
2019-11-28  9:39 ` Kever Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a36dc08b-e64f-c563-1548-2052f9d95a67@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.