All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Jakub Kicinski <kuba@kernel.org>, Raju Rangoju <Raju.Rangoju@amd.com>
Cc: Shyam-sundar.S-k@amd.com, davem@davemloft.net,
	netdev@vger.kernel.org, Rajesh1.Kumar@amd.com
Subject: Re: [PATCH v3 net 1/5] amd-xgbe: Yellow carp devices do not need rrc
Date: Fri, 21 Oct 2022 08:40:16 -0500	[thread overview]
Message-ID: <1cdda523-fcab-be4d-42d3-8ea7dd4a2e2a@amd.com> (raw)
In-Reply-To: <20221020214615.767a8c35@kernel.org>

On 10/20/22 23:46, Jakub Kicinski wrote:
> On Thu, 20 Oct 2022 12:12:11 +0530 Raju Rangoju wrote:
>> Link stability issues are noticed on Yellow carp platforms when Receiver
>> Reset Cycle is issued. Since the CDR workaround is disabled on these
>> platforms, the Receiver Reset Cycle is not needed.
>>
>> So, avoid issuing rrc on Yellow carp platforms.
> 
> Let me retry [1] the same question:
> 
> These devices are only present on SoCs? Changing global data during
> probe looks odd.

I can answer for Raju, yes, these are only on SoCs.

But it would still probably be worth a series that allocates memory to 
copy the vdata and use that, free to modify without impacting any other 
device that is probed.

Thanks,
Tom

> 
> [1] https://lore.kernel.org/all/20221006172654.45372b3b@kernel.org/

  reply	other threads:[~2022-10-21 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  6:42 [PATCH v3 net 0/5] amd-xgbe: Miscellaneous fixes Raju Rangoju
2022-10-20  6:42 ` [PATCH v3 net 1/5] amd-xgbe: Yellow carp devices do not need rrc Raju Rangoju
2022-10-21  4:46   ` Jakub Kicinski
2022-10-21 13:40     ` Tom Lendacky [this message]
2022-10-20  6:42 ` [PATCH v3 net 2/5] amd-xgbe: use enums for mailbox cmd and sub_cmds Raju Rangoju
2022-10-20  6:42 ` [PATCH v3 net 3/5] amd-xgbe: enable PLL_CTL for fixed PHY modes only Raju Rangoju
2022-10-20  6:42 ` [PATCH v3 net 4/5] amd-xgbe: fix the SFP compliance codes check for DAC cables Raju Rangoju
2022-10-20  6:42 ` [PATCH v3 net 5/5] amd-xgbe: add the bit rate quirk for Molex cables Raju Rangoju
2022-10-20 17:33 ` [PATCH v3 net 0/5] amd-xgbe: Miscellaneous fixes Tom Lendacky
2022-10-22  5:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cdda523-fcab-be4d-42d3-8ea7dd4a2e2a@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=Rajesh1.Kumar@amd.com \
    --cc=Raju.Rangoju@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.