All of lore.kernel.org
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Ahmet Inan <inan@distec.de>,
	Martin Fuzzey <martin.fuzzey@flowbird.group>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCHv3 2/5] Input: EXC3000: switch to i2c's probe_new API
Date: Wed, 20 May 2020 18:50:09 +0200	[thread overview]
Message-ID: <1d0d7e26-379f-5918-451f-b4445a652272@collabora.com> (raw)
In-Reply-To: <20200520153936.46869-3-sebastian.reichel@collabora.com>

Hi Sebastian,

On 20/5/20 17:39, Sebastian Reichel wrote:
> Switch to the "new" I2C probe API.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---
>  drivers/input/touchscreen/exc3000.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c
> index e007e2e8f626..555a14305cd4 100644
> --- a/drivers/input/touchscreen/exc3000.c
> +++ b/drivers/input/touchscreen/exc3000.c
> @@ -145,8 +145,7 @@ static irqreturn_t exc3000_interrupt(int irq, void *dev_id)
>  	return IRQ_HANDLED;
>  }
>  
> -static int exc3000_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int exc3000_probe(struct i2c_client *client)
>  {
>  	struct exc3000_data *data;
>  	struct input_dev *input;
> @@ -210,7 +209,7 @@ static struct i2c_driver exc3000_driver = {
>  		.of_match_table = of_match_ptr(exc3000_of_match),
>  	},
>  	.id_table	= exc3000_id,
> -	.probe		= exc3000_probe,
> +	.probe_new	= exc3000_probe,
>  };
>  
>  module_i2c_driver(exc3000_driver);
> 

  reply	other threads:[~2020-05-20 16:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 15:39 [PATCHv3 0/5] EXC3000 Updates Sebastian Reichel
2020-05-20 15:39 ` [PATCHv3 1/5] dt-bindings: touchscreen: Convert EETI EXC3000 touchscreen to json-schema Sebastian Reichel
2020-06-12 16:05   ` Sebastian Reichel
2020-05-20 15:39 ` [PATCHv3 2/5] Input: EXC3000: switch to i2c's probe_new API Sebastian Reichel
2020-05-20 16:50   ` Enric Balletbo i Serra [this message]
2020-05-20 17:31   ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 3/5] Input: EXC3000: add EXC80H60 and EXC80H84 support Sebastian Reichel
2020-05-20 17:45   ` Dmitry Torokhov
2020-05-20 21:20     ` Sebastian Reichel
2020-05-21  6:12       ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 4/5] Input: EXC3000: Add support to query model and fw_version Sebastian Reichel
2020-05-20 16:53   ` Enric Balletbo i Serra
2020-05-20 17:49   ` Dmitry Torokhov
2020-05-20 21:25     ` Sebastian Reichel
2020-05-21  5:54       ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 5/5] Input: EXC3000: Add reset gpio support Sebastian Reichel
2020-05-20 16:54   ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d0d7e26-379f-5918-451f-b4445a652272@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=inan@distec.de \
    --cc=kernel@collabora.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.fuzzey@flowbird.group \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.