From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Ahmet Inan <inan@distec.de>,
Martin Fuzzey <martin.fuzzey@flowbird.group>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: [PATCHv3 0/5] EXC3000 Updates
Date: Wed, 20 May 2020 17:39:31 +0200 [thread overview]
Message-ID: <20200520153936.46869-1-sebastian.reichel@collabora.com> (raw)
Hi,
This is PATCHv3 of the EXC80Hxx support patchset.
Changes since [PATCHv2]:
- add #include <linux/size.h> for SZ_4K and SZ_16K (kbuild test bot)
- fw_version_show must be ssize_t (kbuild test bot)
- rename YAML binding file to include eeti, prefix (Enric)
- noise from gpio-reset patch (Enric)
- add comment for the retry loop (Enric, Martin)
- document sysfs entries (Enric)
Changes since [PATCHv1]:
- prepend new patch converting binding document to YAML
- prepend new patch switching to I2C probe_new
- append new patch adding reset-gpio support
- use explicit compatible values for the touchscreen chips instead of
a wildcast. Since the documentation, that I have is very vague let's
use different values for exc80h60 and exc80h84. This avoids wildcard
DT entries and means we are prepared when noticing differences
between the chips.
- add accidently removed terminator entry in exc3000_id
- use device structure with max_xy and name (suggested by Martin)
- use SZ_4K, SZ_16K defines (suggested by Dmitry)
- harden event check, so that MT1 and MT2 based chips only allow
their own event type.
- write more detailed commit description in the fw_version/model
sysfs patch to explain why the values are not cached and why
the simpler read(); sleep(); write() approach has not been used
- use DEVICE_ATTR_RO() in fw_version/model patch to improve readability
- fw_version/model: replace memcpy + null termination with strlcpy
- fw_version/model: increase buffer size for weird firmware versions
- fw_version/model: use sizeof() instead of hardcoded buffer sizes
- simplify exc3000_query_interrupt() by moving the complete() call to
the exc3000_interrupt().
I think I only ignored one review feedback, that the fw_version and
model sysfs nodes are attached to the input device instead of the
i2c device. This was done to avoid being racy:
http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/
Thanks in advance for looking at the patches,
-- Sebastian
[PATCHv2] https://lore.kernel.org/linux-input/20200519182447.73405-1-sebastian.reichel@collabora.com/
[PATCHv1] https://lore.kernel.org/linux-input/20191107181010.17211-1-sebastian.reichel@collabora.com/
Sebastian Reichel (5):
dt-bindings: touchscreen: Convert EETI EXC3000 touchscreen to
json-schema
Input: EXC3000: switch to i2c's probe_new API
Input: EXC3000: add EXC80H60 and EXC80H84 support
Input: EXC3000: Add support to query model and fw_version
Input: EXC3000: Add reset gpio support
.../ABI/testing/sysfs-driver-input-exc3000 | 15 ++
.../input/touchscreen/eeti,exc3000.yaml | 58 +++++
.../bindings/input/touchscreen/exc3000.txt | 26 --
drivers/input/touchscreen/exc3000.c | 245 ++++++++++++++++--
4 files changed, 301 insertions(+), 43 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-driver-input-exc3000
create mode 100644 Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/exc3000.txt
--
2.26.2
next reply other threads:[~2020-05-20 15:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 15:39 Sebastian Reichel [this message]
2020-05-20 15:39 ` [PATCHv3 1/5] dt-bindings: touchscreen: Convert EETI EXC3000 touchscreen to json-schema Sebastian Reichel
2020-06-12 16:05 ` Sebastian Reichel
2020-05-20 15:39 ` [PATCHv3 2/5] Input: EXC3000: switch to i2c's probe_new API Sebastian Reichel
2020-05-20 16:50 ` Enric Balletbo i Serra
2020-05-20 17:31 ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 3/5] Input: EXC3000: add EXC80H60 and EXC80H84 support Sebastian Reichel
2020-05-20 17:45 ` Dmitry Torokhov
2020-05-20 21:20 ` Sebastian Reichel
2020-05-21 6:12 ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 4/5] Input: EXC3000: Add support to query model and fw_version Sebastian Reichel
2020-05-20 16:53 ` Enric Balletbo i Serra
2020-05-20 17:49 ` Dmitry Torokhov
2020-05-20 21:25 ` Sebastian Reichel
2020-05-21 5:54 ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 5/5] Input: EXC3000: Add reset gpio support Sebastian Reichel
2020-05-20 16:54 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520153936.46869-1-sebastian.reichel@collabora.com \
--to=sebastian.reichel@collabora.com \
--cc=dmitry.torokhov@gmail.com \
--cc=inan@distec.de \
--cc=kernel@collabora.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.fuzzey@flowbird.group \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.