* Re: [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles_chunk()
@ 2020-04-19 8:15 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-04-19 8:15 UTC (permalink / raw)
To: Bernard Zhao, amd-gfx, dri-devel, Alex Deucher,
Christian König, Chunming Zhou, Felix Kühling,
Nicolai Hähnle, Nirmoy Das, Philip Yang
Cc: Daniel Vetter, David Airlie, linux-kernel, opensource.kernel
> kvfree ensure that the null pointer will do nothing.
I suggest to improve the commit message.
Would you like to adjust the patch subject?
Are you looking for further questionable condition checks?
…
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p,
…
> + kvfree(info);
>
> return r;
> }
How do you think about to omit a blank line behind the function call
at this source code place?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles_chunk()
@ 2020-04-19 8:15 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-04-19 8:15 UTC (permalink / raw)
To: Bernard Zhao, amd-gfx, dri-devel, Alex Deucher,
Christian König, Chunming Zhou, Felix Kühling,
Nicolai Hähnle, Nirmoy Das, Philip Yang
Cc: David Airlie, opensource.kernel, linux-kernel
> kvfree ensure that the null pointer will do nothing.
I suggest to improve the commit message.
Would you like to adjust the patch subject?
Are you looking for further questionable condition checks?
…
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p,
…
> + kvfree(info);
>
> return r;
> }
How do you think about to omit a blank line behind the function call
at this source code place?
Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles_chunk()
@ 2020-04-19 8:15 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-04-19 8:15 UTC (permalink / raw)
To: Bernard Zhao, amd-gfx, dri-devel, Alex Deucher,
Christian König, Chunming Zhou, Felix Kühling,
Nicolai Hähnle, Nirmoy Das, Philip Yang
Cc: David Airlie, opensource.kernel, linux-kernel, Daniel Vetter
> kvfree ensure that the null pointer will do nothing.
I suggest to improve the commit message.
Would you like to adjust the patch subject?
Are you looking for further questionable condition checks?
…
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p,
…
> + kvfree(info);
>
> return r;
> }
How do you think about to omit a blank line behind the function call
at this source code place?
Regards,
Markus
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-20 6:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-19 8:15 [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles_chunk() Markus Elfring
2020-04-19 8:15 ` Markus Elfring
2020-04-19 8:15 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.