All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Eugene Shalygin <eugene.shalygin@gmail.com>
Cc: Christopher Klooz <py0xc3@my.mail.de>,
	linux-hwmon@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: Issue in asus_ec_sensors in Fedora installations and other distributions
Date: Sun, 4 Sep 2022 07:10:10 -0700	[thread overview]
Message-ID: <1d234266-af01-5d8e-408f-ca58b53d870e@roeck-us.net> (raw)
In-Reply-To: <CAB95QARMOq0ie0SmhRx73L=mptTaa-eEHfNjGRH5CXvVFh-RLw@mail.gmail.com>

On 9/4/22 06:19, Eugene Shalygin wrote:
> On Sun, 4 Sept 2022 at 01:47, Guenter Roeck <linux@roeck-us.net> wrote:
> 
>> A driver with a probe function can be unloaded and reloaded manually.
>> I don't see how you can do that if the functions are marked __init
>> and the driver is built into the kernel.
> 
> Did that and a user tested those changes. Unfortunately, the ACPI EC
> is still inoperational if a module uses the ACPI id of the EC device
> and its probe function returns an error. Looks like I have to change
> MODULE_DEVICE_TABLE completely.
> 

If you insist on the __probe name hack, please add a note to the code
explaining why that name is necessary. There is only one single driver
besides this using that trick (I'd call it hack), hardly anyone will
know about it, and thus it needs to be explained in the driver to
prevent that the structure is renamed.

Having said that, how did you de-instantiate the device when it was
built into the kernel ?

Thanks,
Guenter

  reply	other threads:[~2022-09-04 14:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6026b5e2-a8f5-1058-6112-f191bde333a6@my.mail.de>
2022-09-03 11:00 ` Issue in asus_ec_sensors in Fedora installations and other distributions Christopher Klooz
2022-09-03 15:09   ` Guenter Roeck
2022-09-03 15:13     ` Eugene Shalygin
2022-09-03 15:42       ` Guenter Roeck
2022-09-03 19:40         ` Eugene Shalygin
2022-09-03 22:00           ` Guenter Roeck
2022-09-03 22:37             ` Eugene Shalygin
2022-09-03 23:47               ` Guenter Roeck
2022-09-04 13:19                 ` Eugene Shalygin
2022-09-04 14:10                   ` Guenter Roeck [this message]
2022-09-03 15:48       ` Christopher Klooz
2022-09-04  9:33   ` Issue in asus_ec_sensors in Fedora installations and other distributions #forregzbot Thorsten Leemhuis
2022-09-06 20:10   ` Issue in asus_ec_sensors in Fedora installations and other distributions Guenter Roeck
2022-09-06 20:23     ` Eugene Shalygin
2022-09-15  8:25       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d234266-af01-5d8e-408f-ca58b53d870e@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=eugene.shalygin@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=py0xc3@my.mail.de \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.