* [PATCH] Fix makefile.
@ 2023-05-29 3:06 Tom Isaacson
2023-05-29 4:46 ` [docs] " Alexander Kanavin
0 siblings, 1 reply; 4+ messages in thread
From: Tom Isaacson @ 2023-05-29 3:06 UTC (permalink / raw)
To: docs; +Cc: Tom Isaacson
Signed-off-by: Tom Isaacson <tom.isaacson@teknique.com>
---
documentation/sdk-manual/working-projects.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/documentation/sdk-manual/working-projects.rst b/documentation/sdk-manual/working-projects.rst
index 9a0db0099..b49a4cdca 100644
--- a/documentation/sdk-manual/working-projects.rst
+++ b/documentation/sdk-manual/working-projects.rst
@@ -296,8 +296,8 @@ example:
${CC} main.o module.o -o target_bin
main.o: main.c module.h
${CC} -I . -c main.c
- module.o: module.c
- module.h ${CC} -I . -c module.c
+ module.o: module.c module.h
+ ${CC} -I . -c module.c
clean:
rm -rf *.o
rm target_bin
--
2.40.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [docs] [PATCH] Fix makefile.
2023-05-29 3:06 [PATCH] Fix makefile Tom Isaacson
@ 2023-05-29 4:46 ` Alexander Kanavin
2023-05-30 8:42 ` [PATCH v2] sdk-manual: fix Makefile example michael.opdenacker
2023-05-30 8:47 ` [docs] [PATCH] Fix makefile Michael Opdenacker
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Kanavin @ 2023-05-29 4:46 UTC (permalink / raw)
To: Tom Isaacson; +Cc: docs
[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]
What is bring fixed and why? The commit message needs to include this
information.
Alex
On Mon 29. May 2023 at 5.06, Tom Isaacson <tom.isaacson@teknique.com> wrote:
> Signed-off-by: Tom Isaacson <tom.isaacson@teknique.com>
> ---
> documentation/sdk-manual/working-projects.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/documentation/sdk-manual/working-projects.rst
> b/documentation/sdk-manual/working-projects.rst
> index 9a0db0099..b49a4cdca 100644
> --- a/documentation/sdk-manual/working-projects.rst
> +++ b/documentation/sdk-manual/working-projects.rst
> @@ -296,8 +296,8 @@ example:
> ${CC} main.o module.o -o target_bin
> main.o: main.c module.h
> ${CC} -I . -c main.c
> - module.o: module.c
> - module.h ${CC} -I . -c module.c
> + module.o: module.c module.h
> + ${CC} -I . -c module.c
> clean:
> rm -rf *.o
> rm target_bin
> --
> 2.40.0.windows.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#3971):
> https://lists.yoctoproject.org/g/docs/message/3971
> Mute This Topic: https://lists.yoctoproject.org/mt/99193507/1686489
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 2375 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] sdk-manual: fix Makefile example
2023-05-29 4:46 ` [docs] " Alexander Kanavin
@ 2023-05-30 8:42 ` michael.opdenacker
2023-05-30 8:47 ` [docs] [PATCH] Fix makefile Michael Opdenacker
1 sibling, 0 replies; 4+ messages in thread
From: michael.opdenacker @ 2023-05-30 8:42 UTC (permalink / raw)
To: docs; +Cc: Michael Opdenacker, Tom Isaacson
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
From: Tom Isaacson <tom.isaacson@teknique.com>
"module.h" should be part of the dependency line
Space fixes too
Signed-off-by: Tom Isaacson <tom.isaacson@teknique.com>
Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
documentation/sdk-manual/working-projects.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/documentation/sdk-manual/working-projects.rst b/documentation/sdk-manual/working-projects.rst
index 9a0db0099d..b9af33393b 100644
--- a/documentation/sdk-manual/working-projects.rst
+++ b/documentation/sdk-manual/working-projects.rst
@@ -293,11 +293,11 @@ example:
# CC=i586-poky-linux-gcc -m32 -march=i586 --sysroot=/opt/poky/2.5/sysroots/i586-poky-linux
# CC="gcc"
all: main.o module.o
- ${CC} main.o module.o -o target_bin
+ ${CC} main.o module.o -o target_bin
main.o: main.c module.h
${CC} -I . -c main.c
- module.o: module.c
- module.h ${CC} -I . -c module.c
+ module.o: module.c module.h
+ ${CC} -I . -c module.c
clean:
rm -rf *.o
rm target_bin
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [docs] [PATCH] Fix makefile.
2023-05-29 4:46 ` [docs] " Alexander Kanavin
2023-05-30 8:42 ` [PATCH v2] sdk-manual: fix Makefile example michael.opdenacker
@ 2023-05-30 8:47 ` Michael Opdenacker
1 sibling, 0 replies; 4+ messages in thread
From: Michael Opdenacker @ 2023-05-30 8:47 UTC (permalink / raw)
To: Alexander Kanavin, Tom Isaacson; +Cc: docs
On 29.05.23 at 06:46, Alexander Kanavin wrote:
> What is bring fixed and why? The commit message needs to include this
> information.
Happy to help with that. Thanks Isaac for the patch and Alex for the review!
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-30 8:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-29 3:06 [PATCH] Fix makefile Tom Isaacson
2023-05-29 4:46 ` [docs] " Alexander Kanavin
2023-05-30 8:42 ` [PATCH v2] sdk-manual: fix Makefile example michael.opdenacker
2023-05-30 8:47 ` [docs] [PATCH] Fix makefile Michael Opdenacker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.