All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit()
Date: Mon, 19 Jul 2021 09:55:59 +0100	[thread overview]
Message-ID: <1d62696c-4864-68c4-bce5-690d575f0db7@linux.intel.com> (raw)
In-Reply-To: <20210716224758.2162003-1-jason@jlekstrand.net>


Noticed PMU being mentioned..

On 16/07/2021 23:47, Jason Ekstrand wrote:
> We should tear down in the opposite order we set up.
> 
> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
> Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs")

1)
You can use 'dim fixes <sha>' to get you the correct cc list when using 
the fixes tag. But:

2)
Fixes tag looks like should be removed to avoid potential needless 
backporting since I can't see that there is any inter-dependency between 
i915_pmu_exit and i915_globals_exit, hence nothing is getting fixes 
really, just tidying of the order.

With fixes removed:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
>   drivers/gpu/drm/i915/i915_pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 67696d7522718..50ed93b03e582 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void)
>   
>   	i915_perf_sysctl_unregister();
>   	pci_unregister_driver(&i915_pci_driver);
> -	i915_globals_exit();
>   	i915_pmu_exit();
> +	i915_globals_exit();
>   }
>   
>   module_init(i915_init);
> 

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit()
Date: Mon, 19 Jul 2021 09:55:59 +0100	[thread overview]
Message-ID: <1d62696c-4864-68c4-bce5-690d575f0db7@linux.intel.com> (raw)
In-Reply-To: <20210716224758.2162003-1-jason@jlekstrand.net>


Noticed PMU being mentioned..

On 16/07/2021 23:47, Jason Ekstrand wrote:
> We should tear down in the opposite order we set up.
> 
> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
> Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs")

1)
You can use 'dim fixes <sha>' to get you the correct cc list when using 
the fixes tag. But:

2)
Fixes tag looks like should be removed to avoid potential needless 
backporting since I can't see that there is any inter-dependency between 
i915_pmu_exit and i915_globals_exit, hence nothing is getting fixes 
really, just tidying of the order.

With fixes removed:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
>   drivers/gpu/drm/i915/i915_pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 67696d7522718..50ed93b03e582 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void)
>   
>   	i915_perf_sysctl_unregister();
>   	pci_unregister_driver(&i915_pci_driver);
> -	i915_globals_exit();
>   	i915_pmu_exit();
> +	i915_globals_exit();
>   }
>   
>   module_init(i915_init);
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-07-19  8:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 22:47 [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() Jason Ekstrand
2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand
2021-07-16 22:47 ` [PATCH 2/2] drm/i915: Tear down properly on early i915_init exit Jason Ekstrand
2021-07-16 22:47   ` [Intel-gfx] " Jason Ekstrand
2021-07-19  8:28   ` Daniel Vetter
2021-07-19  8:28     ` [Intel-gfx] " Daniel Vetter
2021-07-17  1:21 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() Patchwork
2021-07-17  1:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-17 11:53 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-19  8:29 ` [PATCH 1/2] " Daniel Vetter
2021-07-19  8:29   ` [Intel-gfx] " Daniel Vetter
2021-07-19  8:55 ` Tvrtko Ursulin [this message]
2021-07-19  8:55   ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d62696c-4864-68c4-bce5-690d575f0db7@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.