From: Helge Deller <deller@gmx.de>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 5.16-rc1
Date: Mon, 15 Nov 2021 19:19:14 +0100 [thread overview]
Message-ID: <1d843bb8-64d8-cb17-29c7-9eb60a9bed38@gmx.de> (raw)
In-Reply-To: <CAHk-=wis4sMKEB1EWJW-+jgc4j31S297sx7nq4a_MS92r8-HgA@mail.gmail.com>
On 11/15/21 19:10, Linus Torvalds wrote:
> On Mon, Nov 15, 2021 at 9:07 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> parisc:allmodconfig: Lots of build failures in arch/parisc/include/asm/jump_label.h.
>> Not fixed in -next. The problem seens to be related to the thread_info changes,
>> or at least bisect points to commit 01463374c50e ("Merge tag 'cpu-to-thread_info-v5.16-rc1'
>> of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux").
>
> I don't think they are related to the thread_info changes except very
> incidentally.
Yes.
> From the errors ("expected ':' before '__stringify'") it looks like
> __stringify() isn't defined there, and I do think that header file
> should include <linux/compiler.h> to get it.
>
> I don't actually see how that merge commit you bisected to could
> possibly matter (the diff doesn't show any header file include
> changes, or any parisc ones), but I suspect you might have bisected to
> it because we did end up having actual thread_info errors on parsic
> that weren't fixed until commit 2a2e8202c7a1 ("parisc: move CPU field
> back into thread_info").
>
> So I suspect the parisc build problems started with thread_info issues
> at that merge commit you pinpoint, and then by commit 2a2e8202c7a1
> some other header file simplification had exposed that "no
> __stringify()" thing).
>
> Helge - apparently from allmodconfig and others, we have:
>
> arch/parisc/include/asm/jump_label.h: In function 'arch_static_branch':
> arch/parisc/include/asm/jump_label.h:18:18: error: expected ':'
> before '__stringify'
>
> and others, which does look like just a missing header file (that was
> presumably previously implicitly included earlier, and now the
> implicit include is gone).
Yes, a header is missing.
I fixed it an hour ago in my for-next tree:
https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next&id=3ca6cc35f0c8d268b5d35e02e92b1ee99b4569d6
Helge
next prev parent reply other threads:[~2021-11-15 22:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 22:28 Linux 5.16-rc1 Linus Torvalds
2021-11-15 3:17 ` linux-next: stats (Was: Linux 5.16-rc1) Stephen Rothwell
2021-11-15 18:02 ` is arch/h8300 dead, was " Christoph Hellwig
2021-11-15 4:56 ` Linux 5.16-rc1 Guenter Roeck
2021-11-15 5:21 ` Linus Torvalds
2021-11-15 6:33 ` Guenter Roeck
2021-11-15 17:07 ` Guenter Roeck
2021-11-15 17:53 ` Linus Torvalds
2021-11-15 20:39 ` Nick Terrell
2021-11-15 18:10 ` Linus Torvalds
2021-11-15 18:19 ` Helge Deller [this message]
2021-11-15 18:38 ` Guenter Roeck
2021-11-16 11:36 ` Michael Ellerman
2021-11-16 14:50 ` Guenter Roeck
2021-11-17 20:18 ` Geert Uytterhoeven
2021-11-17 23:29 ` Anton Altaparmakov
2021-11-18 0:28 ` Linus Torvalds
2021-11-18 1:26 ` Anton Altaparmakov
2021-11-18 1:54 ` Linus Torvalds
2021-11-18 21:23 ` Guenter Roeck
2021-11-18 22:34 ` Linus Torvalds
2021-11-18 23:08 ` Guenter Roeck
2021-11-15 16:14 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d843bb8-64d8-cb17-29c7-9eb60a9bed38@gmx.de \
--to=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.