All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Anton Altaparmakov <anton@tuxera.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Guenter Roeck <linux@roeck-us.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-ntfs-dev@lists.sourceforge.net" 
	<linux-ntfs-dev@lists.sourceforge.net>
Subject: Re: Linux 5.16-rc1
Date: Wed, 17 Nov 2021 16:28:42 -0800	[thread overview]
Message-ID: <CAHk-=wgvzH=BaFg+kiWk1DXGLNELSmPS2VWcgSSmW5Y6vz-v_A@mail.gmail.com> (raw)
In-Reply-To: <8D79B547-D606-4975-A79A-AEA65684F3A0@tuxera.com>

On Wed, Nov 17, 2021 at 3:29 PM Anton Altaparmakov <anton@tuxera.com> wrote:
>
> What we need here is an array to store pointers to in-memory inodes that correspond to inodes in the inode table page being written out.

Do we actually need the array?

The ntfs_inode pointers in that array are always locked (using
'mrec_lock'), so ti could be just a linked list of entries.

Yeah, that would require adding a 'next' pointer to 'struct
_ntfs_inode', but maybe that would be the right thing to do?

I don't know the code, but it looks to me like it's literally just a
stack of locked ntfs_inode pointers - where the lock is taken before
adding it to the stack, and released after taking it off the stack. So
a singly-linked list would seem to be a very simple implementation.

                      Linus

  reply	other threads:[~2021-11-18  0:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 22:28 Linux 5.16-rc1 Linus Torvalds
2021-11-15  3:17 ` linux-next: stats (Was: Linux 5.16-rc1) Stephen Rothwell
2021-11-15 18:02   ` is arch/h8300 dead, was " Christoph Hellwig
2021-11-15  4:56 ` Linux 5.16-rc1 Guenter Roeck
2021-11-15  5:21   ` Linus Torvalds
2021-11-15  6:33     ` Guenter Roeck
2021-11-15 17:07     ` Guenter Roeck
2021-11-15 17:53       ` Linus Torvalds
2021-11-15 20:39         ` Nick Terrell
2021-11-15 18:10       ` Linus Torvalds
2021-11-15 18:19         ` Helge Deller
2021-11-15 18:38         ` Guenter Roeck
2021-11-16 11:36       ` Michael Ellerman
2021-11-16 14:50         ` Guenter Roeck
2021-11-17 20:18         ` Geert Uytterhoeven
2021-11-17 23:29           ` Anton Altaparmakov
2021-11-18  0:28             ` Linus Torvalds [this message]
2021-11-18  1:26               ` Anton Altaparmakov
2021-11-18  1:54                 ` Linus Torvalds
2021-11-18 21:23                   ` Guenter Roeck
2021-11-18 22:34                     ` Linus Torvalds
2021-11-18 23:08                       ` Guenter Roeck
2021-11-15 16:14   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgvzH=BaFg+kiWk1DXGLNELSmPS2VWcgSSmW5Y6vz-v_A@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=anton@tuxera.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=linux@roeck-us.net \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.