From: Andrzej Hajda <a.hajda@samsung.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: Jernej Skrabec <jernej.skrabec@siol.net>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, Jonas Karlman <jonas@kwiboo.se>, Bjorn Andersson <bjorn.andersson@linaro.org>, Vinod Koul <vkoul@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH v4 3/3] drm/bridge/lontium-lt9611uxc: move HPD notification out of IRQ handler Date: Thu, 28 Jan 2021 12:24:44 +0100 [thread overview] Message-ID: <1da37287-9f88-a28b-092b-cab6310c5665@samsung.com> (raw) In-Reply-To: <c6737dce-e310-bf5d-fa22-cc8d3ec0136e@samsung.com> W dniu 22.01.2021 o 10:34, Andrzej Hajda pisze: > W dniu 22.01.2021 o 00:33, Dmitry Baryshkov pisze: >> drm hotplug handling code (drm_client_dev_hotplug()) can wait on mutex, >> thus delaying further lt9611uxc IRQ events processing. It was observed >> occasionally during bootups, when drm_client_modeset_probe() was waiting >> for EDID ready event, which was delayed because IRQ handler was stuck >> trying to deliver hotplug event. >> Move hotplug notifications from IRQ handler to separate work to be able >> to process IRQ events without delays. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") > > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > > > Let's wait till Monday for other comments, then I can queue the patchset. Queued to drm-misc-fixes. I have fixed missing parentheses in the last patch in lt9611uxc_hpd_work, but apparently sth went wrong and I have merged version without these parentheses :(, can be fixed in another future patchset. Regards Andrzej > > > Regards > Andrzej > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://protect2.fireeye.com/v1/url?k=20f4a2d0-7f6f9b96-20f5299f-0cc47a3003e8-b85b502ae8b34801&q=1&e=194b3466-3374-4717-82f7-d4cec3951dd6&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: Jernej Skrabec <jernej.skrabec@siol.net>, Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>, Neil Armstrong <narmstrong@baylibre.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Vinod Koul <vkoul@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH v4 3/3] drm/bridge/lontium-lt9611uxc: move HPD notification out of IRQ handler Date: Thu, 28 Jan 2021 12:24:44 +0100 [thread overview] Message-ID: <1da37287-9f88-a28b-092b-cab6310c5665@samsung.com> (raw) In-Reply-To: <c6737dce-e310-bf5d-fa22-cc8d3ec0136e@samsung.com> W dniu 22.01.2021 o 10:34, Andrzej Hajda pisze: > W dniu 22.01.2021 o 00:33, Dmitry Baryshkov pisze: >> drm hotplug handling code (drm_client_dev_hotplug()) can wait on mutex, >> thus delaying further lt9611uxc IRQ events processing. It was observed >> occasionally during bootups, when drm_client_modeset_probe() was waiting >> for EDID ready event, which was delayed because IRQ handler was stuck >> trying to deliver hotplug event. >> Move hotplug notifications from IRQ handler to separate work to be able >> to process IRQ events without delays. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") > > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > > > Let's wait till Monday for other comments, then I can queue the patchset. Queued to drm-misc-fixes. I have fixed missing parentheses in the last patch in lt9611uxc_hpd_work, but apparently sth went wrong and I have merged version without these parentheses :(, can be fixed in another future patchset. Regards Andrzej > > > Regards > Andrzej > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://protect2.fireeye.com/v1/url?k=20f4a2d0-7f6f9b96-20f5299f-0cc47a3003e8-b85b502ae8b34801&q=1&e=194b3466-3374-4717-82f7-d4cec3951dd6&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-28 11:26 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 23:33 [PATCH v4 0/3] drm/bridge/lontium-lt9611uxc: fix handling of EDID/HPD Dmitry Baryshkov 2021-01-21 23:33 ` Dmitry Baryshkov 2021-01-21 23:33 ` [PATCH v4 1/3] drm/bridge/lontium-lt9611uxc: fix waiting for EDID to become available Dmitry Baryshkov 2021-01-21 23:33 ` Dmitry Baryshkov 2021-01-22 9:27 ` Andrzej Hajda 2021-01-22 9:27 ` Andrzej Hajda 2021-01-21 23:33 ` [PATCH v4 2/3] drm/bridge/lontium-lt9611uxc: fix get_edid return code Dmitry Baryshkov 2021-01-21 23:33 ` Dmitry Baryshkov 2021-01-22 9:28 ` Andrzej Hajda 2021-01-22 9:28 ` Andrzej Hajda 2021-01-21 23:33 ` [PATCH v4 3/3] drm/bridge/lontium-lt9611uxc: move HPD notification out of IRQ handler Dmitry Baryshkov 2021-01-21 23:33 ` Dmitry Baryshkov 2021-01-22 9:34 ` Andrzej Hajda 2021-01-22 9:34 ` Andrzej Hajda 2021-01-28 11:24 ` Andrzej Hajda [this message] 2021-01-28 11:24 ` Andrzej Hajda 2021-03-01 19:59 ` [PATCH v4 0/3] drm/bridge/lontium-lt9611uxc: fix handling of EDID/HPD patchwork-bot+linux-arm-msm
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1da37287-9f88-a28b-092b-cab6310c5665@samsung.com \ --to=a.hajda@samsung.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=linux-arm-msm@vger.kernel.org \ --cc=manivannan.sadhasivam@linaro.org \ --cc=narmstrong@baylibre.com \ --cc=sam@ravnborg.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.