* [PATCH v2] slimbus: core: Set fwnode for a device when setting of_node
@ 2020-03-26 17:24 ` Saravana Kannan
0 siblings, 0 replies; 8+ messages in thread
From: Saravana Kannan @ 2020-03-26 17:24 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: alsa-devel, Saravana Kannan, Greg Kroah-Hartman, linux-kernel,
John Stultz, kernel-team
When setting the of_node for a newly created device, also set the
fwnode. This allows fw_devlink feature to work for slimbus devices.
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/slimbus/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index 526e3215d8fe..44228a5b246d 100644
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
INIT_LIST_HEAD(&sbdev->stream_list);
spin_lock_init(&sbdev->stream_list_lock);
- if (node)
+ if (node) {
sbdev->dev.of_node = of_node_get(node);
+ sbdev->dev.fwnode = of_fwnode_handle(node);
+ }
dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
sbdev->e_addr.manf_id,
--
2.25.1.696.g5e7596f4ac-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] slimbus: core: Set fwnode for a device when setting of_node
2020-03-26 17:24 ` Saravana Kannan
@ 2020-03-26 18:11 ` Saravana Kannan
-1 siblings, 0 replies; 8+ messages in thread
From: Saravana Kannan @ 2020-03-26 18:11 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: John Stultz, Greg Kroah-Hartman, Android Kernel Team, alsa-devel, LKML
On Thu, Mar 26, 2020 at 10:25 AM Saravana Kannan <saravanak@google.com> wrote:
>
> When setting the of_node for a newly created device, also set the
> fwnode. This allows fw_devlink feature to work for slimbus devices.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> drivers/slimbus/core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 526e3215d8fe..44228a5b246d 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
> INIT_LIST_HEAD(&sbdev->stream_list);
> spin_lock_init(&sbdev->stream_list_lock);
>
> - if (node)
> + if (node) {
> sbdev->dev.of_node = of_node_get(node);
> + sbdev->dev.fwnode = of_fwnode_handle(node);
> + }
>
> dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
> sbdev->e_addr.manf_id,
> --
Hi Srinivas,
Btw, I sent another patch that's on top of this patch.
https://lore.kernel.org/lkml/20200326173457.29233-1-saravanak@google.com/T/#u
That fixes of_node_get() handling. Didn't notice it before I sent this
patch. Otherwise would have made it a series. Sorry about the trouble.
Thanks,
Saravana
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] slimbus: core: Set fwnode for a device when setting of_node
@ 2020-03-26 18:11 ` Saravana Kannan
0 siblings, 0 replies; 8+ messages in thread
From: Saravana Kannan @ 2020-03-26 18:11 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Greg Kroah-Hartman, alsa-devel, Android Kernel Team, John Stultz, LKML
On Thu, Mar 26, 2020 at 10:25 AM Saravana Kannan <saravanak@google.com> wrote:
>
> When setting the of_node for a newly created device, also set the
> fwnode. This allows fw_devlink feature to work for slimbus devices.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> drivers/slimbus/core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 526e3215d8fe..44228a5b246d 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
> INIT_LIST_HEAD(&sbdev->stream_list);
> spin_lock_init(&sbdev->stream_list_lock);
>
> - if (node)
> + if (node) {
> sbdev->dev.of_node = of_node_get(node);
> + sbdev->dev.fwnode = of_fwnode_handle(node);
> + }
>
> dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
> sbdev->e_addr.manf_id,
> --
Hi Srinivas,
Btw, I sent another patch that's on top of this patch.
https://lore.kernel.org/lkml/20200326173457.29233-1-saravanak@google.com/T/#u
That fixes of_node_get() handling. Didn't notice it before I sent this
patch. Otherwise would have made it a series. Sorry about the trouble.
Thanks,
Saravana
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] slimbus: core: Set fwnode for a device when setting of_node
2020-03-26 17:24 ` Saravana Kannan
@ 2020-03-26 18:22 ` John Stultz
-1 siblings, 0 replies; 8+ messages in thread
From: John Stultz @ 2020-03-26 18:22 UTC (permalink / raw)
To: Saravana Kannan
Cc: Srinivas Kandagatla, Greg Kroah-Hartman, Android Kernel Team,
Linux-ALSA, lkml
On Thu, Mar 26, 2020 at 10:25 AM Saravana Kannan <saravanak@google.com> wrote:
>
> When setting the of_node for a newly created device, also set the
> fwnode. This allows fw_devlink feature to work for slimbus devices.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
Tested-by: John Stultz <john.stultz@linaro.org>
thanks!
-john
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] slimbus: core: Set fwnode for a device when setting of_node
@ 2020-03-26 18:22 ` John Stultz
0 siblings, 0 replies; 8+ messages in thread
From: John Stultz @ 2020-03-26 18:22 UTC (permalink / raw)
To: Saravana Kannan
Cc: Greg Kroah-Hartman, Linux-ALSA, Android Kernel Team,
Srinivas Kandagatla, lkml
On Thu, Mar 26, 2020 at 10:25 AM Saravana Kannan <saravanak@google.com> wrote:
>
> When setting the of_node for a newly created device, also set the
> fwnode. This allows fw_devlink feature to work for slimbus devices.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
Tested-by: John Stultz <john.stultz@linaro.org>
thanks!
-john
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] slimbus: core: Set fwnode for a device when setting of_node
2020-03-26 17:24 ` Saravana Kannan
@ 2020-04-17 9:35 ` Srinivas Kandagatla
-1 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-04-17 9:35 UTC (permalink / raw)
To: Saravana Kannan
Cc: John Stultz, Greg Kroah-Hartman, kernel-team, alsa-devel, linux-kernel
On 26/03/2020 17:24, Saravana Kannan wrote:
> When setting the of_node for a newly created device, also set the
> fwnode. This allows fw_devlink feature to work for slimbus devices.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
Applied Thanks,
--srini
> ---
> drivers/slimbus/core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 526e3215d8fe..44228a5b246d 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
> INIT_LIST_HEAD(&sbdev->stream_list);
> spin_lock_init(&sbdev->stream_list_lock);
>
> - if (node)
> + if (node) {
> sbdev->dev.of_node = of_node_get(node);
> + sbdev->dev.fwnode = of_fwnode_handle(node);
> + }
>
> dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
> sbdev->e_addr.manf_id,
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] slimbus: core: Set fwnode for a device when setting of_node
@ 2020-04-17 9:35 ` Srinivas Kandagatla
0 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-04-17 9:35 UTC (permalink / raw)
To: Saravana Kannan
Cc: Greg Kroah-Hartman, alsa-devel, kernel-team, John Stultz, linux-kernel
On 26/03/2020 17:24, Saravana Kannan wrote:
> When setting the of_node for a newly created device, also set the
> fwnode. This allows fw_devlink feature to work for slimbus devices.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
Applied Thanks,
--srini
> ---
> drivers/slimbus/core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 526e3215d8fe..44228a5b246d 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
> INIT_LIST_HEAD(&sbdev->stream_list);
> spin_lock_init(&sbdev->stream_list_lock);
>
> - if (node)
> + if (node) {
> sbdev->dev.of_node = of_node_get(node);
> + sbdev->dev.fwnode = of_fwnode_handle(node);
> + }
>
> dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
> sbdev->e_addr.manf_id,
>
^ permalink raw reply [flat|nested] 8+ messages in thread