[PATCH] mt76: mt7603: add additional EEPROM chip ID

[PATCH] mt76: mt7603: add additional EEPROM chip ID

[David Bauer]

Some newer MT7628 based routers (notably the TP-Link Archer C50 v4) are
shipped with a chip-id of 0x7600 in the on-flash EEPROM. Add this as a
possible valid ID.

Ref: https://bugs.openwrt.org/index.php?do=details&task_id=2781

Suggested-by: Ron Asimi <ron.asimi@gmail.com>
Signed-off-by: David Bauer <mail@david-bauer.net>
---
 drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
index 3ee06e2577b8..422b9d9e8962 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
@@ -141,6 +141,7 @@ static int mt7603_check_eeprom(struct mt76_dev *dev)
 	switch (val) {
 	case 0x7628:
 	case 0x7603:
+	case 0x7600:
 		return 0;
 	default:
 		return -EINVAL;
-- 
2.28.0

Re: [PATCH] mt76: mt7603: add additional EEPROM chip ID

[Lorenzo Bianconi]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

> Some newer MT7628 based routers (notably the TP-Link Archer C50 v4) are
> shipped with a chip-id of 0x7600 in the on-flash EEPROM. Add this as a
> possible valid ID.
> 
> Ref: https://bugs.openwrt.org/index.php?do=details&task_id=2781
> 
> Suggested-by: Ron Asimi <ron.asimi@gmail.com>
> Signed-off-by: David Bauer <mail@david-bauer.net>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
> index 3ee06e2577b8..422b9d9e8962 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
> @@ -141,6 +141,7 @@ static int mt7603_check_eeprom(struct mt76_dev *dev)
>  	switch (val) {
>  	case 0x7628:
>  	case 0x7603:
> +	case 0x7600:

is it a hw bug or does this part-number really exist?


>  		return 0;
>  	default:
>  		return -EINVAL;
> -- 
> 2.28.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] mt76: mt7603: add additional EEPROM chip ID

[David Bauer]

Hi Lorenzo,

On 10/13/20 4:32 PM, Lorenzo Bianconi wrote:
>> Some newer MT7628 based routers (notably the TP-Link Archer C50 v4) are
>> shipped with a chip-id of 0x7600 in the on-flash EEPROM. Add this as a
>> possible valid ID.
>>
>> Ref: https://bugs.openwrt.org/index.php?do=details&task_id=2781
>>
>> Suggested-by: Ron Asimi <ron.asimi@gmail.com>
>> Signed-off-by: David Bauer <mail@david-bauer.net>
>> ---
>>  drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
>> index 3ee06e2577b8..422b9d9e8962 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7603/eeprom.c
>> @@ -141,6 +141,7 @@ static int mt7603_check_eeprom(struct mt76_dev *dev)
>>  	switch (val) {
>>  	case 0x7628:
>>  	case 0x7603:
>> +	case 0x7600:
> 
> is it a hw bug or does this part-number really exist?

I assume it's a bug on TP-Links side. However, there's already quite some units with
this chip-id in their EEPROM around.

Best wishes
David

> 
> 
>>  		return 0;
>>  	default:
>>  		return -EINVAL;
>> -- 
>> 2.28.0
>>

Re: [PATCH] mt76: mt7603: add additional EEPROM chip ID

[Andreas Ziegler]

Hi,

David Bauer wrote on 13.10.20 16:42:
>>
>> is it a hw bug or does this part-number really exist?
> 
> I assume it's a bug on TP-Links side. However, there's already quite some units with
> this chip-id in their EEPROM around.


to my knowledge, all devices of this specific model (Archer C50 v4) have
this chip-id in their EEPROM, not only some.

Regards

Andreas

Re: [PATCH] mt76: mt7603: add additional EEPROM chip ID

[David Bauer]

Hi Andreas,

On 10/13/20 6:00 PM, Andreas Ziegler wrote:
> Hi,
> 
> David Bauer wrote on 13.10.20 16:42:
>>>
>>> is it a hw bug or does this part-number really exist?
>>
>> I assume it's a bug on TP-Links side. However, there's already quite some units with
>> this chip-id in their EEPROM around.
> 
> 
> to my knowledge, all devices of this specific model (Archer C50 v4) have
> this chip-id in their EEPROM, not only some.

The unit I've got back when the v4 first surfaced has the correct chip-id in the
2.4GHz EEPROM (0x7628). However, some (if not all) newer units use 0x7600 as the
chip-id for the MT7628 caldata.

Best wishes
David


> 
> Regards
> 
> Andreas
>