From: Dan Murphy <dmurphy@ti.com> To: Wolfgang Grandegger <wg@grandegger.com>, mkl@pengutronix.de, davem@davemloft.net Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/3] M_CAN Framework rework Date: Wed, 24 Oct 2018 06:36:10 -0500 [thread overview] Message-ID: <1db25e4b-9b83-a234-b98f-e3c0c72d5e31@ti.com> (raw) In-Reply-To: <8d7fcd11-b537-97c1-ee50-ba30f236b5ec@grandegger.com> Wolfgang On 10/24/2018 02:43 AM, Wolfgang Grandegger wrote: > Hallo Dan, > > I will have a closer look later this week. Unfortunately you already > renamed file names and structs making the patch almost unreadable. More > soon.. > I tried to format the patch to eliminate the massive change but format patch kept giving me the same result. It is a massive change regardless not sure how else to make is smaller. I guess this is why I opt'd to just create the dedicated TCAN driver. Dan > Thanks for you patience, > > Wolfgang. > > Am 17.10.2018 um 22:21 schrieb Dan Murphy: >> Bump >> >> On 10/10/2018 09:20 AM, Dan Murphy wrote: >>> All >>> >>> This patch series creates a m_can core framework that devices can register >>> to. The m_can core manages the Bosch IP and CAN frames. Each device that >>> is registered is responsible for managing device specific functions. >>> >>> This rewrite was suggested in a device driver submission for the TCAN4x5x >>> device >>> Reference upstream post: >>> https://lore.kernel.org/patchwork/patch/984163/ >>> >>> For instance the TCAN device is a SPI device that uses a specific data payload to >>> determine writes and reads. In addition the device has a reset input as well >>> as a wakeup pin. The register offset of the m_can registers differs and must >>> be set by the device attached to the core. >>> >>> The m_can core will use iomapped writes and reads as the default mechanism for >>> writing and reading. The device driver can provide over rides for this. >>> >>> This patch series is not complete as it does not handle the CAN interrupts >>> nor can perform a CAN write. If this patch series is deemed acceptable I will >>> finish debugging the driver and post a non RFC series. >>> >>> Finally I did attempt to reduce the first patch with various git format patch >>> directives but none seemed to reduce the patch. >>> >>> Dan >>> >>> Dan Murphy (3): >>> can: m_can: Create m_can core to leverage common code >>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >>> can: tcan4x5x: Add tcan4x5x driver to the kernel >>> >>> .../devicetree/bindings/net/can/tcan4x5x.txt | 34 + >>> drivers/net/can/m_can/Kconfig | 18 + >>> drivers/net/can/m_can/Makefile | 4 +- >>> drivers/net/can/m_can/m_can.c | 1683 +---------------- >>> .../net/can/m_can/{m_can.c => m_can_core.c} | 479 +++-- >>> drivers/net/can/m_can/m_can_core.h | 100 + >>> drivers/net/can/m_can/tcan4x5x.c | 321 ++++ >>> 7 files changed, 722 insertions(+), 1917 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>> copy drivers/net/can/m_can/{m_can.c => m_can_core.c} (83%) >>> create mode 100644 drivers/net/can/m_can/m_can_core.h >>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >>> >> >> -- ------------------ Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Wolfgang Grandegger <wg@grandegger.com>, <mkl@pengutronix.de>, <davem@davemloft.net> Cc: <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH 0/3] M_CAN Framework rework Date: Wed, 24 Oct 2018 06:36:10 -0500 [thread overview] Message-ID: <1db25e4b-9b83-a234-b98f-e3c0c72d5e31@ti.com> (raw) In-Reply-To: <8d7fcd11-b537-97c1-ee50-ba30f236b5ec@grandegger.com> Wolfgang On 10/24/2018 02:43 AM, Wolfgang Grandegger wrote: > Hallo Dan, > > I will have a closer look later this week. Unfortunately you already > renamed file names and structs making the patch almost unreadable. More > soon.. > I tried to format the patch to eliminate the massive change but format patch kept giving me the same result. It is a massive change regardless not sure how else to make is smaller. I guess this is why I opt'd to just create the dedicated TCAN driver. Dan > Thanks for you patience, > > Wolfgang. > > Am 17.10.2018 um 22:21 schrieb Dan Murphy: >> Bump >> >> On 10/10/2018 09:20 AM, Dan Murphy wrote: >>> All >>> >>> This patch series creates a m_can core framework that devices can register >>> to. The m_can core manages the Bosch IP and CAN frames. Each device that >>> is registered is responsible for managing device specific functions. >>> >>> This rewrite was suggested in a device driver submission for the TCAN4x5x >>> device >>> Reference upstream post: >>> https://lore.kernel.org/patchwork/patch/984163/ >>> >>> For instance the TCAN device is a SPI device that uses a specific data payload to >>> determine writes and reads. In addition the device has a reset input as well >>> as a wakeup pin. The register offset of the m_can registers differs and must >>> be set by the device attached to the core. >>> >>> The m_can core will use iomapped writes and reads as the default mechanism for >>> writing and reading. The device driver can provide over rides for this. >>> >>> This patch series is not complete as it does not handle the CAN interrupts >>> nor can perform a CAN write. If this patch series is deemed acceptable I will >>> finish debugging the driver and post a non RFC series. >>> >>> Finally I did attempt to reduce the first patch with various git format patch >>> directives but none seemed to reduce the patch. >>> >>> Dan >>> >>> Dan Murphy (3): >>> can: m_can: Create m_can core to leverage common code >>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >>> can: tcan4x5x: Add tcan4x5x driver to the kernel >>> >>> .../devicetree/bindings/net/can/tcan4x5x.txt | 34 + >>> drivers/net/can/m_can/Kconfig | 18 + >>> drivers/net/can/m_can/Makefile | 4 +- >>> drivers/net/can/m_can/m_can.c | 1683 +---------------- >>> .../net/can/m_can/{m_can.c => m_can_core.c} | 479 +++-- >>> drivers/net/can/m_can/m_can_core.h | 100 + >>> drivers/net/can/m_can/tcan4x5x.c | 321 ++++ >>> 7 files changed, 722 insertions(+), 1917 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>> copy drivers/net/can/m_can/{m_can.c => m_can_core.c} (83%) >>> create mode 100644 drivers/net/can/m_can/m_can_core.h >>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >>> >> >> -- ------------------ Dan Murphy
next prev parent reply other threads:[~2018-10-24 11:36 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-10 14:20 [RFC PATCH 0/3] M_CAN Framework rework Dan Murphy 2018-10-10 14:20 ` Dan Murphy 2018-10-10 14:20 ` [RFC PATCH 1/3] can: m_can: Create m_can core to leverage common code Dan Murphy 2018-10-10 14:20 ` Dan Murphy 2018-10-27 14:19 ` Wolfgang Grandegger 2018-10-27 14:19 ` Wolfgang Grandegger 2018-10-31 20:15 ` Dan Murphy 2018-10-31 20:15 ` Dan Murphy 2018-11-03 10:45 ` Wolfgang Grandegger 2018-11-09 15:14 ` Dan Murphy 2018-11-09 15:14 ` Dan Murphy 2019-01-09 20:58 ` Dan Murphy 2019-01-09 20:58 ` Dan Murphy 2019-01-10 7:44 ` Wolfgang Grandegger 2019-01-10 7:57 ` Rizvi, Mohammad Faiz Abbas 2019-01-10 7:57 ` Rizvi, Mohammad Faiz Abbas 2019-01-10 12:54 ` Dan Murphy 2019-01-10 12:54 ` Dan Murphy 2019-01-10 12:53 ` Dan Murphy 2019-01-10 12:53 ` Dan Murphy 2019-01-11 8:27 ` Wolfgang Grandegger 2019-01-11 12:27 ` Dan Murphy 2019-01-11 12:27 ` Dan Murphy 2018-10-10 14:20 ` [RFC PATCH 2/3] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver Dan Murphy 2018-10-10 14:20 ` Dan Murphy 2018-10-10 14:20 ` [RFC PATCH 3/3] can: tcan4x5x: Add tcan4x5x driver to the kernel Dan Murphy 2018-10-10 14:20 ` Dan Murphy 2018-10-17 20:21 ` [RFC PATCH 0/3] M_CAN Framework rework Dan Murphy 2018-10-17 20:21 ` Dan Murphy 2018-10-24 7:33 ` Faiz Abbas 2018-10-24 7:33 ` Faiz Abbas 2018-10-24 11:39 ` Dan Murphy 2018-10-24 11:39 ` Dan Murphy 2018-10-24 7:43 ` Wolfgang Grandegger 2018-10-24 11:36 ` Dan Murphy [this message] 2018-10-24 11:36 ` Dan Murphy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1db25e4b-9b83-a234-b98f-e3c0c72d5e31@ti.com \ --to=dmurphy@ti.com \ --cc=davem@davemloft.net \ --cc=linux-can@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mkl@pengutronix.de \ --cc=netdev@vger.kernel.org \ --cc=wg@grandegger.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.