From: Christophe LEROY <christophe.leroy@c-s.fr>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] crypto: talitos: Delete an error message for a failed memory allocation in talitos_edesc_alloc()
Date: Mon, 12 Mar 2018 15:13:04 +0100 [thread overview]
Message-ID: <1dcf05e3-1552-68b6-96cf-c5b57cd68e03@c-s.fr> (raw)
In-Reply-To: <13bfdc03-1dee-2f1c-da8d-1e452f10c850@users.sourceforge.net>
Le 12/03/2018 à 14:32, SF Markus Elfring a écrit :
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 12 Mar 2018 14:18:23 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> drivers/crypto/talitos.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index a2271322db34..4c7318981d28 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -1399,7 +1399,6 @@ static struct talitos_edesc *talitos_edesc_alloc(struct device *dev,
>
> edesc = kmalloc(alloc_len, GFP_DMA | flags);
> if (!edesc) {
> - dev_err(dev, "could not allocate edescriptor\n");
> err = ERR_PTR(-ENOMEM);
> goto error_sg;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Christophe LEROY <christophe.leroy@c-s.fr>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] crypto: talitos: Delete an error message for a failed memory allocation in talitos_e
Date: Mon, 12 Mar 2018 14:13:04 +0000 [thread overview]
Message-ID: <1dcf05e3-1552-68b6-96cf-c5b57cd68e03@c-s.fr> (raw)
In-Reply-To: <13bfdc03-1dee-2f1c-da8d-1e452f10c850@users.sourceforge.net>
Le 12/03/2018 à 14:32, SF Markus Elfring a écrit :
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 12 Mar 2018 14:18:23 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> drivers/crypto/talitos.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index a2271322db34..4c7318981d28 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -1399,7 +1399,6 @@ static struct talitos_edesc *talitos_edesc_alloc(struct device *dev,
>
> edesc = kmalloc(alloc_len, GFP_DMA | flags);
> if (!edesc) {
> - dev_err(dev, "could not allocate edescriptor\n");
> err = ERR_PTR(-ENOMEM);
> goto error_sg;
> }
>
next prev parent reply other threads:[~2018-03-12 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 13:30 [PATCH 0/2] crypto/talitos: Adjustments for talitos_edesc_alloc() SF Markus Elfring
2018-03-12 13:30 ` SF Markus Elfring
2018-03-12 13:31 ` [PATCH 1/2] crypto: talitos: Use common error handling code in talitos_edesc_alloc() SF Markus Elfring
2018-03-12 13:31 ` SF Markus Elfring
2018-03-12 14:12 ` Christophe LEROY
2018-03-12 14:12 ` Christophe LEROY
2018-03-12 13:32 ` [PATCH 2/2] crypto: talitos: Delete an error message for a failed memory allocation " SF Markus Elfring
2018-03-12 13:32 ` [PATCH 2/2] crypto: talitos: Delete an error message for a failed memory allocation in talitos_edesc SF Markus Elfring
2018-03-12 14:13 ` Christophe LEROY [this message]
2018-03-12 14:13 ` [PATCH 2/2] crypto: talitos: Delete an error message for a failed memory allocation in talitos_e Christophe LEROY
2018-03-23 15:58 ` [PATCH 2/2] crypto: talitos: Delete an error message for a failed memory allocation in talitos_edesc_alloc() Herbert Xu
2018-03-23 15:58 ` [PATCH 2/2] crypto: talitos: Delete an error message for a failed memory allocation in talitos_e Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dcf05e3-1552-68b6-96cf-c5b57cd68e03@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.