All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_reuse: stop the hang detector afterwards
Date: Mon, 11 Feb 2019 10:34:32 -0800	[thread overview]
Message-ID: <1dd54914-9137-4a07-db36-4700a587dc01@intel.com> (raw)
In-Reply-To: <20190211175242.722-1-chris@chris-wilson.co.uk>



On 11/02/19 09:52, Chris Wilson wrote:
> Take responsibility for the state we create, and in particular remember
> to kill our child process (the hang detector) before exiting.
> 
> Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>   tests/i915/gem_exec_reuse.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_reuse.c b/tests/i915/gem_exec_reuse.c
> index df220be7b..44946528f 100644
> --- a/tests/i915/gem_exec_reuse.c
> +++ b/tests/i915/gem_exec_reuse.c
> @@ -116,7 +116,7 @@ static unsigned int max_nfd(void)
>   
>   igt_main
>   {
> -	struct noop no;
> +	struct noop no = { .fd = -1 };
>   	unsigned engines[16];
>   	unsigned nengine;
>   	unsigned n;
> @@ -213,4 +213,7 @@ igt_main
>   		for (n = 0; n < ncontexts; n++)
>   			gem_context_destroy(no.fd, contexts[n]);
>   	}
> +
> +	igt_fixture
> +		igt_stop_hang_detector(no.fd);

This doesn't take an fd... incoming changes to the lib?

Still makes sense, with fix,

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

>   }
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_reuse: stop the hang detector afterwards
Date: Mon, 11 Feb 2019 10:34:32 -0800	[thread overview]
Message-ID: <1dd54914-9137-4a07-db36-4700a587dc01@intel.com> (raw)
In-Reply-To: <20190211175242.722-1-chris@chris-wilson.co.uk>



On 11/02/19 09:52, Chris Wilson wrote:
> Take responsibility for the state we create, and in particular remember
> to kill our child process (the hang detector) before exiting.
> 
> Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>   tests/i915/gem_exec_reuse.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_reuse.c b/tests/i915/gem_exec_reuse.c
> index df220be7b..44946528f 100644
> --- a/tests/i915/gem_exec_reuse.c
> +++ b/tests/i915/gem_exec_reuse.c
> @@ -116,7 +116,7 @@ static unsigned int max_nfd(void)
>   
>   igt_main
>   {
> -	struct noop no;
> +	struct noop no = { .fd = -1 };
>   	unsigned engines[16];
>   	unsigned nengine;
>   	unsigned n;
> @@ -213,4 +213,7 @@ igt_main
>   		for (n = 0; n < ncontexts; n++)
>   			gem_context_destroy(no.fd, contexts[n]);
>   	}
> +
> +	igt_fixture
> +		igt_stop_hang_detector(no.fd);

This doesn't take an fd... incoming changes to the lib?

Still makes sense, with fix,

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

>   }
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-02-11 18:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 17:52 [PATCH i-g-t] i915/gem_exec_reuse: stop the hang detector afterwards Chris Wilson
2019-02-11 17:52 ` [igt-dev] " Chris Wilson
2019-02-11 18:07 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-02-11 18:34 ` Antonio Argenziano [this message]
2019-02-11 18:34   ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dd54914-9137-4a07-db36-4700a587dc01@intel.com \
    --to=antonio.argenziano@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.