* [PATCH] speakup: Fix warning comparing pointer to 0
@ 2022-11-06 15:07 wangkailong
2022-11-06 15:51 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: wangkailong @ 2022-11-06 15:07 UTC (permalink / raw)
To: w.d.hubbs, chris, kirk, samuel.thibault, gregkh; +Cc: speakup, linux-kernel
Fix the following coccicheck warning:
drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing
pointer to 0
Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
drivers/accessibility/speakup/utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..5803b521df2b 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
else
snprintf(filename, sizeof(filename), "%s", name);
infile = fopen(filename, "r");
- if (infile == 0) {
+ if (infile) {
fprintf(stderr, "can't open %s\n", filename);
exit(1);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] speakup: Fix warning comparing pointer to 0
2022-11-06 15:07 [PATCH] speakup: Fix warning comparing pointer to 0 wangkailong
@ 2022-11-06 15:51 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2022-11-06 15:51 UTC (permalink / raw)
To: wangkailong; +Cc: w.d.hubbs, chris, kirk, gregkh, speakup, linux-kernel
wangkailong@jari.cn, le dim. 06 nov. 2022 23:07:54 +0800, a ecrit:
> Fix the following coccicheck warning:
>
> drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing
> pointer to 0
You're replacing it with the contrary of what it should be...
> ---
> drivers/accessibility/speakup/utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..5803b521df2b 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
> else
> snprintf(filename, sizeof(filename), "%s", name);
> infile = fopen(filename, "r");
> - if (infile == 0) {
> + if (infile) {
> fprintf(stderr, "can't open %s\n", filename);
> exit(1);
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-06 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-06 15:07 [PATCH] speakup: Fix warning comparing pointer to 0 wangkailong
2022-11-06 15:51 ` Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.