All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kahola, Mika" <mika.kahola@intel.com>
To: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915: always return something
Date: Tue, 22 Jan 2019 12:01:27 +0000	[thread overview]
Message-ID: <1df0db19b94efebc712eba6d386586e37bdd451b.camel@intel.com> (raw)
In-Reply-To: <20190117202113.5190-3-lucas.demarchi@intel.com>

Patch look ok to me.

On Thu, 2019-01-17 at 12:21 -0800, Lucas De Marchi wrote:
> Even if we don't have the correct clock and get a warning, we should
> not
> skip the return.
> 
> Fixes: 1fa11ee2d9d0 ("drm/i915/icl: start adding the TBT pll")
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: <stable@vger.kernel.org> # v4.19+

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index 8dbf6c9e22fb..4dc03e8c6c10 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1021,7 +1021,7 @@ static uint32_t icl_pll_to_ddi_pll_sel(struct
> intel_encoder *encoder,
>  			return DDI_CLK_SEL_TBT_810;
>  		default:
>  			MISSING_CASE(clock);
> -			break;
> +			return DDI_CLK_SEL_NONE;
>  		}
>  	case DPLL_ID_ICL_MGPLL1:
>  	case DPLL_ID_ICL_MGPLL2:

WARNING: multiple messages have this Message-ID (diff)
From: "Kahola, Mika" <mika.kahola@intel.com>
To: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/5] drm/i915: always return something
Date: Tue, 22 Jan 2019 12:01:27 +0000	[thread overview]
Message-ID: <1df0db19b94efebc712eba6d386586e37bdd451b.camel@intel.com> (raw)
In-Reply-To: <20190117202113.5190-3-lucas.demarchi@intel.com>

Patch look ok to me.

On Thu, 2019-01-17 at 12:21 -0800, Lucas De Marchi wrote:
> Even if we don't have the correct clock and get a warning, we should
> not
> skip the return.
> 
> Fixes: 1fa11ee2d9d0 ("drm/i915/icl: start adding the TBT pll")
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: <stable@vger.kernel.org> # v4.19+

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index 8dbf6c9e22fb..4dc03e8c6c10 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1021,7 +1021,7 @@ static uint32_t icl_pll_to_ddi_pll_sel(struct
> intel_encoder *encoder,
>  			return DDI_CLK_SEL_TBT_810;
>  		default:
>  			MISSING_CASE(clock);
> -			break;
> +			return DDI_CLK_SEL_NONE;
>  		}
>  	case DPLL_ID_ICL_MGPLL1:
>  	case DPLL_ID_ICL_MGPLL2:
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-01-22 12:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 20:21 [PATCH 0/5] icl: Misc PLL patches Lucas De Marchi
2019-01-17 20:21 ` [PATCH 1/5] drm/i915/icl: use tc_port in MG_PLL macros Lucas De Marchi
2019-01-24  1:15   ` Paulo Zanoni
2019-01-24 18:52     ` Lucas De Marchi
2019-01-24 20:40       ` Paulo Zanoni
2019-01-17 20:21 ` [PATCH 2/5] drm/i915: always return something Lucas De Marchi
2019-01-22 12:01   ` Kahola, Mika [this message]
2019-01-22 12:01     ` Kahola, Mika
2019-01-23 14:19   ` [Intel-gfx] " Joonas Lahtinen
2019-01-23 14:19     ` Joonas Lahtinen
2019-01-23 18:01     ` Lucas De Marchi
2019-01-17 20:21 ` [PATCH 3/5] drm/i915/icl: remove dpll from clk_sel Lucas De Marchi
2019-01-24  1:31   ` Paulo Zanoni
2019-01-17 20:21 ` [PATCH 4/5] drm/i915/icl: keep track of unused pll while looping Lucas De Marchi
2019-01-24  1:38   ` Paulo Zanoni
2019-01-17 20:21 ` [PATCH 5/5] drm/i915: allow shared plls to be non-consecutive Lucas De Marchi
2019-01-17 22:06   ` Lucas De Marchi
2019-01-17 20:38 ` ✗ Fi.CI.CHECKPATCH: warning for icl: Misc PLL patches Patchwork
2019-01-17 21:02 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-18  6:05 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-23 18:00 ` [PATCH 0/5] " Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1df0db19b94efebc712eba6d386586e37bdd451b.camel@intel.com \
    --to=mika.kahola@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=paulo.r.zanoni@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.