All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, ayaka <ayaka@soulik.info>
Cc: devicetree@vger.kernel.org, mark.rutland@arm.com,
	linux@armlinux.org.uk, kgene@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh@kernel.org
Subject: Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board
Date: Fri, 16 Sep 2016 14:09:15 -0400	[thread overview]
Message-ID: <1e4335db-9004-bb7c-6dc1-e435e66b8126@osg.samsung.com> (raw)
In-Reply-To: <20160916172110.GA7511@kozik-lap>

Hello Randy,

On 09/16/2016 01:21 PM, Krzysztof Kozlowski wrote:

[snip]

>>>> +	
>>>> +	beep {
>>>> +		compatible = "pwm-beeper";
>>>> +		pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>;
>>> I have serious doubts that you run this code... if it does not even
>>> compile. Sorry, I cannot accept code that does not compile and was not
>>> tested.
>>>
>>> Please, test your DTS on top of current Linux tree, which would be one of:
>>> 1. Linus' master branch: v4.8-rc6,
>>> 2. one of my branches (for-next, next/dt etc),
>> When I sent those patches, I tested in "Add linux-next specific files for
>> 20160907"
>
> OK, good, but please tell me why kbuild reported that build error?
>

I agree with Krzysztof, it doesn't seem that you tested the exact version
that was posted. You will need the following change to make the DTS build
in latest linux-next:

diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index dd83689892ff..8559f891a740 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -14,6 +14,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/pwm/pwm.h>
 #include <dt-bindings/sound/samsung-i2s.h>
 #include "exynos4412-itop-scp-core.dtsi"

So please squash that change and resend.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board
Date: Fri, 16 Sep 2016 14:09:15 -0400	[thread overview]
Message-ID: <1e4335db-9004-bb7c-6dc1-e435e66b8126@osg.samsung.com> (raw)
In-Reply-To: <20160916172110.GA7511@kozik-lap>

Hello Randy,

On 09/16/2016 01:21 PM, Krzysztof Kozlowski wrote:

[snip]

>>>> +	
>>>> +	beep {
>>>> +		compatible = "pwm-beeper";
>>>> +		pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>;
>>> I have serious doubts that you run this code... if it does not even
>>> compile. Sorry, I cannot accept code that does not compile and was not
>>> tested.
>>>
>>> Please, test your DTS on top of current Linux tree, which would be one of:
>>> 1. Linus' master branch: v4.8-rc6,
>>> 2. one of my branches (for-next, next/dt etc),
>> When I sent those patches, I tested in "Add linux-next specific files for
>> 20160907"
>
> OK, good, but please tell me why kbuild reported that build error?
>

I agree with Krzysztof, it doesn't seem that you tested the exact version
that was posted. You will need the following change to make the DTS build
in latest linux-next:

diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index dd83689892ff..8559f891a740 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -14,6 +14,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/pwm/pwm.h>
 #include <dt-bindings/sound/samsung-i2s.h>
 #include "exynos4412-itop-scp-core.dtsi"

So please squash that change and resend.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

  reply	other threads:[~2016-09-16 18:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 21:58 [PATCH v6 0/3] Add a new board TOPEET iTOP for Exynos 4412 Randy Li
2016-09-07 21:58 ` Randy Li
2016-09-07 21:58 ` [PATCH v6 1/3] ARM: dts: Add TOPEET itop core board SCP package version Randy Li
2016-09-07 21:58   ` Randy Li
2016-09-07 21:58 ` [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board Randy Li
2016-09-07 21:58   ` Randy Li
2016-09-07 21:58   ` Randy Li
2016-09-08  0:44   ` kbuild test robot
2016-09-08  0:44     ` kbuild test robot
2016-09-08  0:44     ` kbuild test robot
     [not found]   ` <CGME20160916072303eucas1p2941ba2907605055f5ea5abb2e6891d77@eucas1p2.samsung.com>
2016-09-16  7:23     ` Krzysztof Kozlowski
2016-09-16  7:23       ` Krzysztof Kozlowski
2016-09-16  7:23       ` Krzysztof Kozlowski
2016-09-16 14:04       ` ayaka
2016-09-16 14:04         ` ayaka
2016-09-16 17:21         ` Krzysztof Kozlowski
2016-09-16 17:21           ` Krzysztof Kozlowski
2016-09-16 18:09           ` Javier Martinez Canillas [this message]
2016-09-16 18:09             ` Javier Martinez Canillas
2016-09-18  9:46             ` ayaka
2016-09-18  9:46               ` ayaka
2016-09-18  9:46               ` ayaka
2016-09-07 21:58 ` [PATCH v6 3/3] devicetree: bindings: Add vendor prefix for Topeet Randy Li
2016-09-07 21:58   ` Randy Li
2016-09-16 15:24   ` Rob Herring
2016-09-16 15:24     ` Rob Herring
2016-09-16 15:24     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e4335db-9004-bb7c-6dc1-e435e66b8126@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=ayaka@soulik.info \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.