* [PATCH] mm/vmscan: fix comment for current_may_throttle
@ 2022-04-14 12:02 Miaohe Lin
2022-04-14 20:43 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Miaohe Lin @ 2022-04-14 12:02 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, linmiaohe
Since commit 6d6435811c19 ("remove bdi_congested() and wb_congested() and
related functions"), there is no congested backing device check anymore.
Correct the comment accordingly.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/vmscan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index d4a7d2bd276d..6f96cf1eacb2 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2334,8 +2334,7 @@ static unsigned int move_pages_to_lru(struct lruvec *lruvec,
/*
* If a kernel thread (such as nfsd for loop-back mounts) services
* a backing device by writing to the page cache it sets PF_LOCAL_THROTTLE.
- * In that case we should only throttle if the backing device it is
- * writing to is congested. In other cases it is safe to throttle.
+ * In that case we should not throttle it otherwise it is safe to do so.
*/
static int current_may_throttle(void)
{
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/vmscan: fix comment for current_may_throttle
2022-04-14 12:02 [PATCH] mm/vmscan: fix comment for current_may_throttle Miaohe Lin
@ 2022-04-14 20:43 ` Andrew Morton
2022-04-15 1:39 ` Miaohe Lin
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2022-04-14 20:43 UTC (permalink / raw)
To: Miaohe Lin; +Cc: linux-mm, linux-kernel
On Thu, 14 Apr 2022 20:02:02 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> Since commit 6d6435811c19 ("remove bdi_congested() and wb_congested() and
> related functions"), there is no congested backing device check anymore.
> Correct the comment accordingly.
>
> ...
>
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2334,8 +2334,7 @@ static unsigned int move_pages_to_lru(struct lruvec *lruvec,
> /*
> * If a kernel thread (such as nfsd for loop-back mounts) services
> * a backing device by writing to the page cache it sets PF_LOCAL_THROTTLE.
> - * In that case we should only throttle if the backing device it is
> - * writing to is congested. In other cases it is safe to throttle.
> + * In that case we should not throttle it otherwise it is safe to do so.
> */
> static int current_may_throttle(void)
> {
That's a bit awkward to read. I tweaked it, and reflowed the comment
to 80 cols.
--- a/mm/vmscan.c~mm-vmscan-fix-comment-for-current_may_throttle-fix
+++ a/mm/vmscan.c
@@ -2332,9 +2332,9 @@ static unsigned int move_pages_to_lru(st
}
/*
- * If a kernel thread (such as nfsd for loop-back mounts) services
- * a backing device by writing to the page cache it sets PF_LOCAL_THROTTLE.
- * In that case we should not throttle it otherwise it is safe to do so.
+ * If a kernel thread (such as nfsd for loop-back mounts) services a backing
+ * device by writing to the page cache it sets PF_LOCAL_THROTTLE. In this case
+ * we should not throttle. Otherwise it is safe to do so.
*/
static int current_may_throttle(void)
{
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/vmscan: fix comment for current_may_throttle
2022-04-14 20:43 ` Andrew Morton
@ 2022-04-15 1:39 ` Miaohe Lin
0 siblings, 0 replies; 3+ messages in thread
From: Miaohe Lin @ 2022-04-15 1:39 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-kernel
On 2022/4/15 4:43, Andrew Morton wrote:
> On Thu, 14 Apr 2022 20:02:02 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
>
>> Since commit 6d6435811c19 ("remove bdi_congested() and wb_congested() and
>> related functions"), there is no congested backing device check anymore.
>> Correct the comment accordingly.
>>
>> ...
>>
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -2334,8 +2334,7 @@ static unsigned int move_pages_to_lru(struct lruvec *lruvec,
>> /*
>> * If a kernel thread (such as nfsd for loop-back mounts) services
>> * a backing device by writing to the page cache it sets PF_LOCAL_THROTTLE.
>> - * In that case we should only throttle if the backing device it is
>> - * writing to is congested. In other cases it is safe to throttle.
>> + * In that case we should not throttle it otherwise it is safe to do so.
>> */
>> static int current_may_throttle(void)
>> {
>
> That's a bit awkward to read. I tweaked it, and reflowed the comment
> to 80 cols.
>
> --- a/mm/vmscan.c~mm-vmscan-fix-comment-for-current_may_throttle-fix
> +++ a/mm/vmscan.c
> @@ -2332,9 +2332,9 @@ static unsigned int move_pages_to_lru(st
> }
>
> /*
> - * If a kernel thread (such as nfsd for loop-back mounts) services
> - * a backing device by writing to the page cache it sets PF_LOCAL_THROTTLE.
> - * In that case we should not throttle it otherwise it is safe to do so.
> + * If a kernel thread (such as nfsd for loop-back mounts) services a backing
> + * device by writing to the page cache it sets PF_LOCAL_THROTTLE. In this case
> + * we should not throttle. Otherwise it is safe to do so.
> */
> static int current_may_throttle(void)
> {
> _
Looks better. Many thanks for doing this! :)
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-15 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 12:02 [PATCH] mm/vmscan: fix comment for current_may_throttle Miaohe Lin
2022-04-14 20:43 ` Andrew Morton
2022-04-15 1:39 ` Miaohe Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.