All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: Ben Greear <greearb@candelatech.com>, Adrian Chadd <adrian@freebsd.org>
Cc: Simon Wunderlich <sw@simonwunderlich.de>,
	Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>,
	Benjamin Berg <benjamin@sipsolutions.net>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	Michal Kazior <michal.kazior@tieto.com>,
	Mathias Kretschmer <mathias.kretschmer@fit.fraunhofer.de>
Subject: Re: [PATCHv3 2/2] ath10k: Allow setting coverage class
Date: Tue, 17 Oct 2017 09:57:44 +0200	[thread overview]
Message-ID: <1e57ea22-3731-f310-9213-a4601e3f1899@dd-wrt.com> (raw)
In-Reply-To: <dd504311-fb1f-bad1-85dd-3cf1f4e9badf@candelatech.com>

Am 16.10.2017 um 21:55 schrieb Ben Greear:
> On 10/16/2017 12:12 PM, Adrian Chadd wrote:
>> hiya,
>>
>> I'd honestly rather see firmware changes for wave 2 chips, as I know
>> there's a lot more MAC changes messing up this stuff ..
>
> For wave-1, it appears to be quite simple to modify the firmware to set
> the ack-cts register to a specific value (and re-set it after scanning,
> etc).
>
> Is the wave-2 stuff that much different?  I've recently hooked in my
> CT firmware for wave-1 to support the driver's ack/cts calculations
> (but without needing all the manual register twiddling).  I could 
> probably
> do the same for 9984 if it mattered.  But, that still doesn't help stock
> driver/firmware users.

wave 2 has nothing todo with wave 1. the registers are different


>
> Thanks,
> Ben
>
>>
>>
>>
>> -adrian
>>
>>
>> On 16 October 2017 at 12:10, Sebastian Gottschall
>> <s.gottschall@dd-wrt.com> wrote:
>>> Am 16.10.2017 um 19:59 schrieb Adrian Chadd:
>>>>
>>>> On 16 October 2017 at 10:57, Ben Greear <greearb@candelatech.com> 
>>>> wrote:
>>>>>
>>>>> On 08/25/2016 06:25 AM, Benjamin Berg wrote:
>>>>>>
>>>>>> Unfortunately ath10k does not generally allow modifying the coverage
>>>>>> class
>>>>>> with the stock firmware and Qualcomm has so far refused to implement
>>>>>> this
>>>>>> feature so that it can be properly supported in ath10k. If we 
>>>>>> however
>>>>>> know
>>>>>> the registers that need to be modified for proper operation with a
>>>>>> higher
>>>>>> coverage class, then we can do these modifications from the driver.
>>>>>>
>>>>>> This patch implements this hack for first generation cards which are
>>>>>> based
>>>>>> on a core that is similar to ath9k. The registers are modified in 
>>>>>> place
>>>>>> and
>>>>>> need to be re-written every time the firmware sets them. To 
>>>>>> achieve this
>>>>>> the register status is verified after certain WMI events from the
>>>>>> firmware.
>>>>>>
>>>>>> The coverage class may not be modified temporarily right after 
>>>>>> the card
>>>>>> re-initializes the registers. This is for example the case during
>>>>>> scanning.
>>>>>>
>>>>>> Thanks to Sebastian Gottschall <s.gottschall@dd-wrt.com> for 
>>>>>> initially
>>>>>> working on a userspace support for this. This patch wouldn't have 
>>>>>> been
>>>>>> possible without this documentation.
>>>>>
>>>>>
>>>>> Hello,
>>>>>
>>>>> Do you happen to know the maximum distance that can work with this
>>>>> patch enabled?  The register value maximum seems to be 0x3FFF, but I
>>>>> am not sure of the units (nor how exactly that applies to distance).
>>>>
>>>> It's in MAC clocks still, right? So it depends on how fast the MAC
>>>> clock timer runs.
>>>>
>>>>
>>>>
>>>> -adrian
>>>
>>>
>>> if someone is interested i can provide a patch witch works as well 
>>> for 998x
>>> and 9984 and usually other newer chipsets too.
>>>
>>> but clock parameters need to be adjusted for these newer ones. the only
>>> problem is that its based on unoffical registers which arent 
>>> documented and
>>> the patch for the 99xx chipsets is very different from 988x
>>>
>>>
>>>
>>> -- 
>>> Mit freundlichen Grüssen / Regards
>>>
>>> Sebastian Gottschall / CTO
>>>
>>> NewMedia-NET GmbH - DD-WRT
>>> Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
>>>
>>> Registergericht: Amtsgericht Darmstadt, HRB 25473
>>> Geschäftsführer: Peter Steinhäuser, Christian Scheele
>>> http://www.dd-wrt.com
>>> email: s.gottschall@dd-wrt.com
>>> Tel.: +496251-582650 / Fax: +496251-5826565
>>>
>>
>> _______________________________________________
>> ath10k mailing list
>> ath10k@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/ath10k
>>
>
>

-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2017-10-17  7:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 13:25 [PATCHv3 0/2] ath10k: Allow setting coverage class Benjamin Berg
2016-08-25 13:25 ` [PATCHv3 1/2] ath10k: Rename hw_rx_desc_ops to hw_ops to use it for other purposes Benjamin Berg
2016-08-25 13:25 ` [PATCHv3 2/2] ath10k: Allow setting coverage class Benjamin Berg
2016-08-25 14:28   ` Ben Greear
2016-08-25 14:33     ` Benjamin Berg
2016-08-25 15:10       ` Sebastian Gottschall
2017-10-16 17:57   ` Ben Greear
2017-10-16 17:59     ` Adrian Chadd
2017-10-16 19:10       ` Sebastian Gottschall
2017-10-16 19:12         ` Adrian Chadd
2017-10-16 19:55           ` Ben Greear
2017-10-17  7:57             ` Sebastian Gottschall [this message]
2017-10-17  7:56           ` Sebastian Gottschall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e57ea22-3731-f310-9213-a4601e3f1899@dd-wrt.com \
    --to=s.gottschall@dd-wrt.com \
    --cc=adrian@freebsd.org \
    --cc=ath10k@lists.infradead.org \
    --cc=benjamin@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=mathias.kretschmer@fit.fraunhofer.de \
    --cc=michal.kazior@tieto.com \
    --cc=sw@simonwunderlich.de \
    --cc=vthiagar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.