* [bug report] media: venus: hfi,pm,firmware: Convert to block relative addressing
@ 2021-04-09 12:19 Dan Carpenter
2021-04-09 12:28 ` Bryan O'Donoghue
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-04-09 12:19 UTC (permalink / raw)
To: bryan.odonoghue; +Cc: linux-media
Hello Bryan O'Donoghue,
This is a semi-automatic email about new static checker warnings.
The patch ff2a7013b3e6: "media: venus: hfi,pm,firmware: Convert to
block relative addressing" from Apr 2, 2021, leads to the following
Smatch complaint:
drivers/media/platform/qcom/venus/hfi_venus.c:1100 venus_isr()
warn: variable dereferenced before check 'hdev' (see line 1097)
drivers/media/platform/qcom/venus/hfi_venus.c
1096 u32 status;
1097 void __iomem *cpu_cs_base = hdev->core->cpu_cs_base;
^^^^^^^^^^
1098 void __iomem *wrapper_base = hdev->core->wrapper_base;
^^^^^^^^^^
The patch adds new unchecked dereferences before ...
1099
1100 if (!hdev)
^^^^^
... this check.
1101 return IRQ_NONE;
1102
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] media: venus: hfi,pm,firmware: Convert to block relative addressing
2021-04-09 12:19 [bug report] media: venus: hfi,pm,firmware: Convert to block relative addressing Dan Carpenter
@ 2021-04-09 12:28 ` Bryan O'Donoghue
0 siblings, 0 replies; 2+ messages in thread
From: Bryan O'Donoghue @ 2021-04-09 12:28 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-media
On 09/04/2021 13:19, Dan Carpenter wrote:
> Hello Bryan O'Donoghue,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch ff2a7013b3e6: "media: venus: hfi,pm,firmware: Convert to
> block relative addressing" from Apr 2, 2021, leads to the following
> Smatch complaint:
>
> drivers/media/platform/qcom/venus/hfi_venus.c:1100 venus_isr()
> warn: variable dereferenced before check 'hdev' (see line 1097)
>
> drivers/media/platform/qcom/venus/hfi_venus.c
> 1096 u32 status;
> 1097 void __iomem *cpu_cs_base = hdev->core->cpu_cs_base;
> ^^^^^^^^^^
> 1098 void __iomem *wrapper_base = hdev->core->wrapper_base;
> ^^^^^^^^^^
> The patch adds new unchecked dereferences before ...
>
> 1099
> 1100 if (!hdev)
> ^^^^^
> ... this check.
>
> 1101 return IRQ_NONE;
> 1102
>
> regards,
> dan carpenter
>
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2540720.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 12:19 [bug report] media: venus: hfi,pm,firmware: Convert to block relative addressing Dan Carpenter
2021-04-09 12:28 ` Bryan O'Donoghue
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.