Re: [PATCH v2 2/2] Add dp PHY dt-bindings

From: "LIANKUN YANG (杨连坤)" <Liankun.Yang@mediatek.com>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"Mac Shen (沈俊)" <Mac.Shen@mediatek.com>,
	"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"krzk@kernel.org" <krzk@kernel.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"kishon@kernel.org" <kishon@kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] Add dp PHY dt-bindings
Date: Tue, 14 May 2024 04:43:03 +0000	[thread overview]
Message-ID: <1eb69265ae15323f3304f1c4b4fb0be5b13f1d42.camel@mediatek.com> (raw)
In-Reply-To: <4a147f2d-71c8-4acf-aab4-9d761b81bc73@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2394 bytes --]

On Mon, 2024-05-13 at 16:20 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 13/05/2024 16:17, Krzysztof Kozlowski wrote:
> >>> dp.yaml
> >>>> @@ -0,0 +1,45 @@
> >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>>> +%YAML 1.2
> >>>> +---
> >>>> +$id: 
> >>> 
> http://devicetree.org/schemas/display/mediatek/mediatek,phy-dp.yaml#
> >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>>> +
> >>>> +title: MediaTek Display Port Controller
> >>>> +
> >>>> +maintainers:
> >>>> +  - Mac shen <mac.shen@mediatek.com>
> >>>> +  - Liankun yang <Liankun.yang@mediatek.com>
> >>>> +
> >>>> +description: |
> >>>> +  Special settings need to be configured by MediaTek DP based
> on
> >>> the actual
> >>>> +  hardware situation. For example, when using a certain brand's
> >>> docking
> >>>> +  station for display projection, garbage may appear. Adjusting
> >>> the specific
> >>>> +  ssc value can resolve this issue.
> >>>> +
> >>>> +properties:
> >>>> +  status: disabled
> >>>
> >>> I think you nicely shocked Rob already.
> >>>
> >>> Please reach internally to Mediatek or collaborating companies to
> get
> >>> basic training and instructions how to write patches and
> bindings.
> >>>
> >>> Otherwise it is waste of our time. Mediatek is not a small
> company so
> >>> there is no excuse in sending such poor quality patches, which
> would
> >>> be
> >>> EASILY spotted by the MOST BASIC review.
> >>>
> >>> Best regards,
> >>> Krzysztof
> >>>
> >>
> >> I used scripts/checkpatch.pl and fix reported error and warnings.
> >> I am resumbmitting bindings by the MOST BASIC review.
> > 
> > No, please wait. Who did the basic review of your patch? Who from
> > Mediatek? Upstream is not a workhorse to use instead of your
> resources
> > for the absolute basic stuff... This feels such exploiting.
> > 
> 
> After reading AngeloGioacchino's response, it looks even worse...
> This
> was never tested...
> 
> So not only exploiting but also feels like wasting our time.
> 
> Best regards,
> Krzysztof
> 

Sorry,I guess I didn't make myself clear.
I am resumbmitting bindings after the MOST BASIC internal review.
Thank you for your comment.

Best Regards,
Liankun Yang

[-- Attachment #2: Type: text/html, Size: 5456 bytes --]