From: neil.armstrong@linaro.org
To: Yang Li <yang.lee@linux.alibaba.com>, airlied@gmail.com
Cc: martin.blumenstingl@googlemail.com, khilman@baylibre.com,
Abaci Robot <abaci@linux.alibaba.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH -next] drm/meson: Remove unneeded semicolon
Date: Fri, 2 Jun 2023 11:16:17 +0200 [thread overview]
Message-ID: <1ed84d1f-d999-f0f2-bd84-d56f46efa384@linaro.org> (raw)
In-Reply-To: <20230602091416.107850-1-yang.lee@linux.alibaba.com>
On 02/06/2023 11:14, Yang Li wrote:
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5392
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> index dd505ac37976..57447abf1a29 100644
> --- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> @@ -114,7 +114,7 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
> case MIPI_DSI_FMT_RGB666_PACKED:
> case MIPI_DSI_FMT_RGB565:
> return -EINVAL;
> - };
> + }
>
> /* Configure color format for DPI register */
> writel_relaxed(FIELD_PREP(MIPI_DSI_TOP_DPI_COLOR_MODE, dpi_data_format) |
> @@ -228,7 +228,7 @@ static int meson_dw_mipi_dsi_host_attach(void *priv_data,
> case MIPI_DSI_FMT_RGB565:
> dev_err(mipi_dsi->dev, "invalid pixel format %d\n", device->format);
> return -EINVAL;
> - };
> + }
>
> ret = phy_init(mipi_dsi->phy);
> if (ret)
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: neil.armstrong@linaro.org
To: Yang Li <yang.lee@linux.alibaba.com>, airlied@gmail.com
Cc: daniel@ffwll.ch, khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] drm/meson: Remove unneeded semicolon
Date: Fri, 2 Jun 2023 11:16:17 +0200 [thread overview]
Message-ID: <1ed84d1f-d999-f0f2-bd84-d56f46efa384@linaro.org> (raw)
In-Reply-To: <20230602091416.107850-1-yang.lee@linux.alibaba.com>
On 02/06/2023 11:14, Yang Li wrote:
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5392
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> index dd505ac37976..57447abf1a29 100644
> --- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> @@ -114,7 +114,7 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
> case MIPI_DSI_FMT_RGB666_PACKED:
> case MIPI_DSI_FMT_RGB565:
> return -EINVAL;
> - };
> + }
>
> /* Configure color format for DPI register */
> writel_relaxed(FIELD_PREP(MIPI_DSI_TOP_DPI_COLOR_MODE, dpi_data_format) |
> @@ -228,7 +228,7 @@ static int meson_dw_mipi_dsi_host_attach(void *priv_data,
> case MIPI_DSI_FMT_RGB565:
> dev_err(mipi_dsi->dev, "invalid pixel format %d\n", device->format);
> return -EINVAL;
> - };
> + }
>
> ret = phy_init(mipi_dsi->phy);
> if (ret)
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: neil.armstrong@linaro.org
To: Yang Li <yang.lee@linux.alibaba.com>, airlied@gmail.com
Cc: daniel@ffwll.ch, khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] drm/meson: Remove unneeded semicolon
Date: Fri, 2 Jun 2023 11:16:17 +0200 [thread overview]
Message-ID: <1ed84d1f-d999-f0f2-bd84-d56f46efa384@linaro.org> (raw)
In-Reply-To: <20230602091416.107850-1-yang.lee@linux.alibaba.com>
On 02/06/2023 11:14, Yang Li wrote:
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5392
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> index dd505ac37976..57447abf1a29 100644
> --- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> @@ -114,7 +114,7 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
> case MIPI_DSI_FMT_RGB666_PACKED:
> case MIPI_DSI_FMT_RGB565:
> return -EINVAL;
> - };
> + }
>
> /* Configure color format for DPI register */
> writel_relaxed(FIELD_PREP(MIPI_DSI_TOP_DPI_COLOR_MODE, dpi_data_format) |
> @@ -228,7 +228,7 @@ static int meson_dw_mipi_dsi_host_attach(void *priv_data,
> case MIPI_DSI_FMT_RGB565:
> dev_err(mipi_dsi->dev, "invalid pixel format %d\n", device->format);
> return -EINVAL;
> - };
> + }
>
> ret = phy_init(mipi_dsi->phy);
> if (ret)
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: neil.armstrong@linaro.org
To: Yang Li <yang.lee@linux.alibaba.com>, airlied@gmail.com
Cc: daniel@ffwll.ch, khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] drm/meson: Remove unneeded semicolon
Date: Fri, 2 Jun 2023 11:16:17 +0200 [thread overview]
Message-ID: <1ed84d1f-d999-f0f2-bd84-d56f46efa384@linaro.org> (raw)
In-Reply-To: <20230602091416.107850-1-yang.lee@linux.alibaba.com>
On 02/06/2023 11:14, Yang Li wrote:
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5392
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> index dd505ac37976..57447abf1a29 100644
> --- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> @@ -114,7 +114,7 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
> case MIPI_DSI_FMT_RGB666_PACKED:
> case MIPI_DSI_FMT_RGB565:
> return -EINVAL;
> - };
> + }
>
> /* Configure color format for DPI register */
> writel_relaxed(FIELD_PREP(MIPI_DSI_TOP_DPI_COLOR_MODE, dpi_data_format) |
> @@ -228,7 +228,7 @@ static int meson_dw_mipi_dsi_host_attach(void *priv_data,
> case MIPI_DSI_FMT_RGB565:
> dev_err(mipi_dsi->dev, "invalid pixel format %d\n", device->format);
> return -EINVAL;
> - };
> + }
>
> ret = phy_init(mipi_dsi->phy);
> if (ret)
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-06-02 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 9:14 [PATCH -next] drm/meson: Remove unneeded semicolon Yang Li
2023-06-02 9:14 ` Yang Li
2023-06-02 9:14 ` Yang Li
2023-06-02 9:14 ` Yang Li
2023-06-02 9:16 ` neil.armstrong [this message]
2023-06-02 9:16 ` neil.armstrong
2023-06-02 9:16 ` neil.armstrong
2023-06-02 9:16 ` neil.armstrong
2023-06-02 13:49 ` Neil Armstrong
2023-06-02 13:49 ` Neil Armstrong
2023-06-02 13:49 ` Neil Armstrong
2023-06-02 13:49 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ed84d1f-d999-f0f2-bd84-d56f46efa384@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=abaci@linux.alibaba.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.