* [PATCH] x86/xen: Improve failed hypercall debugging
@ 2017-05-02 17:59 Andy Lutomirski
2017-05-02 18:28 ` Boris Ostrovsky
2017-05-02 18:28 ` Boris Ostrovsky
0 siblings, 2 replies; 4+ messages in thread
From: Andy Lutomirski @ 2017-05-02 17:59 UTC (permalink / raw)
To: xen-devel
Cc: linux-kernel, x86, Andy Lutomirski, Juergen Gross,
Konrad Rzeszutek Wilk, Boris Ostrovsky
When fiddling with xen_exit_mmap(), I noticed that failed multicall
debugging doesn't work if the multicall is just one call. Fix it.
Cc: Juergen Gross <jgross@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
arch/x86/xen/multicalls.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
index ea54a08d8301..b6b3f024d342 100644
--- a/arch/x86/xen/multicalls.c
+++ b/arch/x86/xen/multicalls.c
@@ -96,23 +96,23 @@ void xen_mc_flush(void)
for (i = 0; i < b->mcidx; i++)
if (b->entries[i].result < 0)
ret++;
+ }
#if MC_DEBUG
- if (ret) {
- printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
- ret, smp_processor_id());
- dump_stack();
- for (i = 0; i < b->mcidx; i++) {
- printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n",
- i+1, b->mcidx,
- b->debug[i].op,
- b->debug[i].args[0],
- b->entries[i].result,
- b->caller[i]);
- }
+ if (ret) {
+ printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
+ ret, smp_processor_id());
+ dump_stack();
+ for (i = 0; i < b->mcidx; i++) {
+ printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n",
+ i+1, b->mcidx,
+ b->debug[i].op,
+ b->debug[i].args[0],
+ b->entries[i].result,
+ b->caller[i]);
}
-#endif
}
+#endif
b->mcidx = 0;
b->argidx = 0;
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/xen: Improve failed hypercall debugging
2017-05-02 17:59 [PATCH] x86/xen: Improve failed hypercall debugging Andy Lutomirski
@ 2017-05-02 18:28 ` Boris Ostrovsky
2017-05-02 18:28 ` Boris Ostrovsky
1 sibling, 0 replies; 4+ messages in thread
From: Boris Ostrovsky @ 2017-05-02 18:28 UTC (permalink / raw)
To: Andy Lutomirski, xen-devel
Cc: linux-kernel, x86, Juergen Gross, Konrad Rzeszutek Wilk
On 05/02/2017 01:59 PM, Andy Lutomirski wrote:
> When fiddling with xen_exit_mmap(), I noticed that failed multicall
> debugging doesn't work if the multicall is just one call. Fix it.
That wouldn't be a multicall though, we'll end up making the desired
hypercall directly.
Besides, b->debug[] is not initialized in this case.
-boris
>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> arch/x86/xen/multicalls.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
> index ea54a08d8301..b6b3f024d342 100644
> --- a/arch/x86/xen/multicalls.c
> +++ b/arch/x86/xen/multicalls.c
> @@ -96,23 +96,23 @@ void xen_mc_flush(void)
> for (i = 0; i < b->mcidx; i++)
> if (b->entries[i].result < 0)
> ret++;
> + }
>
> #if MC_DEBUG
> - if (ret) {
> - printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> - ret, smp_processor_id());
> - dump_stack();
> - for (i = 0; i < b->mcidx; i++) {
> - printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n",
> - i+1, b->mcidx,
> - b->debug[i].op,
> - b->debug[i].args[0],
> - b->entries[i].result,
> - b->caller[i]);
> - }
> + if (ret) {
> + printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> + ret, smp_processor_id());
> + dump_stack();
> + for (i = 0; i < b->mcidx; i++) {
> + printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n",
> + i+1, b->mcidx,
> + b->debug[i].op,
> + b->debug[i].args[0],
> + b->entries[i].result,
> + b->caller[i]);
> }
> -#endif
> }
> +#endif
>
> b->mcidx = 0;
> b->argidx = 0;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/xen: Improve failed hypercall debugging
2017-05-02 17:59 [PATCH] x86/xen: Improve failed hypercall debugging Andy Lutomirski
2017-05-02 18:28 ` Boris Ostrovsky
@ 2017-05-02 18:28 ` Boris Ostrovsky
1 sibling, 0 replies; 4+ messages in thread
From: Boris Ostrovsky @ 2017-05-02 18:28 UTC (permalink / raw)
To: Andy Lutomirski, xen-devel; +Cc: Juergen Gross, x86, linux-kernel
On 05/02/2017 01:59 PM, Andy Lutomirski wrote:
> When fiddling with xen_exit_mmap(), I noticed that failed multicall
> debugging doesn't work if the multicall is just one call. Fix it.
That wouldn't be a multicall though, we'll end up making the desired
hypercall directly.
Besides, b->debug[] is not initialized in this case.
-boris
>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> arch/x86/xen/multicalls.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
> index ea54a08d8301..b6b3f024d342 100644
> --- a/arch/x86/xen/multicalls.c
> +++ b/arch/x86/xen/multicalls.c
> @@ -96,23 +96,23 @@ void xen_mc_flush(void)
> for (i = 0; i < b->mcidx; i++)
> if (b->entries[i].result < 0)
> ret++;
> + }
>
> #if MC_DEBUG
> - if (ret) {
> - printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> - ret, smp_processor_id());
> - dump_stack();
> - for (i = 0; i < b->mcidx; i++) {
> - printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n",
> - i+1, b->mcidx,
> - b->debug[i].op,
> - b->debug[i].args[0],
> - b->entries[i].result,
> - b->caller[i]);
> - }
> + if (ret) {
> + printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> + ret, smp_processor_id());
> + dump_stack();
> + for (i = 0; i < b->mcidx; i++) {
> + printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n",
> + i+1, b->mcidx,
> + b->debug[i].op,
> + b->debug[i].args[0],
> + b->entries[i].result,
> + b->caller[i]);
> }
> -#endif
> }
> +#endif
>
> b->mcidx = 0;
> b->argidx = 0;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] x86/xen: Improve failed hypercall debugging
@ 2017-05-02 17:59 Andy Lutomirski
0 siblings, 0 replies; 4+ messages in thread
From: Andy Lutomirski @ 2017-05-02 17:59 UTC (permalink / raw)
To: xen-devel
Cc: Juergen Gross, x86, linux-kernel, Andy Lutomirski, Boris Ostrovsky
When fiddling with xen_exit_mmap(), I noticed that failed multicall
debugging doesn't work if the multicall is just one call. Fix it.
Cc: Juergen Gross <jgross@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
arch/x86/xen/multicalls.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
index ea54a08d8301..b6b3f024d342 100644
--- a/arch/x86/xen/multicalls.c
+++ b/arch/x86/xen/multicalls.c
@@ -96,23 +96,23 @@ void xen_mc_flush(void)
for (i = 0; i < b->mcidx; i++)
if (b->entries[i].result < 0)
ret++;
+ }
#if MC_DEBUG
- if (ret) {
- printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
- ret, smp_processor_id());
- dump_stack();
- for (i = 0; i < b->mcidx; i++) {
- printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n",
- i+1, b->mcidx,
- b->debug[i].op,
- b->debug[i].args[0],
- b->entries[i].result,
- b->caller[i]);
- }
+ if (ret) {
+ printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
+ ret, smp_processor_id());
+ dump_stack();
+ for (i = 0; i < b->mcidx; i++) {
+ printk(KERN_DEBUG " call %2d/%d: op=%lu arg=[%lx] result=%ld\t%pF\n",
+ i+1, b->mcidx,
+ b->debug[i].op,
+ b->debug[i].args[0],
+ b->entries[i].result,
+ b->caller[i]);
}
-#endif
}
+#endif
b->mcidx = 0;
b->argidx = 0;
--
2.9.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-02 18:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 17:59 [PATCH] x86/xen: Improve failed hypercall debugging Andy Lutomirski
2017-05-02 18:28 ` Boris Ostrovsky
2017-05-02 18:28 ` Boris Ostrovsky
-- strict thread matches above, loose matches on Subject: below --
2017-05-02 17:59 Andy Lutomirski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.