From: Lucas Stach <l.stach@pengutronix.de> To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-arm-kernel@lists.infradead.org Cc: Fabio Estevam <festevam@gmail.com>, Chris Healy <cphealy@gmail.com>, Shawn Guo <shawnguo@kernel.org>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Date: Tue, 22 Oct 2019 18:04:25 +0200 [thread overview] Message-ID: <1ef138bcb511bdfeff798edf93b9aa8bd06d6e22.camel@pengutronix.de> (raw) In-Reply-To: <20191022040500.18548-2-andrew.smirnov@gmail.com> Am Montag, den 21.10.2019, 21:04 -0700 schrieb Andrey Smirnov: > According to Documentation/devicetree/bindings/iio/accel/mma8452.txt, > the correct interrupt-names are "INT1" and "INT2", so fix them > accordingly. > > While at it, modify the node to only specify "INT2" since providing > two interrupts is not necessary or useful (the driver will only use > one). > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > [andrew.smirnov@gmail.com modified the patch to drop INT1] > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org, > Cc: linux-kernel@vger.kernel.org > --- > > Original patch from Fabio can be seen here: > > https://lore.kernel.org/linux-arm-kernel/20191010125300.2822-1-festevam@gmail.com/ > > arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > index 8d46f7b2722b..a8c86e621b49 100644 > --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > @@ -358,8 +358,8 @@ > compatible = "fsl,mma8451"; > reg = <0x1c>; > interrupt-parent = <&gpio1>; > - interrupt-names = "int1", "int2"; > - interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names = "INT2"; > + interrupts = <20 IRQ_TYPE_LEVEL_LOW>; > }; > > hpa2: amp@60 { > @@ -849,7 +849,6 @@ > &iomuxc { > pinctrl_accel: accelgrp { > fsl,pins = < > - MX6QDL_PAD_SD1_CMD__GPIO1_IO18 0x4001b000 > MX6QDL_PAD_SD1_CLK__GPIO1_IO20 0x4001b000 > >; > };
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-arm-kernel@lists.infradead.org Cc: Shawn Guo <shawnguo@kernel.org>, Fabio Estevam <festevam@gmail.com>, linux-kernel@vger.kernel.org, Chris Healy <cphealy@gmail.com> Subject: Re: [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Date: Tue, 22 Oct 2019 18:04:25 +0200 [thread overview] Message-ID: <1ef138bcb511bdfeff798edf93b9aa8bd06d6e22.camel@pengutronix.de> (raw) In-Reply-To: <20191022040500.18548-2-andrew.smirnov@gmail.com> Am Montag, den 21.10.2019, 21:04 -0700 schrieb Andrey Smirnov: > According to Documentation/devicetree/bindings/iio/accel/mma8452.txt, > the correct interrupt-names are "INT1" and "INT2", so fix them > accordingly. > > While at it, modify the node to only specify "INT2" since providing > two interrupts is not necessary or useful (the driver will only use > one). > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > [andrew.smirnov@gmail.com modified the patch to drop INT1] > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org, > Cc: linux-kernel@vger.kernel.org > --- > > Original patch from Fabio can be seen here: > > https://lore.kernel.org/linux-arm-kernel/20191010125300.2822-1-festevam@gmail.com/ > > arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > index 8d46f7b2722b..a8c86e621b49 100644 > --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > @@ -358,8 +358,8 @@ > compatible = "fsl,mma8451"; > reg = <0x1c>; > interrupt-parent = <&gpio1>; > - interrupt-names = "int1", "int2"; > - interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names = "INT2"; > + interrupts = <20 IRQ_TYPE_LEVEL_LOW>; > }; > > hpa2: amp@60 { > @@ -849,7 +849,6 @@ > &iomuxc { > pinctrl_accel: accelgrp { > fsl,pins = < > - MX6QDL_PAD_SD1_CMD__GPIO1_IO18 0x4001b000 > MX6QDL_PAD_SD1_CLK__GPIO1_IO20 0x4001b000 > >; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-22 16:05 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-22 4:04 [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Andrey Smirnov 2019-10-22 4:04 ` Andrey Smirnov 2019-10-22 4:04 ` [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names Andrey Smirnov 2019-10-22 4:04 ` Andrey Smirnov 2019-10-22 16:04 ` Lucas Stach [this message] 2019-10-22 16:04 ` Lucas Stach 2019-10-28 6:20 ` Shawn Guo 2019-10-28 6:20 ` Shawn Guo 2019-10-22 4:05 ` [PATCH 3/3] ARM: dts: imx6qdl-zii-rdu2: Specify supplies for accelerometer Andrey Smirnov 2019-10-22 4:05 ` Andrey Smirnov 2019-10-22 16:03 ` Lucas Stach 2019-10-22 16:03 ` Lucas Stach 2019-10-28 6:20 ` Shawn Guo 2019-10-28 6:20 ` Shawn Guo 2019-10-22 16:01 ` [PATCH 1/3] ARM: dts: imx6qdl-zii-rdu2: Drop GPIO_ACTIVE_LOW form reg_5p0v_user_usb Lucas Stach 2019-10-22 16:01 ` Lucas Stach
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1ef138bcb511bdfeff798edf93b9aa8bd06d6e22.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=andrew.smirnov@gmail.com \ --cc=cphealy@gmail.com \ --cc=festevam@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.