All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Morel <pmorel@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, thuth@redhat.com, kvm@vger.kernel.org,
	imbrenda@linux.ibm.com, david@redhat.com, nsg@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v9 1/2] s390x: topology: Check the Perform Topology Function
Date: Mon, 22 May 2023 17:17:11 +0200	[thread overview]
Message-ID: <1ef42084-6ccf-359c-13bb-595069573e15@linux.ibm.com> (raw)
In-Reply-To: <168475411852.27238.14110102220289082947@t14-nrb>


On 5/22/23 13:15, Nico Boehr wrote:
> Quoting Pierre Morel (2023-05-19 13:22:35)
> [...]
>> diff --git a/s390x/topology.c b/s390x/topology.c
>> new file mode 100644
>> index 0000000..2acede0
>> --- /dev/null
>> +++ b/s390x/topology.c
> [...]
>> +static void check_privilege(int fc)
>> +{
>> +       unsigned long rc;
>> +
>> +       report_prefix_push("Privilege");
>> +       report_info("function code %d", fc);
> report() messages should be unique.
>
> Can you please make this a
>    report_prefix_pushf("Privileged fc %d", fc);
> and get rid of the report_info()?
>
> With this change:
>
> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>


Yes, thanks

Pierre


  reply	other threads:[~2023-05-22 15:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 11:22 [kvm-unit-tests PATCH v9 0/2] S390x: CPU Topology Information Pierre Morel
2023-05-19 11:22 ` [kvm-unit-tests PATCH v9 1/2] s390x: topology: Check the Perform Topology Function Pierre Morel
2023-05-22 11:15   ` Nico Boehr
2023-05-22 15:17     ` Pierre Morel [this message]
2023-05-19 11:22 ` [kvm-unit-tests PATCH v9 2/2] s390x: topology: Checking Configuration Topology Information Pierre Morel
2023-06-01  9:38   ` Janosch Frank
2023-06-01 17:41     ` Pierre Morel
2023-06-02  7:50       ` Janosch Frank
2023-06-02  8:35     ` Nico Boehr
2023-06-02  9:03       ` Janosch Frank
2023-06-02  9:20       ` Thomas Huth
2023-06-02 10:02         ` Pierre Morel
2023-06-02 10:01       ` Pierre Morel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ef42084-6ccf-359c-13bb-595069573e15@linux.ibm.com \
    --to=pmorel@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=nsg@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.