All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm, memcg: fix build error around the usage of kmem_caches
@ 2020-02-05 17:03 ` Yafang Shao
  0 siblings, 0 replies; 6+ messages in thread
From: Yafang Shao @ 2020-02-05 17:03 UTC (permalink / raw)
  To: tj, vdavydov.dev
  Cc: hannes, mhocko, akpm, cl, penberg, rientjes, iamjoonsoo.kim,
	cgroups, linux-mm, Yafang Shao

When I manually set default n to MEMCG_KMEM in init/Kconfig, bellow error
occurs,

mm/slab_common.c: In function 'memcg_slab_start':
mm/slab_common.c:1530:30: error: 'struct mem_cgroup' has no member named
'kmem_caches'
  return seq_list_start(&memcg->kmem_caches, *pos);
                              ^
mm/slab_common.c: In function 'memcg_slab_next':
mm/slab_common.c:1537:32: error: 'struct mem_cgroup' has no member named
'kmem_caches'
  return seq_list_next(p, &memcg->kmem_caches, pos);
                                ^
mm/slab_common.c: In function 'memcg_slab_show':
mm/slab_common.c:1551:16: error: 'struct mem_cgroup' has no member named
'kmem_caches'
  if (p == memcg->kmem_caches.next)
                ^
  CC      arch/x86/xen/smp.o
mm/slab_common.c: In function 'memcg_slab_start':
mm/slab_common.c:1531:1: warning: control reaches end of non-void function
[-Wreturn-type]
 }
 ^
mm/slab_common.c: In function 'memcg_slab_next':
mm/slab_common.c:1538:1: warning: control reaches end of non-void function
[-Wreturn-type]
 }
 ^

That's because kmem_caches is defined only when CONFIG_MEMCG_KMEM is set,
while memcg_slab_start() will use it no matter CONFIG_MEMCG_KMEM is defined
or not.

By the way, the reason I mannuly undefined CONFIG_MEMCG_KMEM is to verify
whether my some other code change is still stable when CONFIG_MEMCG_KMEM is
not set. Unfortunately, the existing code has been already unstable since
v4.11.

Fixes: bc2791f857e1 ("slab: link memcg kmem_caches on their associated memory cgroup")
Cc: Tejun Heo <tj@kernel.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
 mm/memcontrol.c  | 2 ++
 mm/slab_common.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 6f6dc8712e39..43f0125b45bb 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4723,6 +4723,7 @@ static struct cftype mem_cgroup_legacy_files[] = {
 		.write = mem_cgroup_reset,
 		.read_u64 = mem_cgroup_read_u64,
 	},
+#ifdef CONFIG_MEMCG_KMEM
 #if defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)
 	{
 		.name = "kmem.slabinfo",
@@ -4731,6 +4732,7 @@ static struct cftype mem_cgroup_legacy_files[] = {
 		.seq_stop = memcg_slab_stop,
 		.seq_show = memcg_slab_show,
 	},
+#endif
 #endif
 	{
 		.name = "kmem.tcp.limit_in_bytes",
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 1907cb2903c7..5282f881d2f5 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -1521,7 +1521,7 @@ void dump_unreclaimable_slab(void)
 	mutex_unlock(&slab_mutex);
 }
 
-#if defined(CONFIG_MEMCG)
+#if defined(CONFIG_MEMCG_KMEM)
 void *memcg_slab_start(struct seq_file *m, loff_t *pos)
 {
 	struct mem_cgroup *memcg = mem_cgroup_from_seq(m);
-- 
2.14.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] mm, memcg: fix build error around the usage of kmem_caches
@ 2020-02-05 17:03 ` Yafang Shao
  0 siblings, 0 replies; 6+ messages in thread
From: Yafang Shao @ 2020-02-05 17:03 UTC (permalink / raw)
  To: tj-DgEjT+Ai2ygdnm+yROfE0A, vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w
  Cc: hannes-druUgvl0LCNAfugRpC6u6w, mhocko-DgEjT+Ai2ygdnm+yROfE0A,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b, cl-vYTEC60ixJUAvxtiuMwx3w,
	penberg-DgEjT+Ai2ygdnm+yROfE0A, rientjes-hpIqsD4AKlfQT0dZR+AlfA,
	iamjoonsoo.kim-Hm3cg6mZ9cc, cgroups-u79uwXL29TY76Z2rM5mHXA,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg, Yafang Shao

When I manually set default n to MEMCG_KMEM in init/Kconfig, bellow error
occurs,

mm/slab_common.c: In function 'memcg_slab_start':
mm/slab_common.c:1530:30: error: 'struct mem_cgroup' has no member named
'kmem_caches'
  return seq_list_start(&memcg->kmem_caches, *pos);
                              ^
mm/slab_common.c: In function 'memcg_slab_next':
mm/slab_common.c:1537:32: error: 'struct mem_cgroup' has no member named
'kmem_caches'
  return seq_list_next(p, &memcg->kmem_caches, pos);
                                ^
mm/slab_common.c: In function 'memcg_slab_show':
mm/slab_common.c:1551:16: error: 'struct mem_cgroup' has no member named
'kmem_caches'
  if (p == memcg->kmem_caches.next)
                ^
  CC      arch/x86/xen/smp.o
mm/slab_common.c: In function 'memcg_slab_start':
mm/slab_common.c:1531:1: warning: control reaches end of non-void function
[-Wreturn-type]
 }
 ^
mm/slab_common.c: In function 'memcg_slab_next':
mm/slab_common.c:1538:1: warning: control reaches end of non-void function
[-Wreturn-type]
 }
 ^

That's because kmem_caches is defined only when CONFIG_MEMCG_KMEM is set,
while memcg_slab_start() will use it no matter CONFIG_MEMCG_KMEM is defined
or not.

By the way, the reason I mannuly undefined CONFIG_MEMCG_KMEM is to verify
whether my some other code change is still stable when CONFIG_MEMCG_KMEM is
not set. Unfortunately, the existing code has been already unstable since
v4.11.

Fixes: bc2791f857e1 ("slab: link memcg kmem_caches on their associated memory cgroup")
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Vladimir Davydov <vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Yafang Shao <laoar.shao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 mm/memcontrol.c  | 2 ++
 mm/slab_common.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 6f6dc8712e39..43f0125b45bb 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4723,6 +4723,7 @@ static struct cftype mem_cgroup_legacy_files[] = {
 		.write = mem_cgroup_reset,
 		.read_u64 = mem_cgroup_read_u64,
 	},
+#ifdef CONFIG_MEMCG_KMEM
 #if defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)
 	{
 		.name = "kmem.slabinfo",
@@ -4731,6 +4732,7 @@ static struct cftype mem_cgroup_legacy_files[] = {
 		.seq_stop = memcg_slab_stop,
 		.seq_show = memcg_slab_show,
 	},
+#endif
 #endif
 	{
 		.name = "kmem.tcp.limit_in_bytes",
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 1907cb2903c7..5282f881d2f5 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -1521,7 +1521,7 @@ void dump_unreclaimable_slab(void)
 	mutex_unlock(&slab_mutex);
 }
 
-#if defined(CONFIG_MEMCG)
+#if defined(CONFIG_MEMCG_KMEM)
 void *memcg_slab_start(struct seq_file *m, loff_t *pos)
 {
 	struct mem_cgroup *memcg = mem_cgroup_from_seq(m);
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] mm, memcg: fix build error around the usage of kmem_caches
@ 2020-02-05 17:18   ` David Hildenbrand
  0 siblings, 0 replies; 6+ messages in thread
From: David Hildenbrand @ 2020-02-05 17:18 UTC (permalink / raw)
  To: Yafang Shao, tj, vdavydov.dev
  Cc: hannes, mhocko, akpm, cl, penberg, rientjes, iamjoonsoo.kim,
	cgroups, linux-mm

On 05.02.20 18:03, Yafang Shao wrote:
> When I manually set default n to MEMCG_KMEM in init/Kconfig, bellow error
> occurs,
> 
> mm/slab_common.c: In function 'memcg_slab_start':
> mm/slab_common.c:1530:30: error: 'struct mem_cgroup' has no member named
> 'kmem_caches'
>   return seq_list_start(&memcg->kmem_caches, *pos);
>                               ^
> mm/slab_common.c: In function 'memcg_slab_next':
> mm/slab_common.c:1537:32: error: 'struct mem_cgroup' has no member named
> 'kmem_caches'
>   return seq_list_next(p, &memcg->kmem_caches, pos);
>                                 ^
> mm/slab_common.c: In function 'memcg_slab_show':
> mm/slab_common.c:1551:16: error: 'struct mem_cgroup' has no member named
> 'kmem_caches'
>   if (p == memcg->kmem_caches.next)
>                 ^
>   CC      arch/x86/xen/smp.o
> mm/slab_common.c: In function 'memcg_slab_start':
> mm/slab_common.c:1531:1: warning: control reaches end of non-void function
> [-Wreturn-type]
>  }
>  ^
> mm/slab_common.c: In function 'memcg_slab_next':
> mm/slab_common.c:1538:1: warning: control reaches end of non-void function
> [-Wreturn-type]
>  }
>  ^
> 
> That's because kmem_caches is defined only when CONFIG_MEMCG_KMEM is set,
> while memcg_slab_start() will use it no matter CONFIG_MEMCG_KMEM is defined
> or not.
> 
> By the way, the reason I mannuly undefined CONFIG_MEMCG_KMEM is to verify
> whether my some other code change is still stable when CONFIG_MEMCG_KMEM is
> not set. Unfortunately, the existing code has been already unstable since
> v4.11.
> 
> Fixes: bc2791f857e1 ("slab: link memcg kmem_caches on their associated memory cgroup")
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> ---
>  mm/memcontrol.c  | 2 ++
>  mm/slab_common.c | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 6f6dc8712e39..43f0125b45bb 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4723,6 +4723,7 @@ static struct cftype mem_cgroup_legacy_files[] = {
>  		.write = mem_cgroup_reset,
>  		.read_u64 = mem_cgroup_read_u64,
>  	},
> +#ifdef CONFIG_MEMCG_KMEM
>  #if defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)

Not sure if

#if defined(CONFIG_MEMCG_KMEM) && \
    (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG))

is preffered


-- 
Thanks,

David / dhildenb



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mm, memcg: fix build error around the usage of kmem_caches
@ 2020-02-05 17:18   ` David Hildenbrand
  0 siblings, 0 replies; 6+ messages in thread
From: David Hildenbrand @ 2020-02-05 17:18 UTC (permalink / raw)
  To: Yafang Shao, tj-DgEjT+Ai2ygdnm+yROfE0A,
	vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w
  Cc: hannes-druUgvl0LCNAfugRpC6u6w, mhocko-DgEjT+Ai2ygdnm+yROfE0A,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b, cl-vYTEC60ixJUAvxtiuMwx3w,
	penberg-DgEjT+Ai2ygdnm+yROfE0A, rientjes-hpIqsD4AKlfQT0dZR+AlfA,
	iamjoonsoo.kim-Hm3cg6mZ9cc, cgroups-u79uwXL29TY76Z2rM5mHXA,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg

On 05.02.20 18:03, Yafang Shao wrote:
> When I manually set default n to MEMCG_KMEM in init/Kconfig, bellow error
> occurs,
> 
> mm/slab_common.c: In function 'memcg_slab_start':
> mm/slab_common.c:1530:30: error: 'struct mem_cgroup' has no member named
> 'kmem_caches'
>   return seq_list_start(&memcg->kmem_caches, *pos);
>                               ^
> mm/slab_common.c: In function 'memcg_slab_next':
> mm/slab_common.c:1537:32: error: 'struct mem_cgroup' has no member named
> 'kmem_caches'
>   return seq_list_next(p, &memcg->kmem_caches, pos);
>                                 ^
> mm/slab_common.c: In function 'memcg_slab_show':
> mm/slab_common.c:1551:16: error: 'struct mem_cgroup' has no member named
> 'kmem_caches'
>   if (p == memcg->kmem_caches.next)
>                 ^
>   CC      arch/x86/xen/smp.o
> mm/slab_common.c: In function 'memcg_slab_start':
> mm/slab_common.c:1531:1: warning: control reaches end of non-void function
> [-Wreturn-type]
>  }
>  ^
> mm/slab_common.c: In function 'memcg_slab_next':
> mm/slab_common.c:1538:1: warning: control reaches end of non-void function
> [-Wreturn-type]
>  }
>  ^
> 
> That's because kmem_caches is defined only when CONFIG_MEMCG_KMEM is set,
> while memcg_slab_start() will use it no matter CONFIG_MEMCG_KMEM is defined
> or not.
> 
> By the way, the reason I mannuly undefined CONFIG_MEMCG_KMEM is to verify
> whether my some other code change is still stable when CONFIG_MEMCG_KMEM is
> not set. Unfortunately, the existing code has been already unstable since
> v4.11.
> 
> Fixes: bc2791f857e1 ("slab: link memcg kmem_caches on their associated memory cgroup")
> Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Vladimir Davydov <vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Yafang Shao <laoar.shao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  mm/memcontrol.c  | 2 ++
>  mm/slab_common.c | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 6f6dc8712e39..43f0125b45bb 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4723,6 +4723,7 @@ static struct cftype mem_cgroup_legacy_files[] = {
>  		.write = mem_cgroup_reset,
>  		.read_u64 = mem_cgroup_read_u64,
>  	},
> +#ifdef CONFIG_MEMCG_KMEM
>  #if defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)

Not sure if

#if defined(CONFIG_MEMCG_KMEM) && \
    (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG))

is preffered


-- 
Thanks,

David / dhildenb


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mm, memcg: fix build error around the usage of kmem_caches
@ 2020-02-06  1:15     ` Yafang Shao
  0 siblings, 0 replies; 6+ messages in thread
From: Yafang Shao @ 2020-02-06  1:15 UTC (permalink / raw)
  To: David Hildenbrand
  Cc: Tejun Heo, Vladimir Davydov, Johannes Weiner, Michal Hocko,
	Andrew Morton, Christoph Lameter, penberg, David Rientjes,
	iamjoonsoo.kim, Cgroups, Linux MM

On Thu, Feb 6, 2020 at 1:19 AM David Hildenbrand <david@redhat.com> wrote:
>
> On 05.02.20 18:03, Yafang Shao wrote:
> > When I manually set default n to MEMCG_KMEM in init/Kconfig, bellow error
> > occurs,
> >
> > mm/slab_common.c: In function 'memcg_slab_start':
> > mm/slab_common.c:1530:30: error: 'struct mem_cgroup' has no member named
> > 'kmem_caches'
> >   return seq_list_start(&memcg->kmem_caches, *pos);
> >                               ^
> > mm/slab_common.c: In function 'memcg_slab_next':
> > mm/slab_common.c:1537:32: error: 'struct mem_cgroup' has no member named
> > 'kmem_caches'
> >   return seq_list_next(p, &memcg->kmem_caches, pos);
> >                                 ^
> > mm/slab_common.c: In function 'memcg_slab_show':
> > mm/slab_common.c:1551:16: error: 'struct mem_cgroup' has no member named
> > 'kmem_caches'
> >   if (p == memcg->kmem_caches.next)
> >                 ^
> >   CC      arch/x86/xen/smp.o
> > mm/slab_common.c: In function 'memcg_slab_start':
> > mm/slab_common.c:1531:1: warning: control reaches end of non-void function
> > [-Wreturn-type]
> >  }
> >  ^
> > mm/slab_common.c: In function 'memcg_slab_next':
> > mm/slab_common.c:1538:1: warning: control reaches end of non-void function
> > [-Wreturn-type]
> >  }
> >  ^
> >
> > That's because kmem_caches is defined only when CONFIG_MEMCG_KMEM is set,
> > while memcg_slab_start() will use it no matter CONFIG_MEMCG_KMEM is defined
> > or not.
> >
> > By the way, the reason I mannuly undefined CONFIG_MEMCG_KMEM is to verify
> > whether my some other code change is still stable when CONFIG_MEMCG_KMEM is
> > not set. Unfortunately, the existing code has been already unstable since
> > v4.11.
> >
> > Fixes: bc2791f857e1 ("slab: link memcg kmem_caches on their associated memory cgroup")
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> > Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> > ---
> >  mm/memcontrol.c  | 2 ++
> >  mm/slab_common.c | 2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 6f6dc8712e39..43f0125b45bb 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -4723,6 +4723,7 @@ static struct cftype mem_cgroup_legacy_files[] = {
> >               .write = mem_cgroup_reset,
> >               .read_u64 = mem_cgroup_read_u64,
> >       },
> > +#ifdef CONFIG_MEMCG_KMEM
> >  #if defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)
>
> Not sure if
>
> #if defined(CONFIG_MEMCG_KMEM) && \
>     (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG))
>
> is preffered
>

Seems better. Thanks for your suggestion.

Thanks
Yafang


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mm, memcg: fix build error around the usage of kmem_caches
@ 2020-02-06  1:15     ` Yafang Shao
  0 siblings, 0 replies; 6+ messages in thread
From: Yafang Shao @ 2020-02-06  1:15 UTC (permalink / raw)
  To: David Hildenbrand
  Cc: Tejun Heo, Vladimir Davydov, Johannes Weiner, Michal Hocko,
	Andrew Morton, Christoph Lameter, penberg-DgEjT+Ai2ygdnm+yROfE0A,
	David Rientjes, iamjoonsoo.kim-Hm3cg6mZ9cc, Cgroups, Linux MM

On Thu, Feb 6, 2020 at 1:19 AM David Hildenbrand <david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>
> On 05.02.20 18:03, Yafang Shao wrote:
> > When I manually set default n to MEMCG_KMEM in init/Kconfig, bellow error
> > occurs,
> >
> > mm/slab_common.c: In function 'memcg_slab_start':
> > mm/slab_common.c:1530:30: error: 'struct mem_cgroup' has no member named
> > 'kmem_caches'
> >   return seq_list_start(&memcg->kmem_caches, *pos);
> >                               ^
> > mm/slab_common.c: In function 'memcg_slab_next':
> > mm/slab_common.c:1537:32: error: 'struct mem_cgroup' has no member named
> > 'kmem_caches'
> >   return seq_list_next(p, &memcg->kmem_caches, pos);
> >                                 ^
> > mm/slab_common.c: In function 'memcg_slab_show':
> > mm/slab_common.c:1551:16: error: 'struct mem_cgroup' has no member named
> > 'kmem_caches'
> >   if (p == memcg->kmem_caches.next)
> >                 ^
> >   CC      arch/x86/xen/smp.o
> > mm/slab_common.c: In function 'memcg_slab_start':
> > mm/slab_common.c:1531:1: warning: control reaches end of non-void function
> > [-Wreturn-type]
> >  }
> >  ^
> > mm/slab_common.c: In function 'memcg_slab_next':
> > mm/slab_common.c:1538:1: warning: control reaches end of non-void function
> > [-Wreturn-type]
> >  }
> >  ^
> >
> > That's because kmem_caches is defined only when CONFIG_MEMCG_KMEM is set,
> > while memcg_slab_start() will use it no matter CONFIG_MEMCG_KMEM is defined
> > or not.
> >
> > By the way, the reason I mannuly undefined CONFIG_MEMCG_KMEM is to verify
> > whether my some other code change is still stable when CONFIG_MEMCG_KMEM is
> > not set. Unfortunately, the existing code has been already unstable since
> > v4.11.
> >
> > Fixes: bc2791f857e1 ("slab: link memcg kmem_caches on their associated memory cgroup")
> > Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Cc: Vladimir Davydov <vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Yafang Shao <laoar.shao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> >  mm/memcontrol.c  | 2 ++
> >  mm/slab_common.c | 2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 6f6dc8712e39..43f0125b45bb 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -4723,6 +4723,7 @@ static struct cftype mem_cgroup_legacy_files[] = {
> >               .write = mem_cgroup_reset,
> >               .read_u64 = mem_cgroup_read_u64,
> >       },
> > +#ifdef CONFIG_MEMCG_KMEM
> >  #if defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)
>
> Not sure if
>
> #if defined(CONFIG_MEMCG_KMEM) && \
>     (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG))
>
> is preffered
>

Seems better. Thanks for your suggestion.

Thanks
Yafang

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-06  1:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 17:03 [PATCH] mm, memcg: fix build error around the usage of kmem_caches Yafang Shao
2020-02-05 17:03 ` Yafang Shao
2020-02-05 17:18 ` David Hildenbrand
2020-02-05 17:18   ` David Hildenbrand
2020-02-06  1:15   ` Yafang Shao
2020-02-06  1:15     ` Yafang Shao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.