* [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
@ 2016-11-22 21:01 Manjukumar Matha
2016-11-22 22:03 ` Khem Raj
0 siblings, 1 reply; 17+ messages in thread
From: Manjukumar Matha @ 2016-11-22 21:01 UTC (permalink / raw)
To: openembedded-core
There was bug with alignment frags for aarch64 in binutils. This is
fixed in master of binutils. This patch backports the fix to binutils
2.27 version.
Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
---
meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
...eration-of-alignment-frags-in-code-sectio.patch | 139 +++++++++++++++++++++
2 files changed, 140 insertions(+)
create mode 100644 meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc b/meta/recipes-devtools/binutils/binutils-2.27.inc
index fc81721..90518bf 100644
--- a/meta/recipes-devtools/binutils/binutils-2.27.inc
+++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
@@ -37,6 +37,7 @@ SRC_URI = "\
file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
+ file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch \
"
S = "${WORKDIR}/git"
diff --git a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
new file mode 100644
index 0000000..f8b46be
--- /dev/null
+++ b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
@@ -0,0 +1,139 @@
+From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
+From: Nick Clifton <nickc@redhat.com>
+Date: Fri, 18 Nov 2016 11:42:48 -0800
+Subject: [PATCH] Fix the generation of alignment frags in code sections for AArch64.
+
+PR gas/20364
+* config/tc-aarch64.c (s_ltorg): Change the mapping state after
+aligning the frag.
+(aarch64_init): Treat rs_align frags in code sections as
+containing code, not data.
+* testsuite/gas/aarch64/pr20364.s: New test.
+* testsuite/gas/aarch64/pr20364.d: New test driver.
+
+Backporting the patch from binutils mainline
+https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
+
+Upstream-Status: Backport
+
+Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
+---
+ gas/ChangeLog | 10 ++++++++++
+ gas/config/tc-aarch64.c | 10 +++++++---
+ gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
+ gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
+ 4 files changed, 58 insertions(+), 3 deletions(-)
+ create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
+ create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
+
+diff --git a/gas/ChangeLog b/gas/ChangeLog
+index a39895a..fad06dc 100644
+--- a/gas/ChangeLog
++++ b/gas/ChangeLog
+@@ -1,3 +1,13 @@
++2016-08-05 Nick Clifton <nickc@redhat.com>
++
++ PR gas/20364
++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
++ aligning the frag.
++ (aarch64_init): Treat rs_align frags in code sections as
++ containing code, not data.
++ * testsuite/gas/aarch64/pr20364.s: New test.
++ * testsuite/gas/aarch64/pr20364.d: New test driver.
++
+ 2016-08-03 Tristan Gingold <gingold@adacore.com>
+
+ * configure: Regenerate.
+diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
+index ddc40f2..74933cb 100644
+--- a/gas/config/tc-aarch64.c
++++ b/gas/config/tc-aarch64.c
+@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
+ if (pool == NULL || pool->symbol == NULL || pool->next_free_entry == 0)
+ continue;
+
+- mapping_state (MAP_DATA);
+-
+ /* Align pool as you have word accesses.
+ Only make a frag if we have to. */
+ if (!need_pass_2)
+ frag_align (align, 0, 0);
+
++ mapping_state (MAP_DATA);
++
+ record_alignment (now_seg, align);
+
+ sprintf (sym_name, "$$lit_\002%x", pool->id);
+@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int max_chars)
+
+ switch (fragP->fr_type)
+ {
+- case rs_align:
+ case rs_align_test:
+ case rs_fill:
+ mapping_state_2 (MAP_DATA, max_chars);
+ break;
++ case rs_align:
++ /* PR 20364: We can get alignment frags in code sections,
++ so do not just assume that we should use the MAP_DATA state. */
++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN : MAP_DATA, max_chars);
++ break;
+ case rs_align_code:
+ mapping_state_2 (MAP_INSN, max_chars);
+ break;
+diff --git a/gas/testsuite/gas/aarch64/pr20364.d b/gas/testsuite/gas/aarch64/pr20364.d
+new file mode 100644
+index 0000000..babcff1
+--- /dev/null
++++ b/gas/testsuite/gas/aarch64/pr20364.d
+@@ -0,0 +1,13 @@
++# Check that ".align <size>, <fill>" does not set the mapping state to DATA, causing unnecessary frag generation.
++#name: PR20364
++#objdump: -d
++
++.*: file format .*
++
++Disassembly of section \.vectors:
++
++0+000 <.*>:
++ 0: d2800000 mov x0, #0x0 // #0
++ 4: 94000000 bl 0 <plat_report_exception>
++ 8: 17fffffe b 0 <bl1_exceptions>
++
+diff --git a/gas/testsuite/gas/aarch64/pr20364.s b/gas/testsuite/gas/aarch64/pr20364.s
+new file mode 100644
+index 0000000..594ad7c
+--- /dev/null
++++ b/gas/testsuite/gas/aarch64/pr20364.s
+@@ -0,0 +1,28 @@
++ .macro vector_base label
++ .section .vectors, "ax"
++ .align 11, 0
++ \label:
++ .endm
++
++ .macro vector_entry label
++ .section .vectors, "ax"
++ .align 7, 0
++ \label:
++ .endm
++
++ .macro check_vector_size since
++ .if (. - \since) > (32 * 4)
++ .error "Vector exceeds 32 instructions"
++ .endif
++ .endm
++
++ .globl bl1_exceptions
++
++vector_base bl1_exceptions
++
++vector_entry SynchronousExceptionSP0
++ mov x0, #0x0
++ bl plat_report_exception
++ b SynchronousExceptionSP0
++ check_vector_size SynchronousExceptionSP0
++
+--
+2.7.4
+
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-11-22 21:01 [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64 Manjukumar Matha
@ 2016-11-22 22:03 ` Khem Raj
2016-11-22 23:08 ` Manjukumar Harthikote Matha
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Khem Raj @ 2016-11-22 22:03 UTC (permalink / raw)
To: Manjukumar Harthikote Matha
Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 6938 bytes --]
This is ok for master
On Nov 22, 2016 1:31 PM, "Manjukumar Matha" <
manjukumar.harthikote-matha@xilinx.com> wrote:
> There was bug with alignment frags for aarch64 in binutils. This is
> fixed in master of binutils. This patch backports the fix to binutils
> 2.27 version.
>
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
> ...eration-of-alignment-frags-in-code-sectio.patch | 139
> +++++++++++++++++++++
> 2 files changed, 140 insertions(+)
> create mode 100644 meta/recipes-devtools/binutils/binutils/0017-Fix-
> the-generation-of-alignment-frags-in-code-sectio.patch
>
> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc
> b/meta/recipes-devtools/binutils/binutils-2.27.inc
> index fc81721..90518bf 100644
> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
> @@ -37,6 +37,7 @@ SRC_URI = "\
> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch
> \
> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch
> \
> + file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> \
> "
> S = "${WORKDIR}/git"
>
> diff --git a/meta/recipes-devtools/binutils/binutils/0017-Fix-
> the-generation-of-alignment-frags-in-code-sectio.patch
> b/meta/recipes-devtools/binutils/binutils/0017-Fix-
> the-generation-of-alignment-frags-in-code-sectio.patch
> new file mode 100644
> index 0000000..f8b46be
> --- /dev/null
> +++ b/meta/recipes-devtools/binutils/binutils/0017-Fix-
> the-generation-of-alignment-frags-in-code-sectio.patch
> @@ -0,0 +1,139 @@
> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
> +From: Nick Clifton <nickc@redhat.com>
> +Date: Fri, 18 Nov 2016 11:42:48 -0800
> +Subject: [PATCH] Fix the generation of alignment frags in code sections
> for AArch64.
> +
> +PR gas/20364
> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
> +aligning the frag.
> +(aarch64_init): Treat rs_align frags in code sections as
> +containing code, not data.
> +* testsuite/gas/aarch64/pr20364.s: New test.
> +* testsuite/gas/aarch64/pr20364.d: New test driver.
> +
> +Backporting the patch from binutils mainline
> +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=
> 7ea12e5c3ad54da440c08f32da09534e63e515ca
> +
> +Upstream-Status: Backport
> +
> +Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
> +---
> + gas/ChangeLog | 10 ++++++++++
> + gas/config/tc-aarch64.c | 10 +++++++---
> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
> + gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
> + 4 files changed, 58 insertions(+), 3 deletions(-)
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
> +
> +diff --git a/gas/ChangeLog b/gas/ChangeLog
> +index a39895a..fad06dc 100644
> +--- a/gas/ChangeLog
> ++++ b/gas/ChangeLog
> +@@ -1,3 +1,13 @@
> ++2016-08-05 Nick Clifton <nickc@redhat.com>
> ++
> ++ PR gas/20364
> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
> ++ aligning the frag.
> ++ (aarch64_init): Treat rs_align frags in code sections as
> ++ containing code, not data.
> ++ * testsuite/gas/aarch64/pr20364.s: New test.
> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
> ++
> + 2016-08-03 Tristan Gingold <gingold@adacore.com>
> +
> + * configure: Regenerate.
> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> +index ddc40f2..74933cb 100644
> +--- a/gas/config/tc-aarch64.c
> ++++ b/gas/config/tc-aarch64.c
> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
> + if (pool == NULL || pool->symbol == NULL || pool->next_free_entry
> == 0)
> + continue;
> +
> +- mapping_state (MAP_DATA);
> +-
> + /* Align pool as you have word accesses.
> + Only make a frag if we have to. */
> + if (!need_pass_2)
> + frag_align (align, 0, 0);
> +
> ++ mapping_state (MAP_DATA);
> ++
> + record_alignment (now_seg, align);
> +
> + sprintf (sym_name, "$$lit_\002%x", pool->id);
> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int max_chars)
> +
> + switch (fragP->fr_type)
> + {
> +- case rs_align:
> + case rs_align_test:
> + case rs_fill:
> + mapping_state_2 (MAP_DATA, max_chars);
> + break;
> ++ case rs_align:
> ++ /* PR 20364: We can get alignment frags in code sections,
> ++ so do not just assume that we should use the MAP_DATA state. */
> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN : MAP_DATA,
> max_chars);
> ++ break;
> + case rs_align_code:
> + mapping_state_2 (MAP_INSN, max_chars);
> + break;
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
> b/gas/testsuite/gas/aarch64/pr20364.d
> +new file mode 100644
> +index 0000000..babcff1
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
> +@@ -0,0 +1,13 @@
> ++# Check that ".align <size>, <fill>" does not set the mapping state to
> DATA, causing unnecessary frag generation.
> ++#name: PR20364
> ++#objdump: -d
> ++
> ++.*: file format .*
> ++
> ++Disassembly of section \.vectors:
> ++
> ++0+000 <.*>:
> ++ 0: d2800000 mov x0, #0x0 // #0
> ++ 4: 94000000 bl 0 <plat_report_exception>
> ++ 8: 17fffffe b 0 <bl1_exceptions>
> ++
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
> b/gas/testsuite/gas/aarch64/pr20364.s
> +new file mode 100644
> +index 0000000..594ad7c
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
> +@@ -0,0 +1,28 @@
> ++ .macro vector_base label
> ++ .section .vectors, "ax"
> ++ .align 11, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro vector_entry label
> ++ .section .vectors, "ax"
> ++ .align 7, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro check_vector_size since
> ++ .if (. - \since) > (32 * 4)
> ++ .error "Vector exceeds 32 instructions"
> ++ .endif
> ++ .endm
> ++
> ++ .globl bl1_exceptions
> ++
> ++vector_base bl1_exceptions
> ++
> ++vector_entry SynchronousExceptionSP0
> ++ mov x0, #0x0
> ++ bl plat_report_exception
> ++ b SynchronousExceptionSP0
> ++ check_vector_size SynchronousExceptionSP0
> ++
> +--
> +2.7.4
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 8740 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-11-22 22:03 ` Khem Raj
@ 2016-11-22 23:08 ` Manjukumar Harthikote Matha
2016-11-22 23:36 ` Khem Raj
2016-12-15 22:28 ` Manjukumar Harthikote Matha
2017-01-16 17:49 ` Manjukumar Harthikote Matha
2 siblings, 1 reply; 17+ messages in thread
From: Manjukumar Harthikote Matha @ 2016-11-22 23:08 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
Hi Khem,
On 11/22/2016 02:03 PM, Khem Raj wrote:
> This is ok for master
Is there a particular reason not have in Morty? We have
arm-trusted-firmware failing to build due to this issue. I have
submitted a patch to master as well
Thanks
Manju
>
>
> On Nov 22, 2016 1:31 PM, "Manjukumar Matha"
> <manjukumar.harthikote-matha@xilinx.com
> <mailto:manjukumar.harthikote-matha@xilinx.com>> wrote:
>
> There was bug with alignment frags for aarch64 in binutils. This is
> fixed in master of binutils. This patch backports the fix to binutils
> 2.27 version.
>
> Signed-off-by: Manjukumar Matha
> <manjukumar.harthikote-matha@xilinx.com
> <mailto:manjukumar.harthikote-matha@xilinx.com>>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
> <mailto:nathan@nathanrossi.com>>
> ---
> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
> ...eration-of-alignment-frags-in-code-sectio.patch | 139
> +++++++++++++++++++++
> 2 files changed, 140 insertions(+)
> create mode 100644
> meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>
> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc
> b/meta/recipes-devtools/binutils/binutils-2.27.inc
> index fc81721..90518bf 100644
> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
> @@ -37,6 +37,7 @@ SRC_URI = "\
> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
>
> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
>
> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
> +
> file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> \
> "
> S = "${WORKDIR}/git"
>
> diff --git
> a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> new file mode 100644
> index 0000000..f8b46be
> --- /dev/null
> +++
> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> @@ -0,0 +1,139 @@
> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
> +Date: Fri, 18 Nov 2016 11:42:48 -0800
> +Subject: [PATCH] Fix the generation of alignment frags in code
> sections for AArch64.
> +
> +PR gas/20364
> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
> +aligning the frag.
> +(aarch64_init): Treat rs_align frags in code sections as
> +containing code, not data.
> +* testsuite/gas/aarch64/pr20364.s: New test.
> +* testsuite/gas/aarch64/pr20364.d: New test driver.
> +
> +Backporting the patch from binutils mainline
> +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
> <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
> +
> +Upstream-Status: Backport
> +
> +Signed-off-by: Manjukumar Matha
> <manjukumar.harthikote-matha@xilinx.com
> <mailto:manjukumar.harthikote-matha@xilinx.com>>
> +---
> + gas/ChangeLog | 10 ++++++++++
> + gas/config/tc-aarch64.c | 10 +++++++---
> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
> + gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
> + 4 files changed, 58 insertions(+), 3 deletions(-)
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
> +
> +diff --git a/gas/ChangeLog b/gas/ChangeLog
> +index a39895a..fad06dc 100644
> +--- a/gas/ChangeLog
> ++++ b/gas/ChangeLog
> +@@ -1,3 +1,13 @@
> ++2016-08-05 Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
> ++
> ++ PR gas/20364
> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
> ++ aligning the frag.
> ++ (aarch64_init): Treat rs_align frags in code sections as
> ++ containing code, not data.
> ++ * testsuite/gas/aarch64/pr20364.s: New test.
> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
> ++
> + 2016-08-03 Tristan Gingold <gingold@adacore.com
> <mailto:gingold@adacore.com>>
> +
> + * configure: Regenerate.
> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> +index ddc40f2..74933cb 100644
> +--- a/gas/config/tc-aarch64.c
> ++++ b/gas/config/tc-aarch64.c
> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
> + if (pool == NULL || pool->symbol == NULL ||
> pool->next_free_entry == 0)
> + continue;
> +
> +- mapping_state (MAP_DATA);
> +-
> + /* Align pool as you have word accesses.
> + Only make a frag if we have to. */
> + if (!need_pass_2)
> + frag_align (align, 0, 0);
> +
> ++ mapping_state (MAP_DATA);
> ++
> + record_alignment (now_seg, align);
> +
> + sprintf (sym_name, "$$lit_\002%x", pool->id);
> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
> max_chars)
> +
> + switch (fragP->fr_type)
> + {
> +- case rs_align:
> + case rs_align_test:
> + case rs_fill:
> + mapping_state_2 (MAP_DATA, max_chars);
> + break;
> ++ case rs_align:
> ++ /* PR 20364: We can get alignment frags in code sections,
> ++ so do not just assume that we should use the MAP_DATA
> state. */
> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
> MAP_DATA, max_chars);
> ++ break;
> + case rs_align_code:
> + mapping_state_2 (MAP_INSN, max_chars);
> + break;
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
> b/gas/testsuite/gas/aarch64/pr20364.d
> +new file mode 100644
> +index 0000000..babcff1
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
> +@@ -0,0 +1,13 @@
> ++# Check that ".align <size>, <fill>" does not set the mapping
> state to DATA, causing unnecessary frag generation.
> ++#name: PR20364
> ++#objdump: -d
> ++
> ++.*: file format .*
> ++
> ++Disassembly of section \.vectors:
> ++
> ++0+000 <.*>:
> ++ 0: d2800000 mov x0, #0x0 // #0
> ++ 4: 94000000 bl 0 <plat_report_exception>
> ++ 8: 17fffffe b 0 <bl1_exceptions>
> ++
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
> b/gas/testsuite/gas/aarch64/pr20364.s
> +new file mode 100644
> +index 0000000..594ad7c
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
> +@@ -0,0 +1,28 @@
> ++ .macro vector_base label
> ++ .section .vectors, "ax"
> ++ .align 11, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro vector_entry label
> ++ .section .vectors, "ax"
> ++ .align 7, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro check_vector_size since
> ++ .if (. - \since) > (32 * 4)
> ++ .error "Vector exceeds 32 instructions"
> ++ .endif
> ++ .endm
> ++
> ++ .globl bl1_exceptions
> ++
> ++vector_base bl1_exceptions
> ++
> ++vector_entry SynchronousExceptionSP0
> ++ mov x0, #0x0
> ++ bl plat_report_exception
> ++ b SynchronousExceptionSP0
> ++ check_vector_size SynchronousExceptionSP0
> ++
> +--
> +2.7.4
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-11-22 23:08 ` Manjukumar Harthikote Matha
@ 2016-11-22 23:36 ` Khem Raj
2016-11-22 23:36 ` Manjukumar Harthikote Matha
0 siblings, 1 reply; 17+ messages in thread
From: Khem Raj @ 2016-11-22 23:36 UTC (permalink / raw)
To: Manjukumar Harthikote Matha
Cc: Patches and discussions about the oe-core layer
[-- Attachment #1.1: Type: text/plain, Size: 8864 bytes --]
On 11/22/16 3:08 PM, Manjukumar Harthikote Matha wrote:
> Hi Khem,
>
> On 11/22/2016 02:03 PM, Khem Raj wrote:
>> This is ok for master
> Is there a particular reason not have in Morty? We have arm-trusted-firmware
> failing to build due to this issue. I have submitted a patch to master as well
Once its in master, it should get into morty subsequently.
>
> Thanks
> Manju
>
>>
>>
>> On Nov 22, 2016 1:31 PM, "Manjukumar Matha"
>> <manjukumar.harthikote-matha@xilinx.com
>> <mailto:manjukumar.harthikote-matha@xilinx.com>> wrote:
>>
>> There was bug with alignment frags for aarch64 in binutils. This is
>> fixed in master of binutils. This patch backports the fix to binutils
>> 2.27 version.
>>
>> Signed-off-by: Manjukumar Matha
>> <manjukumar.harthikote-matha@xilinx.com
>> <mailto:manjukumar.harthikote-matha@xilinx.com>>
>> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
>> <mailto:nathan@nathanrossi.com>>
>> ---
>> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
>> ...eration-of-alignment-frags-in-code-sectio.patch | 139
>> +++++++++++++++++++++
>> 2 files changed, 140 insertions(+)
>> create mode 100644
>>
>> meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>
>>
>> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc
>> b/meta/recipes-devtools/binutils/binutils-2.27.inc
>> index fc81721..90518bf 100644
>> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
>> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
>> @@ -37,6 +37,7 @@ SRC_URI = "\
>> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
>>
>> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
>>
>> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
>> +
>> file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>> \
>> "
>> S = "${WORKDIR}/git"
>>
>> diff --git
>>
>> a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>
>>
>> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>
>> new file mode 100644
>> index 0000000..f8b46be
>> --- /dev/null
>> +++
>>
>> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>
>> @@ -0,0 +1,139 @@
>> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
>> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
>> +Date: Fri, 18 Nov 2016 11:42:48 -0800
>> +Subject: [PATCH] Fix the generation of alignment frags in code
>> sections for AArch64.
>> +
>> +PR gas/20364
>> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
>> +aligning the frag.
>> +(aarch64_init): Treat rs_align frags in code sections as
>> +containing code, not data.
>> +* testsuite/gas/aarch64/pr20364.s: New test.
>> +* testsuite/gas/aarch64/pr20364.d: New test driver.
>> +
>> +Backporting the patch from binutils mainline
>>
>> +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
>>
>>
>> <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
>>
>> +
>> +Upstream-Status: Backport
>> +
>> +Signed-off-by: Manjukumar Matha
>> <manjukumar.harthikote-matha@xilinx.com
>> <mailto:manjukumar.harthikote-matha@xilinx.com>>
>> +---
>> + gas/ChangeLog | 10 ++++++++++
>> + gas/config/tc-aarch64.c | 10 +++++++---
>> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
>> + gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
>> + 4 files changed, 58 insertions(+), 3 deletions(-)
>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
>> +
>> +diff --git a/gas/ChangeLog b/gas/ChangeLog
>> +index a39895a..fad06dc 100644
>> +--- a/gas/ChangeLog
>> ++++ b/gas/ChangeLog
>> +@@ -1,3 +1,13 @@
>> ++2016-08-05 Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
>> ++
>> ++ PR gas/20364
>> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
>> ++ aligning the frag.
>> ++ (aarch64_init): Treat rs_align frags in code sections as
>> ++ containing code, not data.
>> ++ * testsuite/gas/aarch64/pr20364.s: New test.
>> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
>> ++
>> + 2016-08-03 Tristan Gingold <gingold@adacore.com
>> <mailto:gingold@adacore.com>>
>> +
>> + * configure: Regenerate.
>> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
>> +index ddc40f2..74933cb 100644
>> +--- a/gas/config/tc-aarch64.c
>> ++++ b/gas/config/tc-aarch64.c
>> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
>> + if (pool == NULL || pool->symbol == NULL ||
>> pool->next_free_entry == 0)
>> + continue;
>> +
>> +- mapping_state (MAP_DATA);
>> +-
>> + /* Align pool as you have word accesses.
>> + Only make a frag if we have to. */
>> + if (!need_pass_2)
>> + frag_align (align, 0, 0);
>> +
>> ++ mapping_state (MAP_DATA);
>> ++
>> + record_alignment (now_seg, align);
>> +
>> + sprintf (sym_name, "$$lit_\002%x", pool->id);
>> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
>> max_chars)
>> +
>> + switch (fragP->fr_type)
>> + {
>> +- case rs_align:
>> + case rs_align_test:
>> + case rs_fill:
>> + mapping_state_2 (MAP_DATA, max_chars);
>> + break;
>> ++ case rs_align:
>> ++ /* PR 20364: We can get alignment frags in code sections,
>> ++ so do not just assume that we should use the MAP_DATA
>> state. */
>> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
>> MAP_DATA, max_chars);
>> ++ break;
>> + case rs_align_code:
>> + mapping_state_2 (MAP_INSN, max_chars);
>> + break;
>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
>> b/gas/testsuite/gas/aarch64/pr20364.d
>> +new file mode 100644
>> +index 0000000..babcff1
>> +--- /dev/null
>> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
>> +@@ -0,0 +1,13 @@
>> ++# Check that ".align <size>, <fill>" does not set the mapping
>> state to DATA, causing unnecessary frag generation.
>> ++#name: PR20364
>> ++#objdump: -d
>> ++
>> ++.*: file format .*
>> ++
>> ++Disassembly of section \.vectors:
>> ++
>> ++0+000 <.*>:
>> ++ 0: d2800000 mov x0, #0x0 // #0
>> ++ 4: 94000000 bl 0 <plat_report_exception>
>> ++ 8: 17fffffe b 0 <bl1_exceptions>
>> ++
>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
>> b/gas/testsuite/gas/aarch64/pr20364.s
>> +new file mode 100644
>> +index 0000000..594ad7c
>> +--- /dev/null
>> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
>> +@@ -0,0 +1,28 @@
>> ++ .macro vector_base label
>> ++ .section .vectors, "ax"
>> ++ .align 11, 0
>> ++ \label:
>> ++ .endm
>> ++
>> ++ .macro vector_entry label
>> ++ .section .vectors, "ax"
>> ++ .align 7, 0
>> ++ \label:
>> ++ .endm
>> ++
>> ++ .macro check_vector_size since
>> ++ .if (. - \since) > (32 * 4)
>> ++ .error "Vector exceeds 32 instructions"
>> ++ .endif
>> ++ .endm
>> ++
>> ++ .globl bl1_exceptions
>> ++
>> ++vector_base bl1_exceptions
>> ++
>> ++vector_entry SynchronousExceptionSP0
>> ++ mov x0, #0x0
>> ++ bl plat_report_exception
>> ++ b SynchronousExceptionSP0
>> ++ check_vector_size SynchronousExceptionSP0
>> ++
>> +--
>> +2.7.4
>> +
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> <mailto:Openembedded-core@lists.openembedded.org>
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-11-22 23:36 ` Khem Raj
@ 2016-11-22 23:36 ` Manjukumar Harthikote Matha
0 siblings, 0 replies; 17+ messages in thread
From: Manjukumar Harthikote Matha @ 2016-11-22 23:36 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On 11/22/2016 03:36 PM, Khem Raj wrote:
>
>
> On 11/22/16 3:08 PM, Manjukumar Harthikote Matha wrote:
>> Hi Khem,
>>
>> On 11/22/2016 02:03 PM, Khem Raj wrote:
>>> This is ok for master
>> Is there a particular reason not have in Morty? We have arm-trusted-firmware
>> failing to build due to this issue. I have submitted a patch to master as well
>
> Once its in master, it should get into morty subsequently.
Ok thanks for clarification :)
>
>>
>> Thanks
>> Manju
>>
>>>
>>>
>>> On Nov 22, 2016 1:31 PM, "Manjukumar Matha"
>>> <manjukumar.harthikote-matha@xilinx.com
>>> <mailto:manjukumar.harthikote-matha@xilinx.com>> wrote:
>>>
>>> There was bug with alignment frags for aarch64 in binutils. This is
>>> fixed in master of binutils. This patch backports the fix to binutils
>>> 2.27 version.
>>>
>>> Signed-off-by: Manjukumar Matha
>>> <manjukumar.harthikote-matha@xilinx.com
>>> <mailto:manjukumar.harthikote-matha@xilinx.com>>
>>> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
>>> <mailto:nathan@nathanrossi.com>>
>>> ---
>>> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
>>> ...eration-of-alignment-frags-in-code-sectio.patch | 139
>>> +++++++++++++++++++++
>>> 2 files changed, 140 insertions(+)
>>> create mode 100644
>>>
>>> meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>>
>>>
>>> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc
>>> b/meta/recipes-devtools/binutils/binutils-2.27.inc
>>> index fc81721..90518bf 100644
>>> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
>>> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
>>> @@ -37,6 +37,7 @@ SRC_URI = "\
>>> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
>>>
>>> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
>>>
>>> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
>>> +
>>> file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>> \
>>> "
>>> S = "${WORKDIR}/git"
>>>
>>> diff --git
>>>
>>> a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>>
>>>
>>> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>>
>>> new file mode 100644
>>> index 0000000..f8b46be
>>> --- /dev/null
>>> +++
>>>
>>> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>>
>>> @@ -0,0 +1,139 @@
>>> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
>>> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
>>> +Date: Fri, 18 Nov 2016 11:42:48 -0800
>>> +Subject: [PATCH] Fix the generation of alignment frags in code
>>> sections for AArch64.
>>> +
>>> +PR gas/20364
>>> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
>>> +aligning the frag.
>>> +(aarch64_init): Treat rs_align frags in code sections as
>>> +containing code, not data.
>>> +* testsuite/gas/aarch64/pr20364.s: New test.
>>> +* testsuite/gas/aarch64/pr20364.d: New test driver.
>>> +
>>> +Backporting the patch from binutils mainline
>>>
>>> +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
>>>
>>>
>>> <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
>>>
>>> +
>>> +Upstream-Status: Backport
>>> +
>>> +Signed-off-by: Manjukumar Matha
>>> <manjukumar.harthikote-matha@xilinx.com
>>> <mailto:manjukumar.harthikote-matha@xilinx.com>>
>>> +---
>>> + gas/ChangeLog | 10 ++++++++++
>>> + gas/config/tc-aarch64.c | 10 +++++++---
>>> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
>>> + gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
>>> + 4 files changed, 58 insertions(+), 3 deletions(-)
>>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
>>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
>>> +
>>> +diff --git a/gas/ChangeLog b/gas/ChangeLog
>>> +index a39895a..fad06dc 100644
>>> +--- a/gas/ChangeLog
>>> ++++ b/gas/ChangeLog
>>> +@@ -1,3 +1,13 @@
>>> ++2016-08-05 Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
>>> ++
>>> ++ PR gas/20364
>>> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
>>> ++ aligning the frag.
>>> ++ (aarch64_init): Treat rs_align frags in code sections as
>>> ++ containing code, not data.
>>> ++ * testsuite/gas/aarch64/pr20364.s: New test.
>>> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
>>> ++
>>> + 2016-08-03 Tristan Gingold <gingold@adacore.com
>>> <mailto:gingold@adacore.com>>
>>> +
>>> + * configure: Regenerate.
>>> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
>>> +index ddc40f2..74933cb 100644
>>> +--- a/gas/config/tc-aarch64.c
>>> ++++ b/gas/config/tc-aarch64.c
>>> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
>>> + if (pool == NULL || pool->symbol == NULL ||
>>> pool->next_free_entry == 0)
>>> + continue;
>>> +
>>> +- mapping_state (MAP_DATA);
>>> +-
>>> + /* Align pool as you have word accesses.
>>> + Only make a frag if we have to. */
>>> + if (!need_pass_2)
>>> + frag_align (align, 0, 0);
>>> +
>>> ++ mapping_state (MAP_DATA);
>>> ++
>>> + record_alignment (now_seg, align);
>>> +
>>> + sprintf (sym_name, "$$lit_\002%x", pool->id);
>>> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
>>> max_chars)
>>> +
>>> + switch (fragP->fr_type)
>>> + {
>>> +- case rs_align:
>>> + case rs_align_test:
>>> + case rs_fill:
>>> + mapping_state_2 (MAP_DATA, max_chars);
>>> + break;
>>> ++ case rs_align:
>>> ++ /* PR 20364: We can get alignment frags in code sections,
>>> ++ so do not just assume that we should use the MAP_DATA
>>> state. */
>>> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
>>> MAP_DATA, max_chars);
>>> ++ break;
>>> + case rs_align_code:
>>> + mapping_state_2 (MAP_INSN, max_chars);
>>> + break;
>>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
>>> b/gas/testsuite/gas/aarch64/pr20364.d
>>> +new file mode 100644
>>> +index 0000000..babcff1
>>> +--- /dev/null
>>> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
>>> +@@ -0,0 +1,13 @@
>>> ++# Check that ".align <size>, <fill>" does not set the mapping
>>> state to DATA, causing unnecessary frag generation.
>>> ++#name: PR20364
>>> ++#objdump: -d
>>> ++
>>> ++.*: file format .*
>>> ++
>>> ++Disassembly of section \.vectors:
>>> ++
>>> ++0+000 <.*>:
>>> ++ 0: d2800000 mov x0, #0x0 // #0
>>> ++ 4: 94000000 bl 0 <plat_report_exception>
>>> ++ 8: 17fffffe b 0 <bl1_exceptions>
>>> ++
>>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
>>> b/gas/testsuite/gas/aarch64/pr20364.s
>>> +new file mode 100644
>>> +index 0000000..594ad7c
>>> +--- /dev/null
>>> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
>>> +@@ -0,0 +1,28 @@
>>> ++ .macro vector_base label
>>> ++ .section .vectors, "ax"
>>> ++ .align 11, 0
>>> ++ \label:
>>> ++ .endm
>>> ++
>>> ++ .macro vector_entry label
>>> ++ .section .vectors, "ax"
>>> ++ .align 7, 0
>>> ++ \label:
>>> ++ .endm
>>> ++
>>> ++ .macro check_vector_size since
>>> ++ .if (. - \since) > (32 * 4)
>>> ++ .error "Vector exceeds 32 instructions"
>>> ++ .endif
>>> ++ .endm
>>> ++
>>> ++ .globl bl1_exceptions
>>> ++
>>> ++vector_base bl1_exceptions
>>> ++
>>> ++vector_entry SynchronousExceptionSP0
>>> ++ mov x0, #0x0
>>> ++ bl plat_report_exception
>>> ++ b SynchronousExceptionSP0
>>> ++ check_vector_size SynchronousExceptionSP0
>>> ++
>>> +--
>>> +2.7.4
>>> +
>>> --
>>> 2.7.4
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> <mailto:Openembedded-core@lists.openembedded.org>
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>>>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-11-22 22:03 ` Khem Raj
2016-11-22 23:08 ` Manjukumar Harthikote Matha
@ 2016-12-15 22:28 ` Manjukumar Harthikote Matha
2016-12-19 13:04 ` Burton, Ross
2017-01-16 17:49 ` Manjukumar Harthikote Matha
2 siblings, 1 reply; 17+ messages in thread
From: Manjukumar Harthikote Matha @ 2016-12-15 22:28 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Ping
This has not been added to master, is there something wrong with the patch ?
Please do let me know
Thanks
Manju
> -----Original Message-----
> From: Khem Raj [mailto:raj.khem@gmail.com]
> Sent: Tuesday, November 22, 2016 2:03 PM
> To: Manjukumar Harthikote Matha
> Cc: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for
> aarch64
>
> This is ok for master
>
>
> On Nov 22, 2016 1:31 PM, "Manjukumar Matha" <manjukumar.harthikote-
> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> > wrote:
>
>
> There was bug with alignment frags for aarch64 in binutils. This is
> fixed in master of binutils. This patch backports the fix to binutils
> 2.27 version.
>
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-
> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> >
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
> <mailto:nathan@nathanrossi.com> >
> ---
> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
> ...eration-of-alignment-frags-in-code-sectio.patch | 139
> +++++++++++++++++++++
> 2 files changed, 140 insertions(+)
> create mode 100644 meta/recipes-devtools/binutils/binutils/0017-Fix-the-
> generation-of-alignment-frags-in-code-sectio.patch
>
> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc b/meta/recipes-
> devtools/binutils/binutils-2.27.inc
> index fc81721..90518bf 100644
> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
> @@ -37,6 +37,7 @@ SRC_URI = "\
> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch
> \
> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
> + file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> \
> "
> S = "${WORKDIR}/git"
>
> diff --git a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-
> of-alignment-frags-in-code-sectio.patch b/meta/recipes-
> devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-
> sectio.patch
> new file mode 100644
> index 0000000..f8b46be
> --- /dev/null
> +++ b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-
> alignment-frags-in-code-sectio.patch
> @@ -0,0 +1,139 @@
> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17
> 00:00:00 2001
> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com> >
> +Date: Fri, 18 Nov 2016 11:42:48 -0800
> +Subject: [PATCH] Fix the generation of alignment frags in code sections for
> AArch64.
> +
> +PR gas/20364
> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
> +aligning the frag.
> +(aarch64_init): Treat rs_align frags in code sections as
> +containing code, not data.
> +* testsuite/gas/aarch64/pr20364.s: New test.
> +* testsuite/gas/aarch64/pr20364.d: New test driver.
> +
> +Backporting the patch from binutils mainline
> +https://sourceware.org/git/gitweb.cgi?p=binutils-
> gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
> <https://sourceware.org/git/gitweb.cgi?p=binutils-
> gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
> +
> +Upstream-Status: Backport
> +
> +Signed-off-by: Manjukumar Matha <manjukumar.harthikote-
> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> >
> +---
> + gas/ChangeLog | 10 ++++++++++
> + gas/config/tc-aarch64.c | 10 +++++++---
> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
> + gas/testsuite/gas/aarch64/pr20364.s | 28
> ++++++++++++++++++++++++++++
> + 4 files changed, 58 insertions(+), 3 deletions(-)
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
> +
> +diff --git a/gas/ChangeLog b/gas/ChangeLog
> +index a39895a..fad06dc 100644
> +--- a/gas/ChangeLog
> ++++ b/gas/ChangeLog
> +@@ -1,3 +1,13 @@
> ++2016-08-05 Nick Clifton <nickc@redhat.com
> <mailto:nickc@redhat.com> >
> ++
> ++ PR gas/20364
> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
> ++ aligning the frag.
> ++ (aarch64_init): Treat rs_align frags in code sections as
> ++ containing code, not data.
> ++ * testsuite/gas/aarch64/pr20364.s: New test.
> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
> ++
> + 2016-08-03 Tristan Gingold <gingold@adacore.com
> <mailto:gingold@adacore.com> >
> +
> + * configure: Regenerate.
> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> +index ddc40f2..74933cb 100644
> +--- a/gas/config/tc-aarch64.c
> ++++ b/gas/config/tc-aarch64.c
> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
> + if (pool == NULL || pool->symbol == NULL || pool->next_free_entry ==
> 0)
> + continue;
> +
> +- mapping_state (MAP_DATA);
> +-
> + /* Align pool as you have word accesses.
> + Only make a frag if we have to. */
> + if (!need_pass_2)
> + frag_align (align, 0, 0);
> +
> ++ mapping_state (MAP_DATA);
> ++
> + record_alignment (now_seg, align);
> +
> + sprintf (sym_name, "$$lit_\002%x", pool->id);
> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
> max_chars)
> +
> + switch (fragP->fr_type)
> + {
> +- case rs_align:
> + case rs_align_test:
> + case rs_fill:
> + mapping_state_2 (MAP_DATA, max_chars);
> + break;
> ++ case rs_align:
> ++ /* PR 20364: We can get alignment frags in code sections,
> ++ so do not just assume that we should use the MAP_DATA state. */
> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
> MAP_DATA, max_chars);
> ++ break;
> + case rs_align_code:
> + mapping_state_2 (MAP_INSN, max_chars);
> + break;
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
> b/gas/testsuite/gas/aarch64/pr20364.d
> +new file mode 100644
> +index 0000000..babcff1
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
> +@@ -0,0 +1,13 @@
> ++# Check that ".align <size>, <fill>" does not set the mapping state to
> DATA, causing unnecessary frag generation.
> ++#name: PR20364
> ++#objdump: -d
> ++
> ++.*: file format .*
> ++
> ++Disassembly of section \.vectors:
> ++
> ++0+000 <.*>:
> ++ 0: d2800000 mov x0, #0x0 // #0
> ++ 4: 94000000 bl 0 <plat_report_exception>
> ++ 8: 17fffffe b 0 <bl1_exceptions>
> ++
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
> b/gas/testsuite/gas/aarch64/pr20364.s
> +new file mode 100644
> +index 0000000..594ad7c
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
> +@@ -0,0 +1,28 @@
> ++ .macro vector_base label
> ++ .section .vectors, "ax"
> ++ .align 11, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro vector_entry label
> ++ .section .vectors, "ax"
> ++ .align 7, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro check_vector_size since
> ++ .if (. - \since) > (32 * 4)
> ++ .error "Vector exceeds 32 instructions"
> ++ .endif
> ++ .endm
> ++
> ++ .globl bl1_exceptions
> ++
> ++vector_base bl1_exceptions
> ++
> ++vector_entry SynchronousExceptionSP0
> ++ mov x0, #0x0
> ++ bl plat_report_exception
> ++ b SynchronousExceptionSP0
> ++ check_vector_size SynchronousExceptionSP0
> ++
> +--
> +2.7.4
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org <mailto:Openembedded-
> core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-12-15 22:28 ` Manjukumar Harthikote Matha
@ 2016-12-19 13:04 ` Burton, Ross
2016-12-19 13:05 ` Burton, Ross
0 siblings, 1 reply; 17+ messages in thread
From: Burton, Ross @ 2016-12-19 13:04 UTC (permalink / raw)
To: Manjukumar Harthikote Matha
Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
On 15 December 2016 at 22:28, Manjukumar Harthikote Matha <
manjukumar.harthikote-matha@xilinx.com> wrote:
> This has not been added to master, is there something wrong with the patch
> ?
>
You'd marked it for morty, so I'd assumed that it wasn't for master.
Ross
[-- Attachment #2: Type: text/html, Size: 709 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-12-19 13:04 ` Burton, Ross
@ 2016-12-19 13:05 ` Burton, Ross
2016-12-19 21:29 ` Manjukumar Harthikote Matha
0 siblings, 1 reply; 17+ messages in thread
From: Burton, Ross @ 2016-12-19 13:05 UTC (permalink / raw)
To: Manjukumar Harthikote Matha
Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
On 19 December 2016 at 13:04, Burton, Ross <ross.burton@intel.com> wrote:
> You'd marked it for morty, so I'd assumed that it wasn't for master.
>
Ah just found the master version. You can thank GMail's threading for
that. :(
Ross
[-- Attachment #2: Type: text/html, Size: 713 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-12-19 13:05 ` Burton, Ross
@ 2016-12-19 21:29 ` Manjukumar Harthikote Matha
0 siblings, 0 replies; 17+ messages in thread
From: Manjukumar Harthikote Matha @ 2016-12-19 21:29 UTC (permalink / raw)
To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer
On 12/19/2016 05:05 AM, Burton, Ross wrote:
>
> On 19 December 2016 at 13:04, Burton, Ross <ross.burton@intel.com
> <mailto:ross.burton@intel.com>> wrote:
>
> You'd marked it for morty, so I'd assumed that it wasn't for master.
>
>
> Ah just found the master version. You can thank GMail's threading for
> that. :(
>
Hi Ross,
I sent v2 to master couple of days back, because the first patch I sent
earlier wont apply cleanly on master.
Thanks
Manju
> Ross
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2016-11-22 22:03 ` Khem Raj
2016-11-22 23:08 ` Manjukumar Harthikote Matha
2016-12-15 22:28 ` Manjukumar Harthikote Matha
@ 2017-01-16 17:49 ` Manjukumar Harthikote Matha
2017-01-18 9:37 ` Mike Looijmans
2 siblings, 1 reply; 17+ messages in thread
From: Manjukumar Harthikote Matha @ 2017-01-16 17:49 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Ping, this has been applied to master
Thanks
Manju
> -----Original Message-----
> From: Khem Raj [mailto:raj.khem@gmail.com]
> Sent: Tuesday, November 22, 2016 2:03 PM
> To: Manjukumar Harthikote Matha
> Cc: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for
> aarch64
>
> This is ok for master
>
>
> On Nov 22, 2016 1:31 PM, "Manjukumar Matha" <manjukumar.harthikote-
> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> > wrote:
>
>
> There was bug with alignment frags for aarch64 in binutils. This is
> fixed in master of binutils. This patch backports the fix to binutils
> 2.27 version.
>
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-
> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> >
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
> <mailto:nathan@nathanrossi.com> >
> ---
> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
> ...eration-of-alignment-frags-in-code-sectio.patch | 139
> +++++++++++++++++++++
> 2 files changed, 140 insertions(+)
> create mode 100644 meta/recipes-devtools/binutils/binutils/0017-Fix-the-
> generation-of-alignment-frags-in-code-sectio.patch
>
> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc b/meta/recipes-
> devtools/binutils/binutils-2.27.inc
> index fc81721..90518bf 100644
> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
> @@ -37,6 +37,7 @@ SRC_URI = "\
> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch
> \
> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
> + file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> \
> "
> S = "${WORKDIR}/git"
>
> diff --git a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-
> of-alignment-frags-in-code-sectio.patch b/meta/recipes-
> devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-
> sectio.patch
> new file mode 100644
> index 0000000..f8b46be
> --- /dev/null
> +++ b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-
> alignment-frags-in-code-sectio.patch
> @@ -0,0 +1,139 @@
> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17
> 00:00:00 2001
> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com> >
> +Date: Fri, 18 Nov 2016 11:42:48 -0800
> +Subject: [PATCH] Fix the generation of alignment frags in code sections for
> AArch64.
> +
> +PR gas/20364
> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
> +aligning the frag.
> +(aarch64_init): Treat rs_align frags in code sections as
> +containing code, not data.
> +* testsuite/gas/aarch64/pr20364.s: New test.
> +* testsuite/gas/aarch64/pr20364.d: New test driver.
> +
> +Backporting the patch from binutils mainline
> +https://sourceware.org/git/gitweb.cgi?p=binutils-
> gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
> <https://sourceware.org/git/gitweb.cgi?p=binutils-
> gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
> +
> +Upstream-Status: Backport
> +
> +Signed-off-by: Manjukumar Matha <manjukumar.harthikote-
> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> >
> +---
> + gas/ChangeLog | 10 ++++++++++
> + gas/config/tc-aarch64.c | 10 +++++++---
> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
> + gas/testsuite/gas/aarch64/pr20364.s | 28
> ++++++++++++++++++++++++++++
> + 4 files changed, 58 insertions(+), 3 deletions(-)
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
> +
> +diff --git a/gas/ChangeLog b/gas/ChangeLog
> +index a39895a..fad06dc 100644
> +--- a/gas/ChangeLog
> ++++ b/gas/ChangeLog
> +@@ -1,3 +1,13 @@
> ++2016-08-05 Nick Clifton <nickc@redhat.com
> <mailto:nickc@redhat.com> >
> ++
> ++ PR gas/20364
> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
> ++ aligning the frag.
> ++ (aarch64_init): Treat rs_align frags in code sections as
> ++ containing code, not data.
> ++ * testsuite/gas/aarch64/pr20364.s: New test.
> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
> ++
> + 2016-08-03 Tristan Gingold <gingold@adacore.com
> <mailto:gingold@adacore.com> >
> +
> + * configure: Regenerate.
> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> +index ddc40f2..74933cb 100644
> +--- a/gas/config/tc-aarch64.c
> ++++ b/gas/config/tc-aarch64.c
> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
> + if (pool == NULL || pool->symbol == NULL || pool->next_free_entry ==
> 0)
> + continue;
> +
> +- mapping_state (MAP_DATA);
> +-
> + /* Align pool as you have word accesses.
> + Only make a frag if we have to. */
> + if (!need_pass_2)
> + frag_align (align, 0, 0);
> +
> ++ mapping_state (MAP_DATA);
> ++
> + record_alignment (now_seg, align);
> +
> + sprintf (sym_name, "$$lit_\002%x", pool->id);
> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
> max_chars)
> +
> + switch (fragP->fr_type)
> + {
> +- case rs_align:
> + case rs_align_test:
> + case rs_fill:
> + mapping_state_2 (MAP_DATA, max_chars);
> + break;
> ++ case rs_align:
> ++ /* PR 20364: We can get alignment frags in code sections,
> ++ so do not just assume that we should use the MAP_DATA state. */
> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
> MAP_DATA, max_chars);
> ++ break;
> + case rs_align_code:
> + mapping_state_2 (MAP_INSN, max_chars);
> + break;
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
> b/gas/testsuite/gas/aarch64/pr20364.d
> +new file mode 100644
> +index 0000000..babcff1
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
> +@@ -0,0 +1,13 @@
> ++# Check that ".align <size>, <fill>" does not set the mapping state to
> DATA, causing unnecessary frag generation.
> ++#name: PR20364
> ++#objdump: -d
> ++
> ++.*: file format .*
> ++
> ++Disassembly of section \.vectors:
> ++
> ++0+000 <.*>:
> ++ 0: d2800000 mov x0, #0x0 // #0
> ++ 4: 94000000 bl 0 <plat_report_exception>
> ++ 8: 17fffffe b 0 <bl1_exceptions>
> ++
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
> b/gas/testsuite/gas/aarch64/pr20364.s
> +new file mode 100644
> +index 0000000..594ad7c
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
> +@@ -0,0 +1,28 @@
> ++ .macro vector_base label
> ++ .section .vectors, "ax"
> ++ .align 11, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro vector_entry label
> ++ .section .vectors, "ax"
> ++ .align 7, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro check_vector_size since
> ++ .if (. - \since) > (32 * 4)
> ++ .error "Vector exceeds 32 instructions"
> ++ .endif
> ++ .endm
> ++
> ++ .globl bl1_exceptions
> ++
> ++vector_base bl1_exceptions
> ++
> ++vector_entry SynchronousExceptionSP0
> ++ mov x0, #0x0
> ++ bl plat_report_exception
> ++ b SynchronousExceptionSP0
> ++ check_vector_size SynchronousExceptionSP0
> ++
> +--
> +2.7.4
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org <mailto:Openembedded-
> core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2017-01-16 17:49 ` Manjukumar Harthikote Matha
@ 2017-01-18 9:37 ` Mike Looijmans
2017-01-18 12:08 ` Nathan Rossi
0 siblings, 1 reply; 17+ messages in thread
From: Mike Looijmans @ 2017-01-18 9:37 UTC (permalink / raw)
To: openembedded-core
Could someone at least please say "yes" or "no"?
I now have three projects waiting for this patch to be included in morty. If
it's not going to happen, I'll have to add a bbappend to these layers to fix it.
On 16-01-17 18:49, Manjukumar Harthikote Matha wrote:
> Ping, this has been applied to master
>
> Thanks
> Manju
>
>>
Kind regards,
Mike Looijmans
System Expert
TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com
Please consider the environment before printing this e-mail
-----Original Message-----
>> From: Khem Raj [mailto:raj.khem@gmail.com]
>> Sent: Tuesday, November 22, 2016 2:03 PM
>> To: Manjukumar Harthikote Matha
>> Cc: Patches and discussions about the oe-core layer
>> Subject: Re: [OE-core] [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for
>> aarch64
>>
>> This is ok for master
>>
>>
>> On Nov 22, 2016 1:31 PM, "Manjukumar Matha" <manjukumar.harthikote-
>> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> > wrote:
>>
>>
>> There was bug with alignment frags for aarch64 in binutils. This is
>> fixed in master of binutils. This patch backports the fix to binutils
>> 2.27 version.
>>
>> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-
>> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> >
>> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
>> <mailto:nathan@nathanrossi.com> >
>> ---
>> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
>> ...eration-of-alignment-frags-in-code-sectio.patch | 139
>> +++++++++++++++++++++
>> 2 files changed, 140 insertions(+)
>> create mode 100644 meta/recipes-devtools/binutils/binutils/0017-Fix-the-
>> generation-of-alignment-frags-in-code-sectio.patch
>>
>> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc b/meta/recipes-
>> devtools/binutils/binutils-2.27.inc
>> index fc81721..90518bf 100644
>> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
>> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
>> @@ -37,6 +37,7 @@ SRC_URI = "\
>> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
>> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch
>> \
>> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
>> + file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>> \
>> "
>> S = "${WORKDIR}/git"
>>
>> diff --git a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-
>> of-alignment-frags-in-code-sectio.patch b/meta/recipes-
>> devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-
>> sectio.patch
>> new file mode 100644
>> index 0000000..f8b46be
>> --- /dev/null
>> +++ b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-
>> alignment-frags-in-code-sectio.patch
>> @@ -0,0 +1,139 @@
>> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17
>> 00:00:00 2001
>> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com> >
>> +Date: Fri, 18 Nov 2016 11:42:48 -0800
>> +Subject: [PATCH] Fix the generation of alignment frags in code sections for
>> AArch64.
>> +
>> +PR gas/20364
>> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
>> +aligning the frag.
>> +(aarch64_init): Treat rs_align frags in code sections as
>> +containing code, not data.
>> +* testsuite/gas/aarch64/pr20364.s: New test.
>> +* testsuite/gas/aarch64/pr20364.d: New test driver.
>> +
>> +Backporting the patch from binutils mainline
>> +https://sourceware.org/git/gitweb.cgi?p=binutils-
>> gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
>> <https://sourceware.org/git/gitweb.cgi?p=binutils-
>> gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
>> +
>> +Upstream-Status: Backport
>> +
>> +Signed-off-by: Manjukumar Matha <manjukumar.harthikote-
>> matha@xilinx.com <mailto:manjukumar.harthikote-matha@xilinx.com> >
>> +---
>> + gas/ChangeLog | 10 ++++++++++
>> + gas/config/tc-aarch64.c | 10 +++++++---
>> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
>> + gas/testsuite/gas/aarch64/pr20364.s | 28
>> ++++++++++++++++++++++++++++
>> + 4 files changed, 58 insertions(+), 3 deletions(-)
>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
>> +
>> +diff --git a/gas/ChangeLog b/gas/ChangeLog
>> +index a39895a..fad06dc 100644
>> +--- a/gas/ChangeLog
>> ++++ b/gas/ChangeLog
>> +@@ -1,3 +1,13 @@
>> ++2016-08-05 Nick Clifton <nickc@redhat.com
>> <mailto:nickc@redhat.com> >
>> ++
>> ++ PR gas/20364
>> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
>> ++ aligning the frag.
>> ++ (aarch64_init): Treat rs_align frags in code sections as
>> ++ containing code, not data.
>> ++ * testsuite/gas/aarch64/pr20364.s: New test.
>> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
>> ++
>> + 2016-08-03 Tristan Gingold <gingold@adacore.com
>> <mailto:gingold@adacore.com> >
>> +
>> + * configure: Regenerate.
>> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
>> +index ddc40f2..74933cb 100644
>> +--- a/gas/config/tc-aarch64.c
>> ++++ b/gas/config/tc-aarch64.c
>> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
>> + if (pool == NULL || pool->symbol == NULL || pool->next_free_entry ==
>> 0)
>> + continue;
>> +
>> +- mapping_state (MAP_DATA);
>> +-
>> + /* Align pool as you have word accesses.
>> + Only make a frag if we have to. */
>> + if (!need_pass_2)
>> + frag_align (align, 0, 0);
>> +
>> ++ mapping_state (MAP_DATA);
>> ++
>> + record_alignment (now_seg, align);
>> +
>> + sprintf (sym_name, "$$lit_\002%x", pool->id);
>> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
>> max_chars)
>> +
>> + switch (fragP->fr_type)
>> + {
>> +- case rs_align:
>> + case rs_align_test:
>> + case rs_fill:
>> + mapping_state_2 (MAP_DATA, max_chars);
>> + break;
>> ++ case rs_align:
>> ++ /* PR 20364: We can get alignment frags in code sections,
>> ++ so do not just assume that we should use the MAP_DATA state. */
>> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
>> MAP_DATA, max_chars);
>> ++ break;
>> + case rs_align_code:
>> + mapping_state_2 (MAP_INSN, max_chars);
>> + break;
>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
>> b/gas/testsuite/gas/aarch64/pr20364.d
>> +new file mode 100644
>> +index 0000000..babcff1
>> +--- /dev/null
>> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
>> +@@ -0,0 +1,13 @@
>> ++# Check that ".align <size>, <fill>" does not set the mapping state to
>> DATA, causing unnecessary frag generation.
>> ++#name: PR20364
>> ++#objdump: -d
>> ++
>> ++.*: file format .*
>> ++
>> ++Disassembly of section \.vectors:
>> ++
>> ++0+000 <.*>:
>> ++ 0: d2800000 mov x0, #0x0 // #0
>> ++ 4: 94000000 bl 0 <plat_report_exception>
>> ++ 8: 17fffffe b 0 <bl1_exceptions>
>> ++
>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
>> b/gas/testsuite/gas/aarch64/pr20364.s
>> +new file mode 100644
>> +index 0000000..594ad7c
>> +--- /dev/null
>> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
>> +@@ -0,0 +1,28 @@
>> ++ .macro vector_base label
>> ++ .section .vectors, "ax"
>> ++ .align 11, 0
>> ++ \label:
>> ++ .endm
>> ++
>> ++ .macro vector_entry label
>> ++ .section .vectors, "ax"
>> ++ .align 7, 0
>> ++ \label:
>> ++ .endm
>> ++
>> ++ .macro check_vector_size since
>> ++ .if (. - \since) > (32 * 4)
>> ++ .error "Vector exceeds 32 instructions"
>> ++ .endif
>> ++ .endm
>> ++
>> ++ .globl bl1_exceptions
>> ++
>> ++vector_base bl1_exceptions
>> ++
>> ++vector_entry SynchronousExceptionSP0
>> ++ mov x0, #0x0
>> ++ bl plat_report_exception
>> ++ b SynchronousExceptionSP0
>> ++ check_vector_size SynchronousExceptionSP0
>> ++
>> +--
>> +2.7.4
>> +
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org <mailto:Openembedded-
>> core@lists.openembedded.org>
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>>
>
>
>
> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2017-01-18 9:37 ` Mike Looijmans
@ 2017-01-18 12:08 ` Nathan Rossi
2017-01-18 16:09 ` akuster808
0 siblings, 1 reply; 17+ messages in thread
From: Nathan Rossi @ 2017-01-18 12:08 UTC (permalink / raw)
To: Armin Kuster; +Cc: Mike Looijmans, openembedded-core
On 18 January 2017 at 19:37, Mike Looijmans <mike.looijmans@topic.nl> wrote:
> Could someone at least please say "yes" or "no"?
>
> I now have three projects waiting for this patch to be included in morty. If
> it's not going to happen, I'll have to add a bbappend to these layers to fix
> it.
>
> On 16-01-17 18:49, Manjukumar Harthikote Matha wrote:
>>
>> Ping, this has been applied to master
Armin, you mentioned on IRC ~1 week ago that you had merged it to your
staging branch? Any updates?
Also I had a look and could not find the change in
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=akuster/morty-next?
Maybe I am looking in the wrong place though for your staging tree?
Thanks,
Nathan
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2017-01-18 12:08 ` Nathan Rossi
@ 2017-01-18 16:09 ` akuster808
2017-01-18 20:16 ` Manjukumar Harthikote Matha
2017-01-24 6:48 ` Mike Looijmans
0 siblings, 2 replies; 17+ messages in thread
From: akuster808 @ 2017-01-18 16:09 UTC (permalink / raw)
To: Nathan Rossi; +Cc: Mike Looijmans, openembedded-core
On 01/18/2017 04:08 AM, Nathan Rossi wrote:
> On 18 January 2017 at 19:37, Mike Looijmans <mike.looijmans@topic.nl> wrote:
>> Could someone at least please say "yes" or "no"?
>>
>> I now have three projects waiting for this patch to be included in morty. If
>> it's not going to happen, I'll have to add a bbappend to these layers to fix
>> it.
>>
>> On 16-01-17 18:49, Manjukumar Harthikote Matha wrote:
>>> Ping, this has been applied to master
> Armin, you mentioned on IRC ~1 week ago that you had merged it to your
> staging branch? Any updates?
> Also I had a look and could not find the change in
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=akuster/morty-next?
> Maybe I am looking in the wrong place though for your staging tree?
I forgot to press go. Its there now.
- armin
>
> Thanks,
> Nathan
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2017-01-18 16:09 ` akuster808
@ 2017-01-18 20:16 ` Manjukumar Harthikote Matha
2017-01-24 6:48 ` Mike Looijmans
1 sibling, 0 replies; 17+ messages in thread
From: Manjukumar Harthikote Matha @ 2017-01-18 20:16 UTC (permalink / raw)
To: akuster808, Nathan Rossi; +Cc: Mike Looijmans, openembedded-core
> -----Original Message-----
> From: akuster808 [mailto:akuster808@gmail.com]
> Sent: Wednesday, January 18, 2017 8:09 AM
> To: Nathan Rossi
> Cc: openembedded-core@lists.openembedded.org; Manjukumar Harthikote Matha;
> Mike Looijmans
> Subject: Re: [OE-core] [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for
> aarch64
>
>
>
> On 01/18/2017 04:08 AM, Nathan Rossi wrote:
> > On 18 January 2017 at 19:37, Mike Looijmans <mike.looijmans@topic.nl> wrote:
> >> Could someone at least please say "yes" or "no"?
> >>
> >> I now have three projects waiting for this patch to be included in
> >> morty. If it's not going to happen, I'll have to add a bbappend to
> >> these layers to fix it.
> >>
> >> On 16-01-17 18:49, Manjukumar Harthikote Matha wrote:
> >>> Ping, this has been applied to master
> > Armin, you mentioned on IRC ~1 week ago that you had merged it to your
> > staging branch? Any updates?
> > Also I had a look and could not find the change in
> > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=akuster/morty-next?
> > Maybe I am looking in the wrong place though for your staging tree?
> I forgot to press go. Its there now.
>
Hi Armin
Thanks, appreciate it.
Thanks
Manju
> - armin
> >
> > Thanks,
> > Nathan
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2017-01-18 16:09 ` akuster808
2017-01-18 20:16 ` Manjukumar Harthikote Matha
@ 2017-01-24 6:48 ` Mike Looijmans
2017-01-24 15:45 ` akuster808
1 sibling, 1 reply; 17+ messages in thread
From: Mike Looijmans @ 2017-01-24 6:48 UTC (permalink / raw)
To: akuster808, Nathan Rossi; +Cc: openembedded-core
On 18-01-17 17:09, akuster808 wrote:
>
>
> On 01/18/2017 04:08 AM, Nathan Rossi wrote:
>> On 18 January 2017 at 19:37, Mike Looijmans <mike.looijmans@topic.nl> wrote:
>>> Could someone at least please say "yes" or "no"?
>>>
>>> I now have three projects waiting for this patch to be included in morty. If
>>> it's not going to happen, I'll have to add a bbappend to these layers to fix
>>> it.
>>>
>>> On 16-01-17 18:49, Manjukumar Harthikote Matha wrote:
>>>> Ping, this has been applied to master
>> Armin, you mentioned on IRC ~1 week ago that you had merged it to your
>> staging branch? Any updates?
>> Also I had a look and could not find the change in
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=akuster/morty-next?
>>
>> Maybe I am looking in the wrong place though for your staging tree?
> I forgot to press go. Its there now.
Much appreciated.
Who's next in line to press "go" now? I still have three projects waiting.
Apparently the ARM64 isn't very popular, no one seems to care about its build
failures...
Kind regards,
Mike Looijmans
System Expert
TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com
Please consider the environment before printing this e-mail
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2017-01-24 6:48 ` Mike Looijmans
@ 2017-01-24 15:45 ` akuster808
2017-01-30 7:18 ` Mike Looijmans
0 siblings, 1 reply; 17+ messages in thread
From: akuster808 @ 2017-01-24 15:45 UTC (permalink / raw)
To: Mike Looijmans, Nathan Rossi; +Cc: openembedded-core
On 01/23/2017 10:48 PM, Mike Looijmans wrote:
> On 18-01-17 17:09, akuster808 wrote:
>>
>>
>> On 01/18/2017 04:08 AM, Nathan Rossi wrote:
>>> On 18 January 2017 at 19:37, Mike Looijmans
>>> <mike.looijmans@topic.nl> wrote:
>>>> Could someone at least please say "yes" or "no"?
>>>>
>>>> I now have three projects waiting for this patch to be included in
>>>> morty. If
>>>> it's not going to happen, I'll have to add a bbappend to these
>>>> layers to fix
>>>> it.
>>>>
>>>> On 16-01-17 18:49, Manjukumar Harthikote Matha wrote:
>>>>> Ping, this has been applied to master
>>> Armin, you mentioned on IRC ~1 week ago that you had merged it to your
>>> staging branch? Any updates?
>>> Also I had a look and could not find the change in
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=akuster/morty-next?
>>>
>>>
>>> Maybe I am looking in the wrong place though for your staging tree?
>> I forgot to press go. Its there now.
>
> Much appreciated.
>
> Who's next in line to press "go" now? I still have three projects
> waiting.
Richard or one of his minions.
>
> Apparently the ARM64 isn't very popular, no one seems to care about
> its build failures...
>
>
>
> Kind regards,
>
> Mike Looijmans
> System Expert
>
> TOPIC Products
> Materiaalweg 4, NL-5681 RJ Best
> Postbus 440, NL-5680 AK Best
> Telefoon: +31 (0) 499 33 69 79
> E-mail: mike.looijmans@topicproducts.com
> Website: www.topicproducts.com
>
> Please consider the environment before printing this e-mail
>
>
>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
2017-01-24 15:45 ` akuster808
@ 2017-01-30 7:18 ` Mike Looijmans
0 siblings, 0 replies; 17+ messages in thread
From: Mike Looijmans @ 2017-01-30 7:18 UTC (permalink / raw)
To: openembedded-core
On 24-01-17 16:45, akuster808 wrote:
>
>
> On 01/23/2017 10:48 PM, Mike Looijmans wrote:
>> On 18-01-17 17:09, akuster808 wrote:
>>>
>>>
>>> On 01/18/2017 04:08 AM, Nathan Rossi wrote:
>>>> On 18 January 2017 at 19:37, Mike Looijmans <mike.looijmans@topic.nl> wrote:
>>>>> Could someone at least please say "yes" or "no"?
>>>>>
>>>>> I now have three projects waiting for this patch to be included in morty. If
>>>>> it's not going to happen, I'll have to add a bbappend to these layers to fix
>>>>> it.
>>>>>
>>>>> On 16-01-17 18:49, Manjukumar Harthikote Matha wrote:
>>>>>> Ping, this has been applied to master
>>>> Armin, you mentioned on IRC ~1 week ago that you had merged it to your
>>>> staging branch? Any updates?
>>>> Also I had a look and could not find the change in
>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=akuster/morty-next?
>>>>
>>>>
>>>> Maybe I am looking in the wrong place though for your staging tree?
>>> I forgot to press go. Its there now.
>>
>> Much appreciated.
>>
>> Who's next in line to press "go" now? I still have three projects waiting.
> Richard or one of his minions.
>
Ping... please?
Kind regards,
Mike Looijmans
System Expert
TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com
Please consider the environment before printing this e-mail
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2017-01-30 7:18 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-22 21:01 [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64 Manjukumar Matha
2016-11-22 22:03 ` Khem Raj
2016-11-22 23:08 ` Manjukumar Harthikote Matha
2016-11-22 23:36 ` Khem Raj
2016-11-22 23:36 ` Manjukumar Harthikote Matha
2016-12-15 22:28 ` Manjukumar Harthikote Matha
2016-12-19 13:04 ` Burton, Ross
2016-12-19 13:05 ` Burton, Ross
2016-12-19 21:29 ` Manjukumar Harthikote Matha
2017-01-16 17:49 ` Manjukumar Harthikote Matha
2017-01-18 9:37 ` Mike Looijmans
2017-01-18 12:08 ` Nathan Rossi
2017-01-18 16:09 ` akuster808
2017-01-18 20:16 ` Manjukumar Harthikote Matha
2017-01-24 6:48 ` Mike Looijmans
2017-01-24 15:45 ` akuster808
2017-01-30 7:18 ` Mike Looijmans
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.