* [PATCH 1/3] staging: vt6655: line over 80 characters
@ 2019-03-21 21:39 Vatsala Narang
2019-03-22 14:14 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Vatsala Narang @ 2019-03-21 21:39 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Vatsala Narang
Move function arguments thet go over 80 characters a line limit to a new
line to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
drivers/staging/vt6655/rf.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index fd09b9771cf5..8d1caa4b19e8 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -737,7 +737,8 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
return false;
}
- MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX, (unsigned long)MAKEWORD(bySleepCount, byInitCount));
+ MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX, (unsigned long)MAKEWORD
+ (bySleepCount, byInitCount));
return true;
}
@@ -933,7 +934,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
* register
* Channel Index 1~14
*/
- if ((byOldChannel <= CB_MAX_CHANNEL_24G) && (byNewChannel > CB_MAX_CHANNEL_24G)) {
+ if ((byOldChannel <= CB_MAX_CHANNEL_24G) &&
+ (byNewChannel > CB_MAX_CHANNEL_24G)) {
/* Change from 2.4G to 5G [Reg] */
ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[2]);
ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[3]);
@@ -942,7 +944,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[10]);
ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[12]);
ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[15]);
- } else if ((byOldChannel > CB_MAX_CHANNEL_24G) && (byNewChannel <= CB_MAX_CHANNEL_24G)) {
+ } else if ((byOldChannel > CB_MAX_CHANNEL_24G) &&
+ (byNewChannel <= CB_MAX_CHANNEL_24G)) {
/* Change from 5G to 2.4G [Reg] */
ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[2]);
ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[3]);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] staging: vt6655: line over 80 characters
2019-03-21 21:39 [PATCH 1/3] staging: vt6655: line over 80 characters Vatsala Narang
@ 2019-03-22 14:14 ` Greg KH
2019-03-22 14:31 ` [Outreachy kernel] " Julia Lawall
2019-03-22 14:34 ` Vatsala Narang
0 siblings, 2 replies; 4+ messages in thread
From: Greg KH @ 2019-03-22 14:14 UTC (permalink / raw)
To: Vatsala Narang; +Cc: outreachy-kernel
On Fri, Mar 22, 2019 at 03:09:06AM +0530, Vatsala Narang wrote:
> Move function arguments thet go over 80 characters a line limit to a new
> line to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> drivers/staging/vt6655/rf.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index fd09b9771cf5..8d1caa4b19e8 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -737,7 +737,8 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
> return false;
> }
>
> - MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX, (unsigned long)MAKEWORD(bySleepCount, byInitCount));
> + MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX, (unsigned long)MAKEWORD
> + (bySleepCount, byInitCount));
This should go one character to the left, to line up with the "priv"
above it.
>
> return true;
> }
> @@ -933,7 +934,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
> * register
> * Channel Index 1~14
> */
> - if ((byOldChannel <= CB_MAX_CHANNEL_24G) && (byNewChannel > CB_MAX_CHANNEL_24G)) {
> + if ((byOldChannel <= CB_MAX_CHANNEL_24G) &&
> + (byNewChannel > CB_MAX_CHANNEL_24G)) {
This is good.
> /* Change from 2.4G to 5G [Reg] */
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[2]);
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[3]);
> @@ -942,7 +944,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[10]);
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[12]);
> ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[15]);
> - } else if ((byOldChannel > CB_MAX_CHANNEL_24G) && (byNewChannel <= CB_MAX_CHANNEL_24G)) {
> + } else if ((byOldChannel > CB_MAX_CHANNEL_24G) &&
> + (byNewChannel <= CB_MAX_CHANNEL_24G)) {
This needs to line up like the other one does.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] Re: [PATCH 1/3] staging: vt6655: line over 80 characters
2019-03-22 14:14 ` Greg KH
@ 2019-03-22 14:31 ` Julia Lawall
2019-03-22 14:34 ` Vatsala Narang
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2019-03-22 14:31 UTC (permalink / raw)
To: Greg KH; +Cc: Vatsala Narang, outreachy-kernel
On Fri, 22 Mar 2019, Greg KH wrote:
> On Fri, Mar 22, 2019 at 03:09:06AM +0530, Vatsala Narang wrote:
> > Move function arguments thet go over 80 characters a line limit to a new
> > line to get rid of checkpatch warning.
> >
> > Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> > ---
> > drivers/staging/vt6655/rf.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> > index fd09b9771cf5..8d1caa4b19e8 100644
> > --- a/drivers/staging/vt6655/rf.c
> > +++ b/drivers/staging/vt6655/rf.c
> > @@ -737,7 +737,8 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
> > return false;
> > }
> >
> > - MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX, (unsigned long)MAKEWORD(bySleepCount, byInitCount));
> > + MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX, (unsigned long)MAKEWORD
> > + (bySleepCount, byInitCount));
>
> This should go one character to the left, to line up with the "priv"
> above it.
Actually, this one breaks up a function (or macro) call and its arguments,
It would be better to put the newline after the previous , instead. The
indentation looks ok, in the patch at least.
julia
>
> >
> > return true;
> > }
> > @@ -933,7 +934,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
> > * register
> > * Channel Index 1~14
> > */
> > - if ((byOldChannel <= CB_MAX_CHANNEL_24G) && (byNewChannel > CB_MAX_CHANNEL_24G)) {
> > + if ((byOldChannel <= CB_MAX_CHANNEL_24G) &&
> > + (byNewChannel > CB_MAX_CHANNEL_24G)) {
>
> This is good.
>
> > /* Change from 2.4G to 5G [Reg] */
> > ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[2]);
> > ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[3]);
> > @@ -942,7 +944,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
> > ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[10]);
> > ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[12]);
> > ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[15]);
> > - } else if ((byOldChannel > CB_MAX_CHANNEL_24G) && (byNewChannel <= CB_MAX_CHANNEL_24G)) {
> > + } else if ((byOldChannel > CB_MAX_CHANNEL_24G) &&
> > + (byNewChannel <= CB_MAX_CHANNEL_24G)) {
>
> This needs to line up like the other one does.
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190322141421.GA25959%40kroah.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] staging: vt6655: line over 80 characters
2019-03-22 14:14 ` Greg KH
2019-03-22 14:31 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-22 14:34 ` Vatsala Narang
1 sibling, 0 replies; 4+ messages in thread
From: Vatsala Narang @ 2019-03-22 14:34 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 383 bytes --]
>
> > - } else if ((byOldChannel > CB_MAX_CHANNEL_24G) && (byNewChannel
> <= CB_MAX_CHANNEL_24G)) {
> > + } else if ((byOldChannel > CB_MAX_CHANNEL_24G) &&
> > + (byNewChannel <= CB_MAX_CHANNEL_24G)) {
>
> This needs to line up like the other one does.
>
> thanks,
>
> greg k-h
>
okay I will add these changes in v2
thanks,
Vatsala
[-- Attachment #1.2: Type: text/html, Size: 688 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-22 14:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 21:39 [PATCH 1/3] staging: vt6655: line over 80 characters Vatsala Narang
2019-03-22 14:14 ` Greg KH
2019-03-22 14:31 ` [Outreachy kernel] " Julia Lawall
2019-03-22 14:34 ` Vatsala Narang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.