Re: [PATCH v2 0/8] drm/rockchip: hdmi support for rk3328

[Robin Murphy <robin.murphy@arm.com>]

On 16/02/18 20:41, Heiko Stuebner wrote:
> The rk3228/rk3229 and rk3328 socs started using a new type of hdmi-phy
> from Innosilicon that resides completely separate from the dw-hdmi block
> and gets accessed via mmio.
> 
> Additionally the rk3328 dw-hdmi does not report the vendor-phy type
> but a different one instead, so add the possibility to override the
> phy type when the glue driver knows better than the ip block itself.
> 
> 
> I've put both the phy driver and dw-hdmi changes into one series just
> to showcase how everything comes together, but would of course still
> expect things to go through the separate phy and drm trees once deemed
> ready.
> 
> So patches 1+2 are expected to go through the phy-tree and the rest
> should go through the drm tree.

For patches 2, 3, 4, 6, 7, 8,

Tested-by: Robin Murphy <robin.murphy@arm.com>

> changes in v2:
> - phy: prevent overflow in tmdsclk calculation
>    as reported by Martin Cerveny
> - phy: use unsigned long for all tmdsclk rate uses
> - phy: simplify tmds rate calculation
> 
> - dropped patch exporting some dw-hdmi phy functions
>    as a similar patch entered drm-misc already
> 
> Heiko Stuebner (6):
>    drm/bridge: dw-hdmi: allow overriding of phy-type reading
>    drm/rockchip: dw_hdmi: Allow outputs that don't need output switching
>    dt-bindings: allow optional phys in Rockchip dw_hdmi binding
>    drm/rockchip: dw_hdmi: allow including external phys
>    drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data
>      object
>    drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328
> 
> Zheng Yang (2):
>    dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP
>    phy: add Rockchip Innosilicon hdmi phy
> 
>   .../bindings/display/rockchip/dw_hdmi-rockchip.txt |    3 +
>   .../bindings/phy/phy-rockchip-inno-hdmi.txt        |   42 +
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c          |    4 +-
>   drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c        |  130 ++-
>   drivers/phy/rockchip/Kconfig                       |    7 +
>   drivers/phy/rockchip/Makefile                      |    1 +
>   drivers/phy/rockchip/phy-rockchip-inno-hdmi.c      | 1209 ++++++++++++++++++++
>   include/drm/bridge/dw_hdmi.h                       |    1 +
>   8 files changed, 1393 insertions(+), 4 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-inno-hdmi.txt
>   create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-hdmi.c
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel