From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@analog.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"lee@kernel.org" <lee@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"sre@kernel.org" <sre@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH v2 5/8] dt-bindings: power: supply: max77658: Add ADI MAX77658 Battery
Date: Tue, 2 May 2023 08:33:20 +0200 [thread overview]
Message-ID: <1f520e8a-7785-f4dc-2f9b-d6afd1e3f671@linaro.org> (raw)
In-Reply-To: <MN2PR03MB5197BC6AEE58EFE098AF08358B6E9@MN2PR03MB5197.namprd03.prod.outlook.com>
On 01/05/2023 22:20, Arslanbenzer, Zeynep wrote:
>> You already said it above.
>>
>>> + in battery.yaml, with the following properties being required:
>>> + - alert-celsius
>>> +
>>> +required:
>>> + - compatible
>>
>> Why reg and monitored-batter are not required?
>>
> If no monitored-battery information is supplied, we set default values for alert-celsius.
So the device can operate without battery? Interesting... are you sure,
you can physically remove battery and device will work?
> The reg property is the I2C address of the device and it is part of the parent schema. Therefore, both are not required in this file.
What does it mean "in parent schema"? You have reg here, so how parent
schema is related to this?
Since you did not reply, I assume all other comments will be implemented.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-02 6:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 5:56 [PATCH v2 0/8] Add MAX77643/MAX77654/MAX77658/MAX77659 PMIC Support Zeynep Arslanbenzer
2023-03-22 5:56 ` [PATCH v2 1/8] dt-bindings: regulator: max77658: Add ADI MAX77643/54/58/59 Regulator Zeynep Arslanbenzer
2023-03-22 8:24 ` Krzysztof Kozlowski
2023-03-22 5:56 ` [PATCH v2 2/8] regulator: max77658: Add ADI MAX77643/54/58/59 Regulator Support Zeynep Arslanbenzer
2023-03-22 8:25 ` Krzysztof Kozlowski
2023-05-02 6:32 ` Arslanbenzer, Zeynep
2023-05-02 6:36 ` Krzysztof Kozlowski
2023-05-04 10:36 ` Arslanbenzer, Zeynep
2023-05-04 10:45 ` Krzysztof Kozlowski
2023-03-22 5:56 ` [PATCH v2 3/8] dt-bindings: power: supply: max77658: Add ADI MAX77654/58/59 Charger Zeynep Arslanbenzer
2023-03-22 8:26 ` Krzysztof Kozlowski
2023-04-17 10:12 ` Arslanbenzer, Zeynep
2023-03-22 5:56 ` [PATCH v2 4/8] power: supply: max77658: Add ADI MAX77654/58/59 Charger Support Zeynep Arslanbenzer
2023-03-22 5:56 ` [PATCH v2 5/8] dt-bindings: power: supply: max77658: Add ADI MAX77658 Battery Zeynep Arslanbenzer
2023-03-22 8:30 ` Krzysztof Kozlowski
2023-05-01 20:20 ` Arslanbenzer, Zeynep
2023-05-02 6:33 ` Krzysztof Kozlowski [this message]
2023-05-02 15:05 ` Arslanbenzer, Zeynep
2023-05-02 17:13 ` Krzysztof Kozlowski
2023-03-22 5:56 ` [PATCH v2 6/8] power: supply: max77658: Add ADI MAX77658 Battery Support Zeynep Arslanbenzer
2023-03-22 5:56 ` [PATCH v2 7/8] dt-bindings: mfd: max77658: Add ADI MAX77658 Zeynep Arslanbenzer
2023-03-22 8:33 ` Krzysztof Kozlowski
2023-03-22 5:56 ` [PATCH v2 8/8] mfd: max77658: Add ADI MAX77643/54/58/59 MFD Support Zeynep Arslanbenzer
2023-03-30 12:31 ` Lee Jones
2023-04-17 9:44 ` Arslanbenzer, Zeynep
2023-04-23 21:16 ` Arslanbenzer, Zeynep
2023-04-24 8:59 ` Lee Jones
2023-04-25 22:03 ` Arslanbenzer, Zeynep
2023-04-26 14:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f520e8a-7785-f4dc-2f9b-d6afd1e3f671@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.