Re: [PATCH v2 8/8] mfd: max77658: Add ADI MAX77643/54/58/59 MFD Support

From: Lee Jones <lee@kernel.org>
To: "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@analog.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"sre@kernel.org" <sre@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 8/8] mfd: max77658: Add ADI MAX77643/54/58/59 MFD Support
Date: Wed, 26 Apr 2023 15:32:31 +0100	[thread overview]
Message-ID: <20230426143231.GP50521@google.com> (raw)
In-Reply-To: <MN2PR03MB51973EDD4FEDA00200B61C6A8B649@MN2PR03MB5197.namprd03.prod.outlook.com>

On Tue, 25 Apr 2023, Arslanbenzer, Zeynep wrote:

> On Mon, 24 Apr 2023, Lee Jones wrote:
> >
> >On Sun, 23 Apr 2023, Arslanbenzer, Zeynep wrote:
> >
> >> On Thu, 30 Mar 2023, Lee Jones wrote:
> >> 
> >> >On Wed, 22 Mar 2023, Zeynep Arslanbenzer wrote:
> >> >
> >> >> MFD driver for MAX77643/MAX77654/MAX77658/MAX77659 to enable its 
> >> >> sub
> >> >
> >> >Please drop all references to 'MFD'.
> >> >
> >> >What are these devices, really?  I suspect they are PMICs?
> >> >
> >> >> devices.
> >> >>
> >> >> The MAX77643 is a multi-function devices. It includes regulator.
> >> >>
> >> >> The MAX77654 is a multi-function devices. It includes regulator and 
> >> >> charger.
> >> >>
> >> >> The MAX77658 is a multi-function devices. It includes regulator, 
> >> >> charger and battery.
> >> >>
> >> >> The MAX77659 is a multi-function devices. It includes regulator and 
> >> >> charger.
> >> >>
> >> >> Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com>
> >> >> Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> >> >> ---
> >> >>  drivers/mfd/Kconfig          |  15 ++
> >> >>  drivers/mfd/Makefile         |   1 +
> >> >>  drivers/mfd/max77658.c       | 448 +++++++++++++++++++++++++++++++++++
> >> >>  include/linux/mfd/max77658.h |  88 +++++++
> >> >>  4 files changed, 552 insertions(+)  create mode 100644 
> >> >> drivers/mfd/max77658.c  create mode 100644 
> >> >> include/linux/mfd/max77658.h
> >> >>
> >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index
> >> >> 8b93856de432..7b4be7fb8662 100644
> >> >> --- a/drivers/mfd/Kconfig
> >> >> +++ b/drivers/mfd/Kconfig
> >> >> @@ -821,6 +821,21 @@ config MFD_MAX77650
> >> >>  	  the following functionalities of the device: GPIO, regulator,
> >> >>  	  charger, LED, onkey.
> >> >>
> >> >> +config MFD_MAX77658
> >> >> +	tristate "Analog Devices MAX77643/MAX77654/MAX77658/MAX77659 PMIC Support"
> >> >> +	depends on I2C
> >> >> +	depends on OF
> >> >> +	select MFD_CORE
> >> >> +	select REGMAP_I2C
> >> >> +	select REGMAP_IRQ
> >> >> +	help
> >> >> +	  Say Y here to add support for Analog Devices
> >> >> +	  MAX77643/MAX77654/MAX77658/MAX77659 Power Management IC.
> >> >
> >> >"MAX776xx series"?
> >> 
> >> As I realized later, max77620, max77650, max77686, and max77693 drivers were merged to Linux before our patch. They are also PMIC devices and our patch does not cover them. Therefore, I think it would not be appropriate to use MAX776xx.
> >
> >Perhaps you can come up with something a little more scalable then.
> >
> >What if you added support for another 10 devices?
> >
> For now, we have no plans to add any new device support to this driver. We named the driver max77658 because it has the most inclusive feature among the supported devices. We can shorten it to MAX77643/54/58/59 or just type max77658 in Kconfig and specify other supported devices in the device tree. Would one of these be a more suitable solution?

The former looks like a nice middle-ground.

-- 
Lee Jones [李琼斯]