* [PATCH -next] ibmvnic: remove set but not used variable 'netdev'
@ 2019-04-03 7:54 ` Yue Haibing
0 siblings, 0 replies; 6+ messages in thread
From: Yue Haibing @ 2019-04-03 7:54 UTC (permalink / raw)
To: davem, benh, paulus, mpe, tlfalcon, jallen
Cc: linux-kernel, netdev, linuxppc-dev, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/ibm/ibmvnic.c: In function '__ibmvnic_reset':
drivers/net/ethernet/ibm/ibmvnic.c:1971:21: warning: variable 'netdev' set but not used [-Wunused-but-set-variable]
It's never used since introduction in
commit ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 25b8e04..20c4e08 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1968,13 +1968,11 @@ static void __ibmvnic_reset(struct work_struct *work)
{
struct ibmvnic_rwi *rwi;
struct ibmvnic_adapter *adapter;
- struct net_device *netdev;
bool we_lock_rtnl = false;
u32 reset_state;
int rc = 0;
adapter = container_of(work, struct ibmvnic_adapter, ibmvnic_reset);
- netdev = adapter->netdev;
/* netif_set_real_num_xx_queues needs to take rtnl lock here
* unless wait_for_reset is set, in which case the rtnl lock
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] ibmvnic: remove set but not used variable 'netdev'
@ 2019-04-03 7:54 ` Yue Haibing
0 siblings, 0 replies; 6+ messages in thread
From: Yue Haibing @ 2019-04-03 7:54 UTC (permalink / raw)
To: davem, benh, paulus, mpe, tlfalcon, jallen
Cc: netdev, YueHaibing, linuxppc-dev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/ibm/ibmvnic.c: In function '__ibmvnic_reset':
drivers/net/ethernet/ibm/ibmvnic.c:1971:21: warning: variable 'netdev' set but not used [-Wunused-but-set-variable]
It's never used since introduction in
commit ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 25b8e04..20c4e08 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1968,13 +1968,11 @@ static void __ibmvnic_reset(struct work_struct *work)
{
struct ibmvnic_rwi *rwi;
struct ibmvnic_adapter *adapter;
- struct net_device *netdev;
bool we_lock_rtnl = false;
u32 reset_state;
int rc = 0;
adapter = container_of(work, struct ibmvnic_adapter, ibmvnic_reset);
- netdev = adapter->netdev;
/* netif_set_real_num_xx_queues needs to take rtnl lock here
* unless wait_for_reset is set, in which case the rtnl lock
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ibmvnic: remove set but not used variable 'netdev'
2019-04-03 7:54 ` Yue Haibing
@ 2019-04-03 9:06 ` Mukesh Ojha
-1 siblings, 0 replies; 6+ messages in thread
From: Mukesh Ojha @ 2019-04-03 9:06 UTC (permalink / raw)
To: Yue Haibing, davem, benh, paulus, mpe, tlfalcon, jallen
Cc: linux-kernel, netdev, linuxppc-dev
On 4/3/2019 1:24 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/ibm/ibmvnic.c: In function '__ibmvnic_reset':
> drivers/net/ethernet/ibm/ibmvnic.c:1971:21: warning: variable 'netdev' set but not used [-Wunused-but-set-variable]
>
> It's never used since introduction in
> commit ed651a10875f ("ibmvnic: Updated reset handling")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/net/ethernet/ibm/ibmvnic.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 25b8e04..20c4e08 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -1968,13 +1968,11 @@ static void __ibmvnic_reset(struct work_struct *work)
> {
> struct ibmvnic_rwi *rwi;
> struct ibmvnic_adapter *adapter;
> - struct net_device *netdev;
> bool we_lock_rtnl = false;
> u32 reset_state;
> int rc = 0;
>
> adapter = container_of(work, struct ibmvnic_adapter, ibmvnic_reset);
> - netdev = adapter->netdev;
>
> /* netif_set_real_num_xx_queues needs to take rtnl lock here
> * unless wait_for_reset is set, in which case the rtnl lock
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ibmvnic: remove set but not used variable 'netdev'
@ 2019-04-03 9:06 ` Mukesh Ojha
0 siblings, 0 replies; 6+ messages in thread
From: Mukesh Ojha @ 2019-04-03 9:06 UTC (permalink / raw)
To: Yue Haibing, davem, benh, paulus, mpe, tlfalcon, jallen
Cc: netdev, linuxppc-dev, linux-kernel
On 4/3/2019 1:24 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/ibm/ibmvnic.c: In function '__ibmvnic_reset':
> drivers/net/ethernet/ibm/ibmvnic.c:1971:21: warning: variable 'netdev' set but not used [-Wunused-but-set-variable]
>
> It's never used since introduction in
> commit ed651a10875f ("ibmvnic: Updated reset handling")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/net/ethernet/ibm/ibmvnic.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 25b8e04..20c4e08 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -1968,13 +1968,11 @@ static void __ibmvnic_reset(struct work_struct *work)
> {
> struct ibmvnic_rwi *rwi;
> struct ibmvnic_adapter *adapter;
> - struct net_device *netdev;
> bool we_lock_rtnl = false;
> u32 reset_state;
> int rc = 0;
>
> adapter = container_of(work, struct ibmvnic_adapter, ibmvnic_reset);
> - netdev = adapter->netdev;
>
> /* netif_set_real_num_xx_queues needs to take rtnl lock here
> * unless wait_for_reset is set, in which case the rtnl lock
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ibmvnic: remove set but not used variable 'netdev'
2019-04-03 7:54 ` Yue Haibing
@ 2019-04-05 0:37 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-04-05 0:37 UTC (permalink / raw)
To: yuehaibing
Cc: benh, paulus, mpe, tlfalcon, jallen, linux-kernel, netdev, linuxppc-dev
From: Yue Haibing <yuehaibing@huawei.com>
Date: Wed, 3 Apr 2019 15:54:09 +0800
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/ibm/ibmvnic.c: In function '__ibmvnic_reset':
> drivers/net/ethernet/ibm/ibmvnic.c:1971:21: warning: variable 'netdev' set but not used [-Wunused-but-set-variable]
>
> It's never used since introduction in
> commit ed651a10875f ("ibmvnic: Updated reset handling")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ibmvnic: remove set but not used variable 'netdev'
@ 2019-04-05 0:37 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-04-05 0:37 UTC (permalink / raw)
To: yuehaibing; +Cc: linux-kernel, tlfalcon, netdev, paulus, jallen, linuxppc-dev
From: Yue Haibing <yuehaibing@huawei.com>
Date: Wed, 3 Apr 2019 15:54:09 +0800
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/ibm/ibmvnic.c: In function '__ibmvnic_reset':
> drivers/net/ethernet/ibm/ibmvnic.c:1971:21: warning: variable 'netdev' set but not used [-Wunused-but-set-variable]
>
> It's never used since introduction in
> commit ed651a10875f ("ibmvnic: Updated reset handling")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-05 0:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03 7:54 [PATCH -next] ibmvnic: remove set but not used variable 'netdev' Yue Haibing
2019-04-03 7:54 ` Yue Haibing
2019-04-03 9:06 ` Mukesh Ojha
2019-04-03 9:06 ` Mukesh Ojha
2019-04-05 0:37 ` David Miller
2019-04-05 0:37 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.