* [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
@ 2019-12-13 10:33 ` Jerome Brunet
0 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2019-12-13 10:33 UTC (permalink / raw)
To: Neil Armstrong
Cc: Jerome Brunet, Kevin Hilman, linux-amlogic, linux-clk,
linux-kernel, Dmitry Shmidt
UART2 peripheral is missing from the regmap fixup table of the g12a family
clock controller. As it is, any access to this clock would Oops, which is
not great.
Add the clock to the table to fix the problem.
Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
Reported-by: Dmitry Shmidt <dimitrysh@google.com>
Tested-by: Dmitry Shmidt <dimitrysh@google.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/meson/g12a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index 66cf791bfc8c..cd1de3e004e4 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = {
&g12a_bt656,
&g12a_usb1_to_ddr,
&g12a_mmc_pclk,
+ &g12a_uart2,
&g12a_vpu_intr,
&g12a_gic,
&g12a_sd_emmc_a_clk0,
--
2.23.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
@ 2019-12-13 10:33 ` Jerome Brunet
0 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2019-12-13 10:33 UTC (permalink / raw)
To: Neil Armstrong
Cc: Dmitry Shmidt, Kevin Hilman, linux-kernel, linux-amlogic,
linux-clk, Jerome Brunet
UART2 peripheral is missing from the regmap fixup table of the g12a family
clock controller. As it is, any access to this clock would Oops, which is
not great.
Add the clock to the table to fix the problem.
Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
Reported-by: Dmitry Shmidt <dimitrysh@google.com>
Tested-by: Dmitry Shmidt <dimitrysh@google.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/meson/g12a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index 66cf791bfc8c..cd1de3e004e4 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = {
&g12a_bt656,
&g12a_usb1_to_ddr,
&g12a_mmc_pclk,
+ &g12a_uart2,
&g12a_vpu_intr,
&g12a_gic,
&g12a_sd_emmc_a_clk0,
--
2.23.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
2019-12-13 10:33 ` Jerome Brunet
@ 2019-12-13 10:34 ` Neil Armstrong
-1 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2019-12-13 10:34 UTC (permalink / raw)
To: Jerome Brunet
Cc: Kevin Hilman, linux-amlogic, linux-clk, linux-kernel, Dmitry Shmidt
On 13/12/2019 11:33, Jerome Brunet wrote:
> UART2 peripheral is missing from the regmap fixup table of the g12a family
> clock controller. As it is, any access to this clock would Oops, which is
> not great.
>
> Add the clock to the table to fix the problem.
>
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Tested-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/g12a.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 66cf791bfc8c..cd1de3e004e4 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = {
> &g12a_bt656,
> &g12a_usb1_to_ddr,
> &g12a_mmc_pclk,
> + &g12a_uart2,
> &g12a_vpu_intr,
> &g12a_gic,
> &g12a_sd_emmc_a_clk0,
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
@ 2019-12-13 10:34 ` Neil Armstrong
0 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2019-12-13 10:34 UTC (permalink / raw)
To: Jerome Brunet
Cc: Kevin Hilman, Dmitry Shmidt, linux-clk, linux-kernel, linux-amlogic
On 13/12/2019 11:33, Jerome Brunet wrote:
> UART2 peripheral is missing from the regmap fixup table of the g12a family
> clock controller. As it is, any access to this clock would Oops, which is
> not great.
>
> Add the clock to the table to fix the problem.
>
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Tested-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/g12a.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 66cf791bfc8c..cd1de3e004e4 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = {
> &g12a_bt656,
> &g12a_usb1_to_ddr,
> &g12a_mmc_pclk,
> + &g12a_uart2,
> &g12a_vpu_intr,
> &g12a_gic,
> &g12a_sd_emmc_a_clk0,
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
2019-12-13 10:33 ` Jerome Brunet
@ 2019-12-13 16:44 ` Kevin Hilman
-1 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2019-12-13 16:44 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Jerome Brunet, linux-amlogic, linux-clk, linux-kernel, Dmitry Shmidt
Jerome Brunet <jbrunet@baylibre.com> writes:
> UART2 peripheral is missing from the regmap fixup table of the g12a family
> clock controller. As it is, any access to this clock would Oops, which is
> not great.
>
> Add the clock to the table to fix the problem.
>
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Tested-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
@ 2019-12-13 16:44 ` Kevin Hilman
0 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2019-12-13 16:44 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: linux-amlogic, Dmitry Shmidt, linux-clk, linux-kernel, Jerome Brunet
Jerome Brunet <jbrunet@baylibre.com> writes:
> UART2 peripheral is missing from the regmap fixup table of the g12a family
> clock controller. As it is, any access to this clock would Oops, which is
> not great.
>
> Add the clock to the table to fix the problem.
>
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Tested-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
2019-12-13 16:44 ` Kevin Hilman
@ 2019-12-16 9:30 ` Jerome Brunet
-1 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2019-12-16 9:30 UTC (permalink / raw)
To: Kevin Hilman, Neil Armstrong
Cc: linux-amlogic, linux-clk, linux-kernel, Dmitry Shmidt
On Fri 13 Dec 2019 at 17:44, Kevin Hilman <khilman@baylibre.com> wrote:
> Jerome Brunet <jbrunet@baylibre.com> writes:
>
>> UART2 peripheral is missing from the regmap fixup table of the g12a family
>> clock controller. As it is, any access to this clock would Oops, which is
>> not great.
>>
>> Add the clock to the table to fix the problem.
>>
>> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
>> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
>> Tested-by: Dmitry Shmidt <dimitrysh@google.com>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
Applied for fixes
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
@ 2019-12-16 9:30 ` Jerome Brunet
0 siblings, 0 replies; 9+ messages in thread
From: Jerome Brunet @ 2019-12-16 9:30 UTC (permalink / raw)
To: Kevin Hilman, Neil Armstrong
Cc: linux-amlogic, Dmitry Shmidt, linux-clk, linux-kernel
On Fri 13 Dec 2019 at 17:44, Kevin Hilman <khilman@baylibre.com> wrote:
> Jerome Brunet <jbrunet@baylibre.com> writes:
>
>> UART2 peripheral is missing from the regmap fixup table of the g12a family
>> clock controller. As it is, any access to this clock would Oops, which is
>> not great.
>>
>> Add the clock to the table to fix the problem.
>>
>> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
>> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
>> Tested-by: Dmitry Shmidt <dimitrysh@google.com>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
Applied for fixes
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
2019-12-13 10:33 ` Jerome Brunet
` (2 preceding siblings ...)
(?)
@ 2019-12-16 20:01 ` patchwork-bot+linux-amlogic
-1 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+linux-amlogic @ 2019-12-16 20:01 UTC (permalink / raw)
To: Jerome Brunet; +Cc: linux-amlogic, khilman
Hello:
This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).
On Fri, 13 Dec 2019 11:33:04 +0100 you wrote:
> UART2 peripheral is missing from the regmap fixup table of the g12a family
> clock controller. As it is, any access to this clock would Oops, which is
> not great.
>
> Add the clock to the table to fix the problem.
>
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Tested-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> [...]
Here is a summary with links:
- clk: meson: g12a: fix missing uart2 in regmap table
https://git.kernel.org/khilman/linux-amlogic/c/b1b3f0622a9d52ac19a63619911823c89a4d85a4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-12-16 20:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 10:33 [PATCH] clk: meson: g12a: fix missing uart2 in regmap table Jerome Brunet
2019-12-13 10:33 ` Jerome Brunet
2019-12-13 10:34 ` Neil Armstrong
2019-12-13 10:34 ` Neil Armstrong
2019-12-13 16:44 ` Kevin Hilman
2019-12-13 16:44 ` Kevin Hilman
2019-12-16 9:30 ` Jerome Brunet
2019-12-16 9:30 ` Jerome Brunet
2019-12-16 20:01 ` patchwork-bot+linux-amlogic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.