From: Jerome Brunet <jbrunet@baylibre.com> To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Jerome Brunet <jbrunet@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Kevin Hilman <khilman@baylibre.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org, JunYi Zhao <junyi.zhao@amlogic.com> Subject: Re: [PATCH v5 5/5] pwm: meson: add generic compatible for meson8 to sm1 Date: Thu, 18 Apr 2024 13:57:03 +0200 [thread overview] Message-ID: <1jplumc276.fsf@starbuckisacylon.baylibre.com> (raw) In-Reply-To: <24ec3iiudmfapiosygpsvgu7kmdqe6csbkpuzx3p3sa4oyodqu@hshmbpvzhufb> On Fri 12 Apr 2024 at 14:08, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > [[PGP Signed Part:Undecided]] > On Wed, Feb 21, 2024 at 04:11:51PM +0100, Jerome Brunet wrote: >> Introduce a new compatible support in the Amlogic PWM driver. >> >> The PWM HW is actually the same for all SoCs supported so far. A specific >> compatible is needed only because the clock sources of the PWMs are >> hard-coded in the driver. >> >> It is better to have the clock source described in DT but this changes the >> bindings so a new compatible must be introduced. >> >> When all supported platform have migrated to the new compatible, support >> for the legacy ones may be removed from the driver. >> >> The addition of this new compatible makes the old ones obsolete, as >> described in the DT documentation. >> >> Adding a callback to setup the clock will also make it easier to add >> support for the new PWM HW found in a1, s4, c3 and t7 SoC families. >> >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > After spending some brain cycles on this one I think I understood it. > Looks fine to me, I only considered questioning if the dev_warn_once is > too offensive. > > b4 + git applied the patch just fine even without patch #4 of this > series. Would you be so kind to double check it works as intended? It does, Thx. > > BTW, b4 diagnosed: > > Checking attestation on all messages, may take a moment... > --- > ✗ [PATCH v5 5/5] pwm: meson: add generic compatible for meson8 to sm1 > + Link: https://lore.kernel.org/r/20240221151154.26452-6-jbrunet@baylibre.com > + Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > ✗ BADSIG: DKIM/baylibre-com.20230601.gappssmtp.com > > Is this only because it took me so long to reply, or is there a > configuration issue with the baylibre MTA? I have no idea. This is the first time this is reported > > Best regards > Uwe -- Jerome
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com> To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Jerome Brunet <jbrunet@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Kevin Hilman <khilman@baylibre.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org, JunYi Zhao <junyi.zhao@amlogic.com> Subject: Re: [PATCH v5 5/5] pwm: meson: add generic compatible for meson8 to sm1 Date: Thu, 18 Apr 2024 13:57:03 +0200 [thread overview] Message-ID: <1jplumc276.fsf@starbuckisacylon.baylibre.com> (raw) In-Reply-To: <24ec3iiudmfapiosygpsvgu7kmdqe6csbkpuzx3p3sa4oyodqu@hshmbpvzhufb> On Fri 12 Apr 2024 at 14:08, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > [[PGP Signed Part:Undecided]] > On Wed, Feb 21, 2024 at 04:11:51PM +0100, Jerome Brunet wrote: >> Introduce a new compatible support in the Amlogic PWM driver. >> >> The PWM HW is actually the same for all SoCs supported so far. A specific >> compatible is needed only because the clock sources of the PWMs are >> hard-coded in the driver. >> >> It is better to have the clock source described in DT but this changes the >> bindings so a new compatible must be introduced. >> >> When all supported platform have migrated to the new compatible, support >> for the legacy ones may be removed from the driver. >> >> The addition of this new compatible makes the old ones obsolete, as >> described in the DT documentation. >> >> Adding a callback to setup the clock will also make it easier to add >> support for the new PWM HW found in a1, s4, c3 and t7 SoC families. >> >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > After spending some brain cycles on this one I think I understood it. > Looks fine to me, I only considered questioning if the dev_warn_once is > too offensive. > > b4 + git applied the patch just fine even without patch #4 of this > series. Would you be so kind to double check it works as intended? It does, Thx. > > BTW, b4 diagnosed: > > Checking attestation on all messages, may take a moment... > --- > ✗ [PATCH v5 5/5] pwm: meson: add generic compatible for meson8 to sm1 > + Link: https://lore.kernel.org/r/20240221151154.26452-6-jbrunet@baylibre.com > + Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > ✗ BADSIG: DKIM/baylibre-com.20230601.gappssmtp.com > > Is this only because it took me so long to reply, or is there a > configuration issue with the baylibre MTA? I have no idea. This is the first time this is reported > > Best regards > Uwe -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-04-18 11:58 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-21 15:11 [PATCH v5 0/5] pwm: meson: dt-bindings fixup Jerome Brunet 2024-02-21 15:11 ` Jerome Brunet 2024-02-21 15:11 ` [PATCH v5 1/5] dt-bindings: pwm: amlogic: fix s4 bindings Jerome Brunet 2024-02-21 15:11 ` Jerome Brunet 2024-02-21 15:11 ` [PATCH v5 2/5] dt-bindings: pwm: amlogic: Add a new binding for meson8 pwm types Jerome Brunet 2024-02-21 15:11 ` Jerome Brunet 2024-02-23 14:19 ` Rob Herring 2024-02-23 14:19 ` Rob Herring 2024-02-21 15:11 ` [PATCH v5 3/5] pwm: meson: generalize 4 inputs clock on meson8 pwm type Jerome Brunet 2024-02-21 15:11 ` Jerome Brunet 2024-02-21 15:11 ` [PATCH v5 4/5] pwm: meson: don't carry internal clock elements around Jerome Brunet 2024-02-21 15:11 ` Jerome Brunet 2024-04-12 11:27 ` Uwe Kleine-König 2024-04-12 11:27 ` Uwe Kleine-König 2024-02-21 15:11 ` [PATCH v5 5/5] pwm: meson: add generic compatible for meson8 to sm1 Jerome Brunet 2024-02-21 15:11 ` Jerome Brunet 2024-04-12 12:08 ` Uwe Kleine-König 2024-04-12 12:08 ` Uwe Kleine-König 2024-04-18 11:57 ` Jerome Brunet [this message] 2024-04-18 11:57 ` Jerome Brunet 2024-04-18 16:08 ` Uwe Kleine-König 2024-04-18 16:08 ` Uwe Kleine-König 2024-04-23 8:08 ` Neil Armstrong 2024-04-23 8:08 ` Neil Armstrong 2024-03-02 10:04 ` [PATCH v5 0/5] pwm: meson: dt-bindings fixup Uwe Kleine-König 2024-03-02 10:04 ` Uwe Kleine-König 2024-03-02 15:50 ` Jerome Brunet 2024-03-02 15:50 ` Jerome Brunet 2024-04-12 8:04 ` Jerome Brunet 2024-04-12 8:04 ` Jerome Brunet 2024-04-12 8:29 ` George Stark 2024-04-12 8:29 ` George Stark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1jplumc276.fsf@starbuckisacylon.baylibre.com \ --to=jbrunet@baylibre.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=junyi.zhao@amlogic.com \ --cc=khilman@baylibre.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=neil.armstrong@linaro.org \ --cc=robh+dt@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.